BsScraper::getFirstNonEmpty() - Code Metrics - Inspection of "Add 'language' search field" - scriptotek/colligator-backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f12d43...45cb1a )

by Dan Michael O.

created 2016-12-13 22:10 UTC

BsScraper::getFirstNonEmpty() A

↳ Parent: BsScraper

Complexity

Conditions	4
Paths	3

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	15
rs	9.2
cc	4
eloc	10
nc	3
nop	1

<?php

namespace Colligator\Scrapers;

use Symfony\Component\DomCrawler\Crawler;

class BsScraper extends Scraper implements ScraperInterface
{
    public function recognizes($url)
    {
        return strpos($url, 'bibsys.no');
    }

    public function getSections($texts)
    {
        // Secion list ordered by preference
        $sections = [
            'Beskrivelse fra forlaget (lang)'  => '',
            'Publisher\'s description (full)'  => '',
            'Beskrivelse fra Forlagssentralen' => '',
            'Beskrivelse fra forlaget (kort)'  => '',
            'Publisher\'s description (brief)' => '',
            'Innholdsfortegnelse'              => '',
        ];

        $next = '';
        foreach ($texts as $t) {
            if ($next != '') {
                $sections[$next] = $t;
                $next = '';
            }
            if (isset($sections[$t])) {
                // It's a section heading
                $next = $t;
            }
        }

        return $sections;
    }

    public function getFirstNonEmpty($sections)
    {
        $text = '';
        $source = '';
        foreach ($sections as $k => $v) {
            $v = explode('©', $v);
            if (count($v) > 1 && !empty($v[0])) {
                $text = $v[0];
                $source = $v[1];
                break;
            }
        }

        return [$text, $source];
    }

    public function scrape(Crawler $crawler)
    {
        $texts = $crawler->filter('#accordion > *')->each(function (Crawler $node) {
            return $node->text();
        });

        $sections = $this->getSections($texts);
        list($text, $source) = $this->getFirstNonEmpty($sections);

        return $this->returnResult($text, $source);
    }
}


1			<?php
2
3			namespace Colligator\Scrapers;
4
5			use Symfony\Component\DomCrawler\Crawler;
6
7			class BsScraper extends Scraper implements ScraperInterface
8			{
9			public function recognizes($url)
10			{
11			return strpos($url, 'bibsys.no');
12			}
13
14			public function getSections($texts)
15			{
16			// Secion list ordered by preference
17			$sections = [
18			'Beskrivelse fra forlaget (lang)' => '',
19			'Publisher\'s description (full)' => '',
20			'Beskrivelse fra Forlagssentralen' => '',
21			'Beskrivelse fra forlaget (kort)' => '',
22			'Publisher\'s description (brief)' => '',
23			'Innholdsfortegnelse' => '',
24			];
25
26			$next = '';
27			foreach ($texts as $t) {
28			if ($next != '') {
29			$sections[$next] = $t;
30			$next = '';
31			}
32			if (isset($sections[$t])) {
33			// It's a section heading
34			$next = $t;
35			}
36			}
37
38			return $sections;
39			}
40
41			public function getFirstNonEmpty($sections)
42			{
43			$text = '';
44			$source = '';
45			foreach ($sections as $k => $v) {
46			$v = explode('©', $v);
47			if (count($v) > 1 && !empty($v[0])) {
48			$text = $v[0];
49			$source = $v[1];
50			break;
51			}
52			}
53
54			return [$text, $source];
55			}
56
57			public function scrape(Crawler $crawler)
58			{
59			$texts = $crawler->filter('#accordion > *')->each(function (Crawler $node) {
60			return $node->text();
61			});
62
63			$sections = $this->getSections($texts);
64			list($text, $source) = $this->getFirstNonEmpty($sections);
65
66			return $this->returnResult($text, $source);
67			}
68			}
69

scriptotek / colligator-backend

Push — master ( f12d43...45cb1a )

BsScraper::getFirstNonEmpty() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like