NotOnLoan::passes() - Code Metrics - scriptotek/bibrex - Measure and Improve Code Quality continuously with Scrutinizer

NotOnLoan::passes() A
last analyzed 2020-08-20 14:30 UTC

↳ Parent: NotOnLoan

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	4
eloc	10
c	1
b	0
f	1
nc	4
nop	2
dl	0
loc	22
rs	9.9332

<?php

namespace App\Rules;

use App\Item;
use Illuminate\Contracts\Validation\Rule;
use Scriptotek\Alma\Bibs\Item as AlmaItem;
use Scriptotek\Alma\Client as AlmaClient;

class NotOnLoan implements Rule
{
    protected $alma;
    protected $item;
    protected $what;

    /**
     * Create a new rule instance.
     *
     * @param AlmaClient $alma
     * @param $item
     */
    public function __construct(AlmaClient $alma, $item = null)
    {
        $this->alma = $alma;
        $this->item = $item;
        $this->msg = 'Tingen er allerede utlånt i Bibrex.';

    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @return bool
     */
    public function passes($attribute, $value)
    {
        if (is_null($this->item)) {
            return true;
        }

        if (is_a($this->item, AlmaItem::class)) {
            $almaLoan = $this->item->loan;
            $this->msg = 'Dokumentet er allerede utlånt i Alma.';


            return is_null($almaLoan);
        }

        // Always true if the item is a generic representation without barcode
        if (is_null($this->item->barcode)) {
            return true;
        }

        // Check if already on loan
        $loan = $this->item->loans()->first();

        return is_null($loan);
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return $this->msg;
    }
}


1			<?php
2
3			namespace App\Rules;
4
5			use App\Item;
6			use Illuminate\Contracts\Validation\Rule;
7			use Scriptotek\Alma\Bibs\Item as AlmaItem;
8			use Scriptotek\Alma\Client as AlmaClient;
9
10			class NotOnLoan implements Rule
11			{
12			protected $alma;
13			protected $item;
14			protected $what;
15
16			/**
17			* Create a new rule instance.
18			*
19			* @param AlmaClient $alma
20			* @param $item
21			*/
22			public function __construct(AlmaClient $alma, $item = null)
23			{
24			$this->alma = $alma;
25			$this->item = $item;
26			$this->msg = 'Tingen er allerede utlånt i Bibrex.';
			0 ignored issues – show Bug Best Practice introduced 2018-08-01 12:12 UTC by Report Bug Copy Issue Report The property `msg` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
27			}
28
29			/**
30			* Determine if the validation rule passes.
31			*
32			* @param string $attribute
33			* @param mixed $value
34			* @return bool
35			*/
36			public function passes($attribute, $value)
37			{
38			if (is_null($this->item)) {
39			return true;
40			}
41
42			if (is_a($this->item, AlmaItem::class)) {
43			$almaLoan = $this->item->loan;
44			$this->msg = 'Dokumentet er allerede utlånt i Alma.';
			0 ignored issues – show Bug Best Practice introduced 2018-08-01 12:12 UTC by Report Bug Copy Issue Report The property `msg` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
45
46			return is_null($almaLoan);
47			}
48
49			// Always true if the item is a generic representation without barcode
50			if (is_null($this->item->barcode)) {
51			return true;
52			}
53
54			// Check if already on loan
55			$loan = $this->item->loans()->first();
56
57			return is_null($loan);
58			}
59
60			/**
61			* Get the validation error message.
62			*
63			* @return string
64			*/
65			public function message()
66			{
67			return $this->msg;
68			}
69			}
70

scriptotek / bibrex

NotOnLoan::passes() A last analyzed 2020-08-20 14:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

NotOnLoan::passes() A
last analyzed 2020-08-20 14:30 UTC