App\Rules\NotOnLoan

Complexity

Total Complexity

6

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	message()	0	3	1
A	passes()	0	22	4

<?php

namespace App\Rules;

use App\Item;
use Illuminate\Contracts\Validation\Rule;
use Scriptotek\Alma\Bibs\Item as AlmaItem;
use Scriptotek\Alma\Client as AlmaClient;

class NotOnLoan implements Rule
{
    protected $alma;
    protected $item;
    protected $what;

    /**
     * Create a new rule instance.
     *
     * @param AlmaClient $alma
     * @param $item
     */
    public function __construct(AlmaClient $alma, $item = null)
    {
        $this->alma = $alma;
        $this->item = $item;
        $this->msg = 'Tingen er allerede utlånt i Bibrex.';

The property msg does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @return bool
     */
    public function passes($attribute, $value)
    {
        if (is_null($this->item)) {
            return true;
        }

        if (is_a($this->item, AlmaItem::class)) {
            $almaLoan = $this->item->loan;
            $this->msg = 'Dokumentet er allerede utlånt i Alma.';

The property msg does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return is_null($almaLoan);
        }

        // Always true if the item is a generic representation without barcode
        if (is_null($this->item->barcode)) {
            return true;
        }

        // Check if already on loan
        $loan = $this->item->loans()->first();

        return is_null($loan);
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return $this->msg;
    }
}