Amountable::bootAmountable() - Code Metrics - Inspection of "Extract amount logic to a trait" - scottbedard/oc-shop-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a1e415...8aec58 )

by Scott

created 2016-12-15 14:10 UTC

Amountable::bootAmountable() B

↳ Parent: Amountable

Complexity

Conditions	1
Paths	1

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	14
nc	1
nop	0

<?php namespace Bedard\Shop\Traits;

trait Amountable
{
    /**
     * Boot the amountable trait for this model.
     *
     * @return void
     */
    public static function bootAmountable()
    {
        static::extend(function ($model) {
            $model->rules = array_merge($model->rules, [
                'amount_exact' => 'numeric|min:0',
                'amount_percentage' => 'numeric|min:0|max:100',
            ]);

            $model->purgeable = array_merge($model->purgeable, [
                'amount_exact',
                'amount_percentage',
            ]);

            $model->attributes = array_merge($model->attributes, [
                'amount_exact' => 0,
                'amount_percentage' => 0,
            ]);

            $model->addFillable('amount_exact', 'amount_percentage');

            $model->bindEvent('model.beforeSave', function () use ($model) {
                $model->setAmount();
            });
        });
    }

    /**
     * Get the exact amount.
     *
     * @return float
     */
    public function getAmountExactAttribute()
    {
        return ! $this->is_percentage ? $this->amount : 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the percentage amount.
     *
     * @return float
     */
    public function getAmountPercentageAttribute()
    {
        return $this->is_percentage ? $this->amount : 0;
    }

    /**
     * Set the promotion amount.
     *
     * @return  void
     */
    public function setAmount()
    {
        $exact = $this->getOriginalPurgeValue('amount_exact');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $percentage = $this->getOriginalPurgeValue('amount_percentage');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->amount = $this->is_percentage
            ? $percentage
            : $exact;
    }
}


1			<?php namespace Bedard\Shop\Traits;
2
3			trait Amountable
4			{
5			/**
6			* Boot the amountable trait for this model.
7			*
8			* @return void
9			*/
10			public static function bootAmountable()
11			{
12			static::extend(function ($model) {
13			$model->rules = array_merge($model->rules, [
14			'amount_exact' => 'numeric\|min:0',
15			'amount_percentage' => 'numeric\|min:0\|max:100',
16			]);
17
18			$model->purgeable = array_merge($model->purgeable, [
19			'amount_exact',
20			'amount_percentage',
21			]);
22
23			$model->attributes = array_merge($model->attributes, [
24			'amount_exact' => 0,
25			'amount_percentage' => 0,
26			]);
27
28			$model->addFillable('amount_exact', 'amount_percentage');
29
30			$model->bindEvent('model.beforeSave', function () use ($model) {
31			$model->setAmount();
32			});
33			});
34			}
35
36			/**
37			* Get the exact amount.
38			*
39			* @return float
40			*/
41			public function getAmountExactAttribute()
42			{
43			return ! $this->is_percentage ? $this->amount : 0;
			0 ignored issues – show Bug introduced 2016-12-15 14:12 UTC by Report Bug Copy Issue Report The property `is_percentage` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2016-12-15 14:12 UTC by Report Bug Copy Issue Report The property `amount` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			}
45
46			/**
47			* Get the percentage amount.
48			*
49			* @return float
50			*/
51			public function getAmountPercentageAttribute()
52			{
53			return $this->is_percentage ? $this->amount : 0;
54			}
55
56			/**
57			* Set the promotion amount.
58			*
59			* @return void
60			*/
61			public function setAmount()
62			{
63			$exact = $this->getOriginalPurgeValue('amount_exact');
			0 ignored issues – show Bug introduced 2016-12-15 14:12 UTC by Report Bug Copy Issue Report It seems like `getOriginalPurgeValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64			$percentage = $this->getOriginalPurgeValue('amount_percentage');
			0 ignored issues – show Bug introduced 2016-12-15 14:12 UTC by Report Bug Copy Issue Report It seems like `getOriginalPurgeValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
65
66			$this->amount = $this->is_percentage
67			? $percentage
68			: $exact;
69			}
70			}
71

scottbedard / oc-shop-plugin

Push — master ( a1e415...8aec58 )

Amountable::bootAmountable() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like