Bedard\Shop\Traits\Amountable

Complexity

Total Complexity

7

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	bootAmountable()	0	25	1
A	getAmountExactAttribute()	0	4	2
A	getAmountPercentageAttribute()	0	4	2
A	setAmount()	0	9	2

<?php namespace Bedard\Shop\Traits;

trait Amountable
{
    /**
     * Boot the amountable trait for this model.
     *
     * @return void
     */
    public static function bootAmountable()
    {
        static::extend(function ($model) {
            $model->rules = array_merge($model->rules, [
                'amount_exact' => 'numeric|min:0',
                'amount_percentage' => 'numeric|min:0|max:100',
            ]);

            $model->purgeable = array_merge($model->purgeable, [
                'amount_exact',
                'amount_percentage',
            ]);

            $model->attributes = array_merge($model->attributes, [
                'amount_exact' => 0,
                'amount_percentage' => 0,
            ]);

            $model->addFillable('amount_exact', 'amount_percentage');

            $model->bindEvent('model.beforeSave', function () use ($model) {
                $model->setAmount();
            });
        });
    }

    /**
     * Get the exact amount.
     *
     * @return float
     */
    public function getAmountExactAttribute()
    {
        return ! $this->is_percentage ? $this->amount : 0;

The property is_percentage does not exist. Did you maybe forget to declare it?

The property amount does not exist. Did you maybe forget to declare it?

    }

    /**
     * Get the percentage amount.
     *
     * @return float
     */
    public function getAmountPercentageAttribute()
    {
        return $this->is_percentage ? $this->amount : 0;
    }

    /**
     * Set the promotion amount.
     *
     * @return  void
     */
    public function setAmount()
    {
        $exact = $this->getOriginalPurgeValue('amount_exact');

It seems like getOriginalPurgeValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $percentage = $this->getOriginalPurgeValue('amount_percentage');

It seems like getOriginalPurgeValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->amount = $this->is_percentage
            ? $percentage
            : $exact;
    }
}