schmittjoh / serializer

src/JMS/Serializer/SerializerBuilder.php

Unused Use Statements -6 removed lines

@@ -23,17 +23,11 @@
 use JMS\Serializer\Handler\PhpCollectionHandler;
 use JMS\Serializer\Handler\PropelCollectionHandler;
 use JMS\Serializer\Exception\RuntimeException;
-use Metadata\Driver\DriverInterface;
 use Metadata\MetadataFactory;
-use JMS\Serializer\Metadata\Driver\AnnotationDriver;
 use JMS\Serializer\Handler\HandlerRegistry;
 use JMS\Serializer\Construction\UnserializeObjectConstructor;
 use PhpCollection\Map;
 use JMS\Serializer\EventDispatcher\EventDispatcher;
-use Metadata\Driver\DriverChain;
-use JMS\Serializer\Metadata\Driver\YamlDriver;
-use JMS\Serializer\Metadata\Driver\XmlDriver;
-use Metadata\Driver\FileLocator;
 use JMS\Serializer\Handler\DateHandler;
 use JMS\Serializer\Handler\ArrayCollectionHandler;
 use JMS\Serializer\Construction\ObjectConstructorInterface;

src/JMS/Serializer/EventDispatcher/EventDispatcher.php

Spacing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
             $this->classListeners[$eventName][$loweredClass][$format] = $this->initializeListeners($eventName, $loweredClass, $format);
         }
 
-        return !!$this->classListeners[$eventName][$loweredClass][$format];
+        return ! ! $this->classListeners[$eventName][$loweredClass][$format];
     }
 
     public function dispatch($eventName, $class, $format, Event $event)

src/JMS/Serializer/EventDispatcher/Events.php

Braces +3 added lines, -1 removed lines

@@ -25,5 +25,7 @@
     const PRE_DESERIALIZE = 'serializer.pre_deserialize';
     const POST_DESERIALIZE = 'serializer.post_deserialize';
 
-    final private function __construct() { }
+    final private function __construct()
+    {
+}
 }

src/JMS/Serializer/Metadata/Driver/YamlDriver.php

Indentation +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
 
                     //we need read_only before setter and getter set, because that method depends on flag being set
                     if (isset($pConfig['read_only'])) {
-                          $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
+                            $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
                     } else {
                         $pMetadata->readOnly = $pMetadata->readOnly || $readOnlyClass;
                     }

src/JMS/Serializer/TypeParser.php

Indentation +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
                 |(.)
             /x',
             array(self::T_NAME => 'T_NAME', self::T_STRING => 'T_STRING', self::T_OPEN_BRACKET => 'T_OPEN_BRACKET',
-                  self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
+                    self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
             function($value) {
                 switch ($value[0]) {
                     case '"':

src/JMS/Serializer/Util/Writer.php

Spacing +3 added lines, -3 removed lines

@@ -83,16 +83,16 @@
         $addition = '';
 
         $lines = explode("\n", $content);
-        for ($i=0,$c=count($lines); $i<$c; $i++) {
+        for ($i = 0, $c = count($lines); $i < $c; $i++) {
             if ($this->indentationLevel > 0
-                && !empty($lines[$i])
+                && ! empty($lines[$i])
                 && ((empty($addition) && "\n" === substr($this->content, -1)) || "\n" === substr($addition, -1))) {
                 $addition .= str_repeat(' ', $this->indentationLevel * $this->indentationSpaces);
             }
 
             $addition .= $lines[$i];
 
-            if ($i+1 < $c) {
+            if ($i + 1 < $c) {
                 $addition .= "\n";
             }
         }

src/JMS/Serializer/YamlSerializationVisitor.php

Indentation +2 added lines, -2 removed lines

@@ -168,8 +168,8 @@
 
         if ( ! $metadata->inline) {
             $this->writer
-                 ->writeln(Inline::dump($name).':')
-                 ->indent();
+                    ->writeln(Inline::dump($name).':')
+                    ->indent();
         }
 
         $this->setCurrentMetadata($metadata);

src/JMS/Serializer/XmlSerializationVisitor.php

Spacing +7 added lines, -7 removed lines

@@ -197,7 +197,7 @@ 
             $this->document = $this->createDocument(null, null, false);
             if ($metadata->xmlRootName) {
                 $rootName = $metadata->xmlRootName;
-                $rootNamespace = $metadata->xmlRootNamespace?:$this->getClassDefaultNamespace($metadata);
+                $rootNamespace = $metadata->xmlRootNamespace ?: $this->getClassDefaultNamespace($metadata);
             } else {
                 $rootName = $this->defaultRootName;
                 $rootNamespace = $this->defaultRootNamespace;
@@ -444,10 +444,10 @@ 
             if ($this->currentNode->isDefaultNamespace($namespace)) {
                 return $this->document->createElementNS($namespace, $tagName);
             } else {
-                if (!$prefix = $this->currentNode->lookupPrefix($namespace)) {
-                    $prefix = 'ns-'.  substr(sha1($namespace), 0, 8);
+                if ( ! $prefix = $this->currentNode->lookupPrefix($namespace)) {
+                    $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
                 }
-                return $this->document->createElementNS($namespace, $prefix . ':' . $tagName);
+                return $this->document->createElementNS($namespace, $prefix.':'.$tagName);
             }
 
 
@@ -459,8 +459,8 @@ 
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
     {
         if (null !== $namespace) {
-            if (!$prefix = $node->lookupPrefix($namespace)) {
-                $prefix = 'ns-'.  substr(sha1($namespace), 0, 8);
+            if ( ! $prefix = $node->lookupPrefix($namespace)) {
+                $prefix = 'ns-'.substr(sha1($namespace), 0, 8);
             }
             $node->setAttributeNS($namespace, $prefix.':'.$name, $value);
         } else {
@@ -470,7 +470,7 @@ 
 
     private function getClassDefaultNamespace(ClassMetadata $metadata)
     {
-        return (isset($metadata->xmlNamespaces[''])?$metadata->xmlNamespaces['']:null);
+        return (isset($metadata->xmlNamespaces['']) ? $metadata->xmlNamespaces[''] : null);
     }
 
 }

Doc Comments +12 added lines

@@ -44,6 +44,9 @@ 
     private $nullWasVisited;
     private $objectMetadataStack;
 
+    /**
+     * @param Naming\PropertyNamingStrategyInterface $namingStrategy
+     */
     public function __construct($namingStrategy)
     {
         parent::__construct($namingStrategy);
@@ -126,6 +129,9 @@ 
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
     }
 
+    /**
+     * @param string $data
+     */
     public function visitSimpleString($data, array $type, Context $context)
     {
         if (null === $this->document) {
@@ -437,6 +443,9 @@ 
         }
     }
 
+    /**
+     * @return \DOMNode
+     */
     private function createElement($tagName, $namespace = null)
     {
         if (null !== $namespace) {
@@ -456,6 +465,9 @@ 
         }
     }
 
+    /**
+     * @param string $value
+     */
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
     {
         if (null !== $namespace) {

src/JMS/Serializer/XmlDeserializationVisitor.php

Indentation +1 added lines, -1 removed lines

@@ -226,7 +226,7 @@
             throw new RuntimeException(sprintf('You must define a type for %s::$%s.', $metadata->reflection->class, $metadata->name));
         }
 
-       if ($metadata->xmlAttribute) {
+        if ($metadata->xmlAttribute) {
 
             $attributes = $data->attributes($metadata->xmlNamespace);
             if (isset($attributes[$name])) {

Doc Comments -1 removed lines

@@ -346,7 +346,6 @@
     /**
      * Retrieves internalSubset even in bugfixed php versions
      *
-     * @param \DOMDocumentType $child
      * @param string $data
      * @return string
      */

Spacing +7 added lines, -7 removed lines

@@ -63,7 +63,7 @@ 
 
         if (false !== stripos($data, '<!doctype')) {
             $internalSubset = $this->getDomDocumentTypeEntitySubset($data);
-            if (!in_array($internalSubset, $this->doctypeWhitelist, true)) {
+            if ( ! in_array($internalSubset, $this->doctypeWhitelist, true)) {
                 throw new InvalidArgumentException(sprintf(
                     'The document type "%s" is not allowed. If it is safe, you may add it to the whitelist configuration.',
                     $internalSubset
@@ -147,10 +147,10 @@ 
 
         if ($namespace === null && $this->objectMetadataStack->count()) {
             $classMetadata = $this->objectMetadataStack->top();
-            $namespace = isset($classMetadata->xmlNamespaces[''])?$classMetadata->xmlNamespaces['']:$namespace;
+            $namespace = isset($classMetadata->xmlNamespaces['']) ? $classMetadata->xmlNamespaces[''] : $namespace;
         }
 
-        if ( ! isset($data->$entryName) ) {
+        if ( ! isset($data->$entryName)) {
             if (null === $this->result) {
                 return $this->result = array();
             }
@@ -242,7 +242,7 @@ 
 
         if ($metadata->xmlCollection) {
             $enclosingElem = $data;
-            if (!$metadata->xmlCollectionInline) {
+            if ( ! $metadata->xmlCollectionInline) {
                 $enclosingElem = $data->children($metadata->xmlNamespace)->$name;
             }
 
@@ -256,7 +256,7 @@ 
 
         if ($metadata->xmlNamespace) {
             $node = $data->children($metadata->xmlNamespace)->$name;
-            if (!$node->count()) {
+            if ( ! $node->count()) {
                 return;
             }
         } else {
@@ -266,13 +266,13 @@ 
             if (isset($namespaces[''])) {
                 $prefix = uniqid('ns-');
                 $data->registerXPathNamespace($prefix, $namespaces['']);
-                $nodes = $data->xpath('./'.$prefix. ':'.$name );
+                $nodes = $data->xpath('./'.$prefix.':'.$name);
                 if (empty($nodes)) {
                     return;
                 }
                 $node = reset($nodes);
             } else {
-                if (!isset($data->$name)) {
+                if ( ! isset($data->$name)) {
                     return;
                 }
                 $node = $data->$name;