schmittjoh / serializer

src/JMS/Serializer/SerializerBuilder.php

Unused Use Statements -6 removed lines

@@ -23,17 +23,11 @@
 use JMS\Serializer\Handler\PhpCollectionHandler;
 use JMS\Serializer\Handler\PropelCollectionHandler;
 use JMS\Serializer\Exception\RuntimeException;
-use Metadata\Driver\DriverInterface;
 use Metadata\MetadataFactory;
-use JMS\Serializer\Metadata\Driver\AnnotationDriver;
 use JMS\Serializer\Handler\HandlerRegistry;
 use JMS\Serializer\Construction\UnserializeObjectConstructor;
 use PhpCollection\Map;
 use JMS\Serializer\EventDispatcher\EventDispatcher;
-use Metadata\Driver\DriverChain;
-use JMS\Serializer\Metadata\Driver\YamlDriver;
-use JMS\Serializer\Metadata\Driver\XmlDriver;
-use Metadata\Driver\FileLocator;
 use JMS\Serializer\Handler\DateHandler;
 use JMS\Serializer\Handler\ArrayCollectionHandler;
 use JMS\Serializer\Construction\ObjectConstructorInterface;

src/JMS/Serializer/EventDispatcher/EventDispatcher.php

Spacing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
             $this->classListeners[$eventName][$loweredClass][$format] = $this->initializeListeners($eventName, $loweredClass, $format);
         }
 
-        return !!$this->classListeners[$eventName][$loweredClass][$format];
+        return ! ! $this->classListeners[$eventName][$loweredClass][$format];
     }
 
     public function dispatch($eventName, $class, $format, Event $event)

src/JMS/Serializer/EventDispatcher/Events.php

Braces +3 added lines, -1 removed lines

@@ -25,5 +25,7 @@
     const PRE_DESERIALIZE = 'serializer.pre_deserialize';
     const POST_DESERIALIZE = 'serializer.post_deserialize';
 
-    final private function __construct() { }
+    final private function __construct()
+    {
+}
 }

src/JMS/Serializer/Metadata/Driver/YamlDriver.php

Indentation +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
 
                     //we need read_only before setter and getter set, because that method depends on flag being set
                     if (isset($pConfig['read_only'])) {
-                          $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
+                            $pMetadata->readOnly = (Boolean) $pConfig['read_only'];
                     } else {
                         $pMetadata->readOnly = $pMetadata->readOnly || $readOnlyClass;
                     }

Spacing +3 added lines, -3 removed lines

@@ -113,15 +113,15 @@
 
                         $colConfig = $pConfig['xml_list'];
                         if (isset($colConfig['inline'])) {
-                            $pMetadata->xmlCollectionInline = (Boolean)$colConfig['inline'];
+                            $pMetadata->xmlCollectionInline = (Boolean) $colConfig['inline'];
                         }
 
                         if (isset($colConfig['entry_name'])) {
-                            $pMetadata->xmlEntryName = (string)$colConfig['entry_name'];
+                            $pMetadata->xmlEntryName = (string) $colConfig['entry_name'];
                         }
 
                         if (isset($colConfig['skip_when_empty'])) {
-                            $pMetadata->xmlCollectionSkipWhenEmpty = (Boolean)$colConfig['skip_when_empty'];
+                            $pMetadata->xmlCollectionSkipWhenEmpty = (Boolean) $colConfig['skip_when_empty'];
                         } else {
                             $pMetadata->xmlCollectionSkipWhenEmpty = true;
                         }

src/JMS/Serializer/TypeParser.php

Indentation +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
                 |(.)
             /x',
             array(self::T_NAME => 'T_NAME', self::T_STRING => 'T_STRING', self::T_OPEN_BRACKET => 'T_OPEN_BRACKET',
-                  self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
+                    self::T_CLOSE_BRACKET => 'T_CLOSE_BRACKET', self::T_COMMA => 'T_COMMA', self::T_NONE => 'T_NONE'),
             function($value) {
                 switch ($value[0]) {
                     case '"':

src/JMS/Serializer/Util/Writer.php

Spacing +3 added lines, -3 removed lines

@@ -83,16 +83,16 @@
         $addition = '';
 
         $lines = explode("\n", $content);
-        for ($i=0,$c=count($lines); $i<$c; $i++) {
+        for ($i = 0, $c = count($lines); $i < $c; $i++) {
             if ($this->indentationLevel > 0
-                && !empty($lines[$i])
+                && ! empty($lines[$i])
                 && ((empty($addition) && "\n" === substr($this->content, -1)) || "\n" === substr($addition, -1))) {
                 $addition .= str_repeat(' ', $this->indentationLevel * $this->indentationSpaces);
             }
 
             $addition .= $lines[$i];
 
-            if ($i+1 < $c) {
+            if ($i + 1 < $c) {
                 $addition .= "\n";
             }
         }

src/JMS/Serializer/YamlSerializationVisitor.php

Indentation +2 added lines, -2 removed lines

@@ -168,8 +168,8 @@
 
         if ( ! $metadata->inline) {
             $this->writer
-                 ->writeln(Inline::dump($name).':')
-                 ->indent();
+                    ->writeln(Inline::dump($name).':')
+                    ->indent();
         }
 
         $this->setCurrentMetadata($metadata);

src/JMS/Serializer/Metadata/Driver/AnnotationDriver.php

Doc Comments +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
     }
 
     /**
-     * @param array $groups
+     * @param string[] $groups
      * @param string $annotationSource
      */
     private function sanitizeGroupNames($groups, $annotationSource)

Spacing +4 added lines, -4 removed lines

@@ -191,8 +191,8 @@ 
                     } elseif ($annot instanceof Accessor) {
                         $accessor = array($annot->getter, $annot->setter);
                     } elseif ($annot instanceof Exclude) {
-                        if (!empty($annot->groups)) {
-                            $annotationSource = $propertyMetadata->class . '->' . $propertyMetadata->name;
+                        if ( ! empty($annot->groups)) {
+                            $annotationSource = $propertyMetadata->class.'->'.$propertyMetadata->name;
                             $this->sanitizeGroupNames($annot->groups, $annotationSource);
                             $propertyMetadata->exclusionGroups = $annot->groups;
                         } else {
@@ -201,7 +201,7 @@ 
 
                     } elseif ($annot instanceof Groups) {
                         $propertyMetadata->groups = $annot->groups;
-                        $annotationSource = $propertyMetadata->class . '->' . $propertyMetadata->name;
+                        $annotationSource = $propertyMetadata->class.'->'.$propertyMetadata->name;
                         $this->sanitizeGroupNames($propertyMetadata->groups, $annotationSource);
                     } elseif ($annot instanceof Inline) {
                         $propertyMetadata->inline = true;
@@ -229,7 +229,7 @@ 
      */
     private function sanitizeGroupNames($groups, $annotationSource)
     {
-        foreach ((array)$groups as $groupName) {
+        foreach ((array) $groups as $groupName) {
             if (false !== strpos($groupName, ',')) {
                 throw new InvalidArgumentException(sprintf(
                     'Invalid group name "%s" on "%s", did you mean to create multiple groups?',

src/JMS/Serializer/Exclusion/ExclusionGroupsExclusionStrategy.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
         if (is_array($metadataGroups) && empty($metadataGroups)) {
             return true;
         }
-        if (!empty($this->groups) && array_intersect(array_keys($this->groups), $metadataGroups)) {
+        if ( ! empty($this->groups) && array_intersect(array_keys($this->groups), $metadataGroups)) {
             return true;
         }
 

Braces +2 added lines, -1 removed lines

@@ -47,7 +47,8 @@
      * @param $metadataGroups
      * @return bool
      */
-    private function shouldSkipGroup($metadataGroups) {
+    private function shouldSkipGroup($metadataGroups)
+    {
         if (false === $metadataGroups) {
             return false;
         }