Completed
Pull Request — master (#539)
by Delf
03:23
created
src/JMS/Serializer/EventDispatcher/Events.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,5 +25,7 @@
 block discarded – undo
25 25
     const PRE_DESERIALIZE = 'serializer.pre_deserialize';
26 26
     const POST_DESERIALIZE = 'serializer.post_deserialize';
27 27
 
28
-    final private function __construct() { }
28
+    final private function __construct()
29
+    {
30
+}
29 31
 }
Please login to merge, or discard this patch.
src/JMS/Serializer/Metadata/Driver/AnnotationDriver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@
 block discarded – undo
221 221
     }
222 222
 
223 223
     /**
224
-     * @param array $groups
224
+     * @param string[] $groups
225 225
      * @param string $annotationSource
226 226
      */
227 227
     private function sanitizeGroupNames($groups, $annotationSource)
Please login to merge, or discard this patch.
src/JMS/Serializer/Exclusion/ExclusionGroupsExclusionStrategy.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,8 @@
 block discarded – undo
47 47
      * @param $metadataGroups
48 48
      * @return bool
49 49
      */
50
-    private function shouldSkipGroup($metadataGroups) {
50
+    private function shouldSkipGroup($metadataGroups)
51
+    {
51 52
         if (false === $metadataGroups) {
52 53
             return false;
53 54
         }
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlDeserializationVisitor.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -346,7 +346,6 @@
 block discarded – undo
346 346
     /**
347 347
      * Retrieves internalSubset even in bugfixed php versions
348 348
      *
349
-     * @param \DOMDocumentType $child
350 349
      * @param string $data
351 350
      * @return string
352 351
      */
Please login to merge, or discard this patch.
src/JMS/Serializer/XmlSerializationVisitor.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -44,6 +44,9 @@  discard block
 block discarded – undo
44 44
     private $nullWasVisited;
45 45
     private $objectMetadataStack;
46 46
 
47
+    /**
48
+     * @param Naming\PropertyNamingStrategyInterface $namingStrategy
49
+     */
47 50
     public function __construct($namingStrategy)
48 51
     {
49 52
         parent::__construct($namingStrategy);
@@ -126,6 +129,9 @@  discard block
 block discarded – undo
126 129
         return $doCData ? $this->document->createCDATASection($data) : $this->document->createTextNode((string) $data);
127 130
     }
128 131
 
132
+    /**
133
+     * @param string $data
134
+     */
129 135
     public function visitSimpleString($data, array $type, Context $context)
130 136
     {
131 137
         if (null === $this->document) {
@@ -437,6 +443,9 @@  discard block
 block discarded – undo
437 443
         }
438 444
     }
439 445
 
446
+    /**
447
+     * @return \DOMNode
448
+     */
440 449
     private function createElement($tagName, $namespace = null)
441 450
     {
442 451
         if (null !== $namespace) {
@@ -456,6 +465,9 @@  discard block
 block discarded – undo
456 465
         }
457 466
     }
458 467
 
468
+    /**
469
+     * @param string $value
470
+     */
459 471
     private function setAttributeOnNode(\DOMElement $node, $name, $value, $namespace = null)
460 472
     {
461 473
         if (null !== $namespace) {
Please login to merge, or discard this patch.
src/JMS/Serializer/Metadata/PropertyMetadata.php 1 patch
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -168,13 +168,13 @@
 block discarded – undo
168 168
             $parentStr
169 169
         ) = $unserialized;
170 170
 
171
-        if (isset($unserialized['xmlEntryNamespace'])){
171
+        if (isset($unserialized['xmlEntryNamespace'])) {
172 172
             $this->xmlEntryNamespace = $unserialized['xmlEntryNamespace'];
173 173
         }
174
-        if (isset($unserialized['xmlCollectionSkipWhenEmpty'])){
174
+        if (isset($unserialized['xmlCollectionSkipWhenEmpty'])) {
175 175
             $this->xmlCollectionSkipWhenEmpty = $unserialized['xmlCollectionSkipWhenEmpty'];
176 176
         }
177
-        if (isset($unserialized['exclusionGroups'])){
177
+        if (isset($unserialized['exclusionGroups'])) {
178 178
             $this->exclusionGroups = $unserialized['exclusionGroups'];
179 179
         }
180 180
 
Please login to merge, or discard this patch.