Inspection of "Merge branch 'feature/settings'" - sc0ttkclark/wordpress-fields-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e23be5...9cf38f )

by Scott Kingsley

created 2016-01-29 23:57 UTC

Status

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
 /**
  * The absolute server path to the fields API directory.
  */
-define( 'WP_FIELDS_API_DIR', plugin_dir_path( __FILE__ ) );
+define('WP_FIELDS_API_DIR', plugin_dir_path(__FILE__));
 
 /**
  * On `plugins_loaded`, create an instance of the Fields API manager class.
@@ -30,29 +30,29 @@  discard block
 block discarded – undo
 function _wp_fields_api_include() {
 
 	// Bail if we're already in WP core (depending on the name used)
-	if ( class_exists( 'WP_Fields_API' ) || class_exists( 'Fields_API' ) ) {
+	if (class_exists('WP_Fields_API') || class_exists('Fields_API')) {
 		return;
 	}
 
-	require_once( WP_FIELDS_API_DIR . 'implementation/wp-includes/fields-api/class-wp-fields-api.php' );
+	require_once(WP_FIELDS_API_DIR.'implementation/wp-includes/fields-api/class-wp-fields-api.php');
 
 	// Init Fields API class
 	$GLOBALS['wp_fields'] = WP_Fields_API::get_instance();
 
 }
 
-add_action( 'plugins_loaded', '_wp_fields_api_include', 8 );
+add_action('plugins_loaded', '_wp_fields_api_include', 8);
 
 /**
  * Implement Fields API Customizer instead of WP Core Customizer.
  */
 function _wp_fields_api_customize_include() {
 
-	if ( ! ( ( isset( $_REQUEST['wp_customize'] ) && 'on' == $_REQUEST['wp_customize'] ) || ( is_admin() && 'customize.php' == basename( $_SERVER['PHP_SELF'] ) ) ) ) {
+	if ( ! ((isset($_REQUEST['wp_customize']) && 'on' == $_REQUEST['wp_customize']) || (is_admin() && 'customize.php' == basename($_SERVER['PHP_SELF'])))) {
 		return;
 	}
 
-	require_once( WP_FIELDS_API_DIR . 'implementation/wp-includes/class-wp-customize-manager.php' );
+	require_once(WP_FIELDS_API_DIR.'implementation/wp-includes/class-wp-customize-manager.php');
 
 	// Init Customize class
 	$GLOBALS['wp_customize'] = new WP_Customize_Manager;
@@ -67,33 +67,33 @@  discard block
 block discarded – undo
  */
 function _wp_fields_api_implementations() {
 
-	$implementation_dir = WP_FIELDS_API_DIR . 'implementation/wp-includes/fields-api/forms/';
+	$implementation_dir = WP_FIELDS_API_DIR.'implementation/wp-includes/fields-api/forms/';
 
 	// User
-	require_once( $implementation_dir . 'class-wp-fields-api-form-user-edit.php' );
+	require_once($implementation_dir.'class-wp-fields-api-form-user-edit.php');
 
-	WP_Fields_API_Form_User_Edit::register( 'user', 'user-edit' );
+	WP_Fields_API_Form_User_Edit::register('user', 'user-edit');
 
 	// Term
-	require_once( $implementation_dir . 'class-wp-fields-api-form-term.php' );
-	require_once( $implementation_dir . 'class-wp-fields-api-form-term-add.php' );
+	require_once($implementation_dir.'class-wp-fields-api-form-term.php');
+	require_once($implementation_dir.'class-wp-fields-api-form-term-add.php');
 
-	WP_Fields_API_Form_Term::register( 'term', 'term-edit' );
-	WP_Fields_API_Form_Term_Add::register( 'term', 'term-add' );
+	WP_Fields_API_Form_Term::register('term', 'term-edit');
+	WP_Fields_API_Form_Term_Add::register('term', 'term-add');
 
 	// Settings
-	require_once( $implementation_dir . 'settings/class-wp-fields-api-form-settings-general.php' );
+	require_once($implementation_dir.'settings/class-wp-fields-api-form-settings-general.php');
 
-	WP_Fields_API_Form_Settings_General::register( 'settings', 'general' );
+	WP_Fields_API_Form_Settings_General::register('settings', 'general');
 
 	// Settings API compatibility
-	require_once( $implementation_dir . 'settings/class-wp-fields-api-settings-api.php' );
+	require_once($implementation_dir.'settings/class-wp-fields-api-settings-api.php');
 
 	// Run Settings API compatibility (has it's own hooks)
 	new WP_Fields_API_Settings_API;
 
 }
-add_action( 'fields_register', '_wp_fields_api_implementations', 5 );
+add_action('fields_register', '_wp_fields_api_implementations', 5);
 
 /**
  * Implement Fields API User edit to override WP Core.
@@ -102,20 +102,20 @@  discard block
 block discarded – undo
 
 	static $overridden;
 
-	if ( empty( $overridden ) ) {
+	if (empty($overridden)) {
 		$overridden = true;
 
 		// Load our overrides
 		//require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/includes/user.php' );
-		require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/user-edit.php' );
+		require_once(WP_FIELDS_API_DIR.'implementation/wp-admin/user-edit.php');
 
 		// Bail on original core file, don't run the rest
 		exit;
 	}
 
 }
-add_action( 'load-user-edit.php', '_wp_fields_api_user_edit_include' );
-add_action( 'load-profile.php', '_wp_fields_api_user_edit_include' );
+add_action('load-user-edit.php', '_wp_fields_api_user_edit_include');
+add_action('load-profile.php', '_wp_fields_api_user_edit_include');
 
 
 /**
@@ -125,18 +125,18 @@  discard block
 block discarded – undo
 
 	static $overridden;
 
-	if ( empty( $overridden ) ) {
+	if (empty($overridden)) {
 		$overridden = true;
 
 		// Load our overrides
-		require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/edit-tags.php' );
+		require_once(WP_FIELDS_API_DIR.'implementation/wp-admin/edit-tags.php');
 
 		// Bail on original core file, don't run the rest
 		exit;
 	}
 
 }
-add_action( 'load-edit-tags.php', '_wp_fields_api_term_include' );
+add_action('load-edit-tags.php', '_wp_fields_api_term_include');
 
 /**
  * Implement Fields API Term to override WP Core.
@@ -145,15 +145,15 @@  discard block
 block discarded – undo
 
 	static $overridden;
 
-	if ( empty( $overridden ) ) {
+	if (empty($overridden)) {
 		$overridden = true;
 
 		// Load our overrides
-		require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/settings-general.php' );
+		require_once(WP_FIELDS_API_DIR.'implementation/wp-admin/settings-general.php');
 
 		// Bail on original core file, don't run the rest
 		exit;
 	}
 
 }
-add_action( 'load-options-general.php', '_wp_fields_api_settings_general_include' );
\ No newline at end of file
+add_action('load-options-general.php', '_wp_fields_api_settings_general_include');
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -22,7 +22,7 @@ discard block
		block discarded – undo
22	22	/**
23	23	* The absolute server path to the fields API directory.
24	24	*/
25		-define( 'WP_FIELDS_API_DIR', plugin_dir_path( __FILE__ ) );
	25	+define('WP_FIELDS_API_DIR', plugin_dir_path(__FILE__));
26	26
27	27	/**
28	28	* On `plugins_loaded`, create an instance of the Fields API manager class.
		@@ -30,29 +30,29 @@ discard block
		block discarded – undo
30	30	function _wp_fields_api_include() {
31	31
32	32	// Bail if we're already in WP core (depending on the name used)
33		- if ( class_exists( 'WP_Fields_API' ) \|\| class_exists( 'Fields_API' ) ) {
	33	+ if (class_exists('WP_Fields_API') \|\| class_exists('Fields_API')) {
34	34	return;
35	35	}
36	36
37		- require_once( WP_FIELDS_API_DIR . 'implementation/wp-includes/fields-api/class-wp-fields-api.php' );
	37	+ require_once(WP_FIELDS_API_DIR.'implementation/wp-includes/fields-api/class-wp-fields-api.php');
38	38
39	39	// Init Fields API class
40	40	$GLOBALS['wp_fields'] = WP_Fields_API::get_instance();
41	41
42	42	}
43	43
44		-add_action( 'plugins_loaded', '_wp_fields_api_include', 8 );
	44	+add_action('plugins_loaded', '_wp_fields_api_include', 8);
45	45
46	46	/**
47	47	* Implement Fields API Customizer instead of WP Core Customizer.
48	48	*/
49	49	function _wp_fields_api_customize_include() {
50	50
51		- if ( ! ( ( isset( $_REQUEST['wp_customize'] ) && 'on' == $_REQUEST['wp_customize'] ) \|\| ( is_admin() && 'customize.php' == basename( $_SERVER['PHP_SELF'] ) ) ) ) {
	51	+ if ( ! ((isset($_REQUEST['wp_customize']) && 'on' == $_REQUEST['wp_customize']) \|\| (is_admin() && 'customize.php' == basename($_SERVER['PHP_SELF'])))) {
52	52	return;
53	53	}
54	54
55		- require_once( WP_FIELDS_API_DIR . 'implementation/wp-includes/class-wp-customize-manager.php' );
	55	+ require_once(WP_FIELDS_API_DIR.'implementation/wp-includes/class-wp-customize-manager.php');
56	56
57	57	// Init Customize class
58	58	$GLOBALS['wp_customize'] = new WP_Customize_Manager;
		@@ -67,33 +67,33 @@ discard block
		block discarded – undo
67	67	*/
68	68	function _wp_fields_api_implementations() {
69	69
70		- $implementation_dir = WP_FIELDS_API_DIR . 'implementation/wp-includes/fields-api/forms/';
	70	+ $implementation_dir = WP_FIELDS_API_DIR.'implementation/wp-includes/fields-api/forms/';
71	71
72	72	// User
73		- require_once( $implementation_dir . 'class-wp-fields-api-form-user-edit.php' );
	73	+ require_once($implementation_dir.'class-wp-fields-api-form-user-edit.php');
74	74
75		- WP_Fields_API_Form_User_Edit::register( 'user', 'user-edit' );
	75	+ WP_Fields_API_Form_User_Edit::register('user', 'user-edit');
76	76
77	77	// Term
78		- require_once( $implementation_dir . 'class-wp-fields-api-form-term.php' );
79		- require_once( $implementation_dir . 'class-wp-fields-api-form-term-add.php' );
	78	+ require_once($implementation_dir.'class-wp-fields-api-form-term.php');
	79	+ require_once($implementation_dir.'class-wp-fields-api-form-term-add.php');
80	80
81		- WP_Fields_API_Form_Term::register( 'term', 'term-edit' );
82		- WP_Fields_API_Form_Term_Add::register( 'term', 'term-add' );
	81	+ WP_Fields_API_Form_Term::register('term', 'term-edit');
	82	+ WP_Fields_API_Form_Term_Add::register('term', 'term-add');
83	83
84	84	// Settings
85		- require_once( $implementation_dir . 'settings/class-wp-fields-api-form-settings-general.php' );
	85	+ require_once($implementation_dir.'settings/class-wp-fields-api-form-settings-general.php');
86	86
87		- WP_Fields_API_Form_Settings_General::register( 'settings', 'general' );
	87	+ WP_Fields_API_Form_Settings_General::register('settings', 'general');
88	88
89	89	// Settings API compatibility
90		- require_once( $implementation_dir . 'settings/class-wp-fields-api-settings-api.php' );
	90	+ require_once($implementation_dir.'settings/class-wp-fields-api-settings-api.php');
91	91
92	92	// Run Settings API compatibility (has it's own hooks)
93	93	new WP_Fields_API_Settings_API;
94	94
95	95	}
96		-add_action( 'fields_register', '_wp_fields_api_implementations', 5 );
	96	+add_action('fields_register', '_wp_fields_api_implementations', 5);
97	97
98	98	/**
99	99	* Implement Fields API User edit to override WP Core.
		@@ -102,20 +102,20 @@ discard block
		block discarded – undo
102	102
103	103	static $overridden;
104	104
105		- if ( empty( $overridden ) ) {
	105	+ if (empty($overridden)) {
106	106	$overridden = true;
107	107
108	108	// Load our overrides
109	109	//require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/includes/user.php' );
110		- require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/user-edit.php' );
	110	+ require_once(WP_FIELDS_API_DIR.'implementation/wp-admin/user-edit.php');
111	111
112	112	// Bail on original core file, don't run the rest
113	113	exit;
114	114	}
115	115
116	116	}
117		-add_action( 'load-user-edit.php', '_wp_fields_api_user_edit_include' );
118		-add_action( 'load-profile.php', '_wp_fields_api_user_edit_include' );
	117	+add_action('load-user-edit.php', '_wp_fields_api_user_edit_include');
	118	+add_action('load-profile.php', '_wp_fields_api_user_edit_include');
119	119
120	120
121	121	/**
		@@ -125,18 +125,18 @@ discard block
		block discarded – undo
125	125
126	126	static $overridden;
127	127
128		- if ( empty( $overridden ) ) {
	128	+ if (empty($overridden)) {
129	129	$overridden = true;
130	130
131	131	// Load our overrides
132		- require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/edit-tags.php' );
	132	+ require_once(WP_FIELDS_API_DIR.'implementation/wp-admin/edit-tags.php');
133	133
134	134	// Bail on original core file, don't run the rest
135	135	exit;
136	136	}
137	137
138	138	}
139		-add_action( 'load-edit-tags.php', '_wp_fields_api_term_include' );
	139	+add_action('load-edit-tags.php', '_wp_fields_api_term_include');
140	140
141	141	/**
142	142	* Implement Fields API Term to override WP Core.
		@@ -145,15 +145,15 @@ discard block
		block discarded – undo
145	145
146	146	static $overridden;
147	147
148		- if ( empty( $overridden ) ) {
	148	+ if (empty($overridden)) {
149	149	$overridden = true;
150	150
151	151	// Load our overrides
152		- require_once( WP_FIELDS_API_DIR . 'implementation/wp-admin/settings-general.php' );
	152	+ require_once(WP_FIELDS_API_DIR.'implementation/wp-admin/settings-general.php');
153	153
154	154	// Bail on original core file, don't run the rest
155	155	exit;
156	156	}
157	157
158	158	}
159		-add_action( 'load-options-general.php', '_wp_fields_api_settings_general_include' );
160	159	\ No newline at end of file
	160	+add_action('load-options-general.php', '_wp_fields_api_settings_general_include');
161	161	\ No newline at end of file

sc0ttkclark / wordpress-fields-api

Push — master ( e23be5...9cf38f )

Status

Category

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch