Inspection of "Avoid large inline arrays inside of method calls" - sc0ttkclark/wordpress-fields-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 37379c...0ba9bb )

by Scott Kingsley

created 2016-01-27 23:26 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@  discard block
 block discarded – undo
  *
  * @param WP_Fields_API $wp_fields
  */
-function example_my_term_starter( $wp_fields ) {
+function example_my_term_starter($wp_fields) {
 
 	// Object type: Term
 	$object_type = 'term';
@@ -21,11 +21,11 @@  discard block
 block discarded – undo
 
 	$section_id = ''; // @todo Fill in section ID
 	$section_args = array(
-		'title'  => __( '', 'my-text-domain' ), // @todo Fill in section heading, update text domain
+		'title'  => __('', 'my-text-domain'), // @todo Fill in section heading, update text domain
 		'screen' => $screen_id,
 	);
 
-	$wp_fields->add_section( $object_type, $section_id, $object_name, $section_args );
+	$wp_fields->add_section($object_type, $section_id, $object_name, $section_args);
 
 	// My Field
 	$field_id = '';
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'text', // @todo Change control type if needed
 			'section'     => $section_id,
-			'label'       => __( '', 'my-text-domain' ), // @todo Fill in label, update text domain
-			'description' => __( '', 'my-text-domain' ), // @todo Fill in description, update text domain
+			'label'       => __('', 'my-text-domain'), // @todo Fill in label, update text domain
+			'description' => __('', 'my-text-domain'), // @todo Fill in description, update text domain
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 
 }
-add_action( 'fields_register', 'example_my_term_starter' );
\ No newline at end of file
+add_action('fields_register', 'example_my_term_starter');
\ No newline at end of file

Please login to merge, or discard this patch.

docs/examples/user/_starter.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@  discard block
 block discarded – undo
  *
  * @param WP_Fields_API $wp_fields
  */
-function example_my_user_starter( $wp_fields ) {
+function example_my_user_starter($wp_fields) {
 
 	// Object type: User
 	$object_type = 'user';
@@ -21,11 +21,11 @@  discard block
 block discarded – undo
 
 	$section_id = ''; // @todo Fill in section ID
 	$section_args = array(
-		'title'  => __( '', 'my-text-domain' ), // @todo Fill in section heading, update text domain
+		'title'  => __('', 'my-text-domain'), // @todo Fill in section heading, update text domain
 		'screen' => $screen_id,
 	);
 
-	$wp_fields->add_section( $object_type, $section_id, $object_name, $section_args );
+	$wp_fields->add_section($object_type, $section_id, $object_name, $section_args);
 
 	// My Field
 	$field_id = '';
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'text', // @todo Change control type if needed
 			'section'     => $section_id,
-			'label'       => __( '', 'my-text-domain' ), // @todo Fill in label, update text domain
-			'description' => __( '', 'my-text-domain' ), // @todo Fill in description, update text domain
+			'label'       => __('', 'my-text-domain'), // @todo Fill in label, update text domain
+			'description' => __('', 'my-text-domain'), // @todo Fill in description, update text domain
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 
 }
-add_action( 'fields_register', 'example_my_user_starter' );
\ No newline at end of file
+add_action('fields_register', 'example_my_user_starter');
\ No newline at end of file

Please login to merge, or discard this patch.

docs/examples/user/address.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@  discard block
 block discarded – undo
  *
  * @param WP_Fields_API $wp_fields
  */
-function example_my_user_address( $wp_fields ) {
+function example_my_user_address($wp_fields) {
 
 	// Object type: User
 	$object_type = 'user';
@@ -21,11 +21,11 @@  discard block
 block discarded – undo
 
 	$section_id = 'address';
 	$section_args = array(
-		'title'  => __( 'Address', 'my-text-domain' ), // @todo Update text domain
+		'title'  => __('Address', 'my-text-domain'), // @todo Update text domain
 		'screen' => $screen_id,
 	);
 
-	$wp_fields->add_section( $object_type, $section_id, $object_name, $section_args );
+	$wp_fields->add_section($object_type, $section_id, $object_name, $section_args);
 
 	// Address Line 1
 	$field_id = 'address_1';
@@ -33,11 +33,11 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'text',
 			'section'     => $section_id,
-			'label'       => __( 'Address 1', 'my-text-domain' ), // @todo Update text domain
+			'label'       => __('Address 1', 'my-text-domain'), // @todo Update text domain
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 	// Address Line 2
 	$field_id = 'address_2';
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'text',
 			'section'     => $section_id,
-			'label'       => __( 'Address 2', 'my-text-domain' ), // @todo Update text domain
+			'label'       => __('Address 2', 'my-text-domain'), // @todo Update text domain
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 	// City
 	$field_id = 'address_city';
@@ -57,11 +57,11 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'text',
 			'section'     => $section_id,
-			'label'       => __( 'City', 'my-text-domain' ), // @todo Update text domain
+			'label'       => __('City', 'my-text-domain'), // @todo Update text domain
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 	// State / Region
 	$field_id = 'address_state';
@@ -69,13 +69,13 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'text',
 			'section'     => $section_id,
-			'label'       => __( 'State / Region', 'my-text-domain' ), // @todo Update text domain
+			'label'       => __('State / Region', 'my-text-domain'), // @todo Update text domain
 		    // You could use 'select' type instead and then
 			// pass in all states in 'choices' option with array( 'TX' => 'Texas' )
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 	// Zip / Postal Code
 	$field_id = 'address_zip';
@@ -83,11 +83,11 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'text',
 			'section'     => $section_id,
-			'label'       => __( 'Zip / Postal Code', 'my-text-domain' ), // @todo Update text domain
+			'label'       => __('Zip / Postal Code', 'my-text-domain'), // @todo Update text domain
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 	// Zip / Postal Code
 	$field_id = 'address_country';
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
 		'control' => array(
 			'type'        => 'select',
 			'section'     => $section_id,
-			'label'       => __( 'Country', 'my-text-domain' ), // @todo Update text domain
+			'label'       => __('Country', 'my-text-domain'), // @todo Update text domain
 		    'choices' => array(
 			    'US' => 'United States',
 			    'CA' => 'Canada',
@@ -104,8 +104,8 @@  discard block
 block discarded – undo
 		),
 	);
 
-	$wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
+	$wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
 
 
 }
-add_action( 'fields_register', 'example_my_user_address' );
\ No newline at end of file
+add_action('fields_register', 'example_my_user_address');
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -4,7 +4,7 @@ discard block
		block discarded – undo
4	4	*
5	5	* @param WP_Fields_API $wp_fields
6	6	*/
7		-function example_my_user_address( $wp_fields ) {
	7	+function example_my_user_address($wp_fields) {
8	8
9	9	// Object type: User
10	10	$object_type = 'user';
		@@ -21,11 +21,11 @@ discard block
		block discarded – undo
21	21
22	22	$section_id = 'address';
23	23	$section_args = array(
24		- 'title' => __( 'Address', 'my-text-domain' ), // @todo Update text domain
	24	+ 'title' => __('Address', 'my-text-domain'), // @todo Update text domain
25	25	'screen' => $screen_id,
26	26	);
27	27
28		- $wp_fields->add_section( $object_type, $section_id, $object_name, $section_args );
	28	+ $wp_fields->add_section($object_type, $section_id, $object_name, $section_args);
29	29
30	30	// Address Line 1
31	31	$field_id = 'address_1';
		@@ -33,11 +33,11 @@ discard block
		block discarded – undo
33	33	'control' => array(
34	34	'type' => 'text',
35	35	'section' => $section_id,
36		- 'label' => __( 'Address 1', 'my-text-domain' ), // @todo Update text domain
	36	+ 'label' => __('Address 1', 'my-text-domain'), // @todo Update text domain
37	37	),
38	38	);
39	39
40		- $wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
	40	+ $wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
41	41
42	42	// Address Line 2
43	43	$field_id = 'address_2';
		@@ -45,11 +45,11 @@ discard block
		block discarded – undo
45	45	'control' => array(
46	46	'type' => 'text',
47	47	'section' => $section_id,
48		- 'label' => __( 'Address 2', 'my-text-domain' ), // @todo Update text domain
	48	+ 'label' => __('Address 2', 'my-text-domain'), // @todo Update text domain
49	49	),
50	50	);
51	51
52		- $wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
	52	+ $wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
53	53
54	54	// City
55	55	$field_id = 'address_city';
		@@ -57,11 +57,11 @@ discard block
		block discarded – undo
57	57	'control' => array(
58	58	'type' => 'text',
59	59	'section' => $section_id,
60		- 'label' => __( 'City', 'my-text-domain' ), // @todo Update text domain
	60	+ 'label' => __('City', 'my-text-domain'), // @todo Update text domain
61	61	),
62	62	);
63	63
64		- $wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
	64	+ $wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
65	65
66	66	// State / Region
67	67	$field_id = 'address_state';
		@@ -69,13 +69,13 @@ discard block
		block discarded – undo
69	69	'control' => array(
70	70	'type' => 'text',
71	71	'section' => $section_id,
72		- 'label' => __( 'State / Region', 'my-text-domain' ), // @todo Update text domain
	72	+ 'label' => __('State / Region', 'my-text-domain'), // @todo Update text domain
73	73	// You could use 'select' type instead and then
74	74	// pass in all states in 'choices' option with array( 'TX' => 'Texas' )
75	75	),
76	76	);
77	77
78		- $wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
	78	+ $wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
79	79
80	80	// Zip / Postal Code
81	81	$field_id = 'address_zip';
		@@ -83,11 +83,11 @@ discard block
		block discarded – undo
83	83	'control' => array(
84	84	'type' => 'text',
85	85	'section' => $section_id,
86		- 'label' => __( 'Zip / Postal Code', 'my-text-domain' ), // @todo Update text domain
	86	+ 'label' => __('Zip / Postal Code', 'my-text-domain'), // @todo Update text domain
87	87	),
88	88	);
89	89
90		- $wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
	90	+ $wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
91	91
92	92	// Zip / Postal Code
93	93	$field_id = 'address_country';
		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	'control' => array(
96	96	'type' => 'select',
97	97	'section' => $section_id,
98		- 'label' => __( 'Country', 'my-text-domain' ), // @todo Update text domain
	98	+ 'label' => __('Country', 'my-text-domain'), // @todo Update text domain
99	99	'choices' => array(
100	100	'US' => 'United States',
101	101	'CA' => 'Canada',
		@@ -104,8 +104,8 @@ discard block
		block discarded – undo
104	104	),
105	105	);
106	106
107		- $wp_fields->add_field( $object_type, $field_id, $object_name, $field_args );
	107	+ $wp_fields->add_field($object_type, $field_id, $object_name, $field_args);
108	108
109	109
110	110	}
111		-add_action( 'fields_register', 'example_my_user_address' );
112	111	\ No newline at end of file
	112	+add_action('fields_register', 'example_my_user_address');
113	113	\ No newline at end of file

sc0ttkclark / wordpress-fields-api

Push — master ( 37379c...0ba9bb )

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch