Updater::queueDelete() - Code Metrics - Inspection of "In progress" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop-3.0 ( 4fe777...24fc5d )

by Mohamed

created 2016-09-23 07:52 UTC

Updater::queueDelete() A

↳ Parent: Updater

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	3

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Repository\Message\Queue;

use Illuminate\Database\Eloquent\Model;
use Tinyissue\Contracts\Model\UserInterface;
use Tinyissue\Model\Message;
use Tinyissue\Model\Project\Issue;
use Tinyissue\Model\User;
use Tinyissue\Repository\RepositoryUpdater;

class Updater extends RepositoryUpdater
{
    /**
     * Insert a record into the message queue.
     *
     * @param string   $name
     * @param Model    $model
     * @param int|User $changeBy
     *
     * @return void
     */
    public function queue($name, Model $model, $changeBy)

    {
        // Get modified attributes
        $dirty = $model->getDirty();
        $isNew = strpos($name, 'add_') === 0;

        // Stop if nothing changed
        if (!$model->isDirty() && !$isNew) {
            return;
        }

        // Get the original value of the modified attributes
        $origin = [];
        foreach ($dirty as $field => $value) {
            $origin[$field] = $model->getOriginal($field, $value);
        }

        // Fill and save to message queue
        $fill = $this->getFillAttributes($name, $model, $changeBy, [
            'dirty'  => $dirty,
            'origin' => $origin,
        ]);

        return $this->model->fill($fill)->save();
    }

    /**
     * Insert a record into the message queue about a delete event.
     *
     * @param string   $name
     * @param Model    $model
     * @param int|User $changeBy
     *
     * @return void
     */
    public function queueDelete($name, Model $model, $changeBy)

    {
        // Fill and save to message queue
        $fill = $this->getFillAttributes($name, $model, $changeBy, [
            'dirty'  => [],
            'origin' => $model->toArray(),
        ]);

        return $this->model->fill($fill)->save();
    }

    /**
     * Insert records about tag changes into the message queue.
     *
     * @param Issue         $issue
     * @param array         $added
     * @param array         $removed
     * @param UserInterface $changeBy
     *
     * @return mixed
     */
    public function queueIssueTagChanges(Issue $issue, array $added, array $removed, UserInterface $changeBy)
    {
        // Fill and save to message queue
        $fill = $this->getFillAttributes(Message\Queue::CHANGE_TAG_ISSUE, $issue, $changeBy, [
            'added'   => $added,
            'removed' => $removed,
        ]);

        return $this->model->fill($fill)->save();
    }

    /**
     * Returns an array containing the data needed for the message queue save.
     *
     * @param string            $name
     * @param Model             $model
     * @param int|UserInterface $changeBy
     * @param array             $payload
     *
     * @return array
     */
    protected function getFillAttributes($name, Model $model, $changeBy, array $payload)

    {
        $changeById = (int)($changeBy instanceof UserInterface ? $changeBy->id : $changeBy);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $fill = [];
        $fill['event'] = $name;
        $fill['payload'] = $payload;
        $fill['model_type'] = get_class($model);
        $fill['model_id'] = $model->id;
        $fill['change_by_id'] = $changeById;

        return $fill;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Repository\Message\Queue;
13
14		use Illuminate\Database\Eloquent\Model;
15		use Tinyissue\Contracts\Model\UserInterface;
16		use Tinyissue\Model\Message;
17		use Tinyissue\Model\Project\Issue;
18		use Tinyissue\Model\User;
19		use Tinyissue\Repository\RepositoryUpdater;
20
21		class Updater extends RepositoryUpdater
22		{
23		/**
24		* Insert a record into the message queue.
25		*
26		* @param string $name
27		* @param Model $model
28		* @param int\|User $changeBy
29		*
30		* @return void
31		*/
32	View Code Duplication	public function queue($name, Model $model, $changeBy)
		0 ignored issues – show Duplication introduced 2016-09-11 11:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		// Get modified attributes
35		$dirty = $model->getDirty();
36		$isNew = strpos($name, 'add_') === 0;
37
38		// Stop if nothing changed
39		if (!$model->isDirty() && !$isNew) {
40		return;
41		}
42
43		// Get the original value of the modified attributes
44		$origin = [];
45		foreach ($dirty as $field => $value) {
46		$origin[$field] = $model->getOriginal($field, $value);
47		}
48
49		// Fill and save to message queue
50		$fill = $this->getFillAttributes($name, $model, $changeBy, [
51		'dirty' => $dirty,
52		'origin' => $origin,
53		]);
54
55		return $this->model->fill($fill)->save();
56		}
57
58		/**
59		* Insert a record into the message queue about a delete event.
60		*
61		* @param string $name
62		* @param Model $model
63		* @param int\|User $changeBy
64		*
65		* @return void
66		*/
67	View Code Duplication	public function queueDelete($name, Model $model, $changeBy)
		0 ignored issues – show Duplication introduced 2016-09-11 11:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		// Fill and save to message queue
70		$fill = $this->getFillAttributes($name, $model, $changeBy, [
71		'dirty' => [],
72		'origin' => $model->toArray(),
73		]);
74
75		return $this->model->fill($fill)->save();
76		}
77
78		/**
79		* Insert records about tag changes into the message queue.
80		*
81		* @param Issue $issue
82		* @param array $added
83		* @param array $removed
84		* @param UserInterface $changeBy
85		*
86		* @return mixed
87		*/
88		public function queueIssueTagChanges(Issue $issue, array $added, array $removed, UserInterface $changeBy)
89		{
90		// Fill and save to message queue
91		$fill = $this->getFillAttributes(Message\Queue::CHANGE_TAG_ISSUE, $issue, $changeBy, [
92		'added' => $added,
93		'removed' => $removed,
94		]);
95
96		return $this->model->fill($fill)->save();
97		}
98
99		/**
100		* Returns an array containing the data needed for the message queue save.
101		*
102		* @param string $name
103		* @param Model $model
104		* @param int\|UserInterface $changeBy
105		* @param array $payload
106		*
107		* @return array
108		*/
109	View Code Duplication	protected function getFillAttributes($name, Model $model, $changeBy, array $payload)
		0 ignored issues – show Duplication introduced 2016-09-11 11:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111		$changeById = (int)($changeBy instanceof UserInterface ? $changeBy->id : $changeBy);
		0 ignored issues – show Bug introduced 2016-09-11 11:05 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Tinyissue\Contracts\Model\UserInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
112
113		$fill = [];
114		$fill['event'] = $name;
115		$fill['payload'] = $payload;
116		$fill['model_type'] = get_class($model);
117		$fill['model_id'] = $model->id;
118		$fill['change_by_id'] = $changeById;
119
120		return $fill;
121		}
122		}
123

satrun77 / tinyissue

Push — develop-3.0 ( 4fe777...24fc5d )

Updater::queueDelete() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like