Tinyissue\Repository\Message\Queue\Updater

Complexity

Total Complexity

8

Size/Duplication

Total Lines	102
Duplicated Lines	47.06 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	queue()	25	25	4
A	queueDelete()	10	10	1
A	queueIssueTagChanges()	0	10	1
A	getFillAttributes()	13	13	2

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Repository\Message\Queue;

use Illuminate\Database\Eloquent\Model;
use Tinyissue\Contracts\Model\UserInterface;
use Tinyissue\Model\Message;
use Tinyissue\Model\Project\Issue;
use Tinyissue\Model\User;
use Tinyissue\Repository\RepositoryUpdater;

class Updater extends RepositoryUpdater
{
    /**
     * Insert a record into the message queue.
     *
     * @param string   $name
     * @param Model    $model
     * @param int|User $changeBy
     *
     * @return void
     */
    public function queue($name, Model $model, $changeBy)

This method seems to be duplicated in your project.

    {
        // Get modified attributes
        $dirty = $model->getDirty();
        $isNew = strpos($name, 'add_') === 0;

        // Stop if nothing changed
        if (!$model->isDirty() && !$isNew) {
            return;
        }

        // Get the original value of the modified attributes
        $origin = [];
        foreach ($dirty as $field => $value) {
            $origin[$field] = $model->getOriginal($field, $value);
        }

        // Fill and save to message queue
        $fill = $this->getFillAttributes($name, $model, $changeBy, [
            'dirty'  => $dirty,
            'origin' => $origin,
        ]);

        return $this->model->fill($fill)->save();
    }

    /**
     * Insert a record into the message queue about a delete event.
     *
     * @param string   $name
     * @param Model    $model
     * @param int|User $changeBy
     *
     * @return void
     */
    public function queueDelete($name, Model $model, $changeBy)

This method seems to be duplicated in your project.

    {
        // Fill and save to message queue
        $fill = $this->getFillAttributes($name, $model, $changeBy, [
            'dirty'  => [],
            'origin' => $model->toArray(),
        ]);

        return $this->model->fill($fill)->save();
    }

    /**
     * Insert records about tag changes into the message queue.
     *
     * @param Issue         $issue
     * @param array         $added
     * @param array         $removed
     * @param UserInterface $changeBy
     *
     * @return mixed
     */
    public function queueIssueTagChanges(Issue $issue, array $added, array $removed, UserInterface $changeBy)
    {
        // Fill and save to message queue
        $fill = $this->getFillAttributes(Message\Queue::CHANGE_TAG_ISSUE, $issue, $changeBy, [
            'added'   => $added,
            'removed' => $removed,
        ]);

        return $this->model->fill($fill)->save();
    }

    /**
     * Returns an array containing the data needed for the message queue save.
     *
     * @param string            $name
     * @param Model             $model
     * @param int|UserInterface $changeBy
     * @param array             $payload
     *
     * @return array
     */
    protected function getFillAttributes($name, Model $model, $changeBy, array $payload)

This method seems to be duplicated in your project.

    {
        $changeById = (int)($changeBy instanceof UserInterface ? $changeBy->id : $changeBy);

Accessing id on the interface Tinyissue\Contracts\Model\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $fill = [];
        $fill['event'] = $name;
        $fill['payload'] = $payload;
        $fill['model_type'] = get_class($model);
        $fill['model_id'] = $model->id;
        $fill['change_by_id'] = $changeById;

        return $fill;
    }
}