Passed
Push — master ( de1c6e...8badc5 )
by Stanislav
14:22 queued 11:27
created
core/album/display.php 1 patch
Braces   +15 added lines, -25 removed lines patch added patch discarded remove patch
@@ -226,8 +226,7 @@  discard block
 block discarded – undo
226 226
 					SET album_parents = '" . $this->db->sql_escape($album_data['album_parents']) . "'
227 227
 					WHERE parent_id = " . (int) $album_data['parent_id'];
228 228
 				$this->db->sql_query($sql);
229
-			}
230
-			else
229
+			} else
231 230
 			{
232 231
 				$album_parents = @unserialize($album_data['album_parents']);
233 232
 			}
@@ -296,16 +295,14 @@  discard block
 block discarded – undo
296 295
 			if (!empty($row['user_id']))
297 296
 			{
298 297
 				$album_moderators[$a_id][] = get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']);
299
-			}
300
-			else
298
+			} else
301 299
 			{
302 300
 				$group_name = (($row['group_type'] == GROUP_SPECIAL) ? $this->language->lang('G_' . $row['group_name']) : $row['group_name']);
303 301
 
304 302
 				if ($this->user->data['user_id'] != ANONYMOUS && !$this->auth->acl_get('u_viewprofile'))
305 303
 				{
306 304
 					$album_moderators[$a_id][] = '<span' . (($row['group_colour']) ? ' style="color:#' . $row['group_colour'] . ';"' : '') . '>' . $group_name . '</span>';
307
-				}
308
-				else
305
+				} else
309 306
 				{
310 307
 					$album_moderators[$a_id][] = '<a' . (($row['group_colour']) ? ' style="color:#' . $row['group_colour'] . ';"' : '') . ' href="' . append_sid($this->root_path . 'memberlist.' . $this->php_ext, 'mode=group&amp;g=' . $row['group_id']) . '">' . $group_name . '</a>';
311 308
 				}
@@ -349,8 +346,7 @@  discard block
 block discarded – undo
349 346
 			}
350 347
 			$root_data = array('album_id' => (int) \phpbbgallery\core\block::PUBLIC_ALBUM);
351 348
 			$sql_where = 'a.album_user_id = ' . (int) \phpbbgallery\core\block::PUBLIC_ALBUM;
352
-		}
353
-		else if ($root_data == 'personal')
349
+		} else if ($root_data == 'personal')
354 350
 		{
355 351
 			if ($mark_read == 'albums')
356 352
 			{
@@ -368,8 +364,7 @@  discard block
 block discarded – undo
368 364
 				{
369 365
 					$sql_where .= ' AND u.username_clean NOT ' . $this->db->sql_like_expression(chr($i) . $this->db->any_char);
370 366
 				}
371
-			}
372
-			else if ($first_char)
367
+			} else if ($first_char)
373 368
 			{
374 369
 				$sql_where .= ' AND u.username_clean ' . $this->db->sql_like_expression(substr($first_char, 0, 1) . $this->db->any_char);
375 370
 			}
@@ -413,8 +408,7 @@  discard block
 block discarded – undo
413 408
 					'phpbbgallery_core_search_recent_page',),
414 409
 					'params' => array()), 'pagination', 'page', $num_pegas, $limit, $start
415 410
 			);*/
416
-		}
417
-		else
411
+		} else
418 412
 		{
419 413
 			$sql_where = 'a.left_id > ' . $root_data['left_id'] . ' AND a.left_id < ' . $root_data['right_id'] . ' AND a.album_user_id = ' . $root_data['album_user_id'];
420 414
 		}
@@ -502,10 +496,12 @@  discard block
 block discarded – undo
502 496
 				continue;
503 497
 			}
504 498
 
505
-			if (false)//@todo !$this->gallery_auth->acl_check('a_list', $album_id, $row['album_user_id']))
499
+			if (false) {
500
+				//@todo !$this->gallery_auth->acl_check('a_list', $album_id, $row['album_user_id']))
506 501
 			{
507 502
 				// if the user does not have permissions to list this album, skip everything until next branch
508 503
 				$right_id = $row['right_id'];
504
+			}
509 505
 				continue;
510 506
 			}
511 507
 
@@ -530,8 +526,7 @@  discard block
 block discarded – undo
530 526
 				$album_rows[$parent_id]['album_type_last_image'] = $row['album_type'];
531 527
 				$album_rows[$parent_id]['album_contest_marked'] = $row['contest_marked'];
532 528
 				$album_rows[$parent_id]['orig_album_last_image_time'] = $row['album_last_image_time'];
533
-			}
534
-			else if ($row['album_type'])
529
+			} else if ($row['album_type'])
535 530
 			{
536 531
 				$subalbums[$parent_id][$album_id]['display'] = ($row['display_on_index']) ? true : false;
537 532
 				$subalbums[$parent_id][$album_id]['name'] = $row['album_name'];
@@ -573,16 +568,14 @@  discard block
 block discarded – undo
573 568
 				{
574 569
 					$this->misc->markread('all');
575 570
 					$message = $this->language->lang('RETURN_INDEX', '<a href="' . $redirect . '">', '</a>');
576
-				}
577
-				else
571
+				} else
578 572
 				{
579 573
 					$this->misc->markread('albums', $album_ids);
580 574
 					$message = $this->language->lang('RETURN_ALBUM', '<a href="' . $redirect . '">', '</a>');
581 575
 				}
582 576
 				meta_refresh(3, $redirect);
583 577
 				trigger_error($this->language->lang('ALBUMS_MARKED') . '<br /><br />' . $message);
584
-			}
585
-			else
578
+			} else
586 579
 			{
587 580
 				$message = $this->language->lang('RETURN_PAGE', '<a href="' . $redirect . '">', '</a>');
588 581
 				meta_refresh(3, $redirect);
@@ -660,8 +653,7 @@  discard block
 block discarded – undo
660 653
 							'name'		=> $subalbum_row['name'],
661 654
 							'unread'	=> $subalbum_unread,
662 655
 						);
663
-					}
664
-					else
656
+					} else
665 657
 					{
666 658
 						unset($subalbums[$album_id][$subalbum_id]);
667 659
 					}
@@ -674,8 +666,7 @@  discard block
 block discarded – undo
674 666
 
675 667
 				$l_subalbums = (sizeof($subalbums[$album_id]) == 1) ? $this->language->lang('SUBALBUM') : $this->language->lang('SUBALBUMS');
676 668
 				$folder_image = ($album_unread) ? 'forum_unread_subforum' : 'forum_read_subforum';
677
-			}
678
-			else
669
+			} else
679 670
 			{
680 671
 				$folder_alt = ($album_unread) ? 'NEW_IMAGES' : 'NO_NEW_IMAGES';
681 672
 				$folder_image = ($album_unread) ? 'forum_unread' : 'forum_read';
@@ -701,8 +692,7 @@  discard block
 block discarded – undo
701 692
 				$lastimage_uc_name = '';//@todo phpbb_ext_gallery_core_image::generate_link('image_name', $phpbb_ext_gallery->config->get('link_image_name'), $lastimage_image_id, $lastimage_name, $lastimage_album_id);
702 693
 				// phpbb_ext_gallery_core_image::generate_link('lastimage_icon', $phpbb_ext_gallery->config->get('link_image_icon'), $lastimage_image_id, $lastimage_name, $lastimage_album_id);
703 694
 				$lastimage_uc_icon = '';//@todo phpbb_ext_gallery_core_image::generate_link('lastimage_icon', $phpbb_ext_gallery->config->get('link_image_icon'), $lastimage_image_id, $lastimage_name, $lastimage_album_id);
704
-			}
705
-			else
695
+			} else
706 696
 			{
707 697
 				$lastimage_time = $lastimage_album_type = $lastimage_contest_marked = 0;
708 698
 				$lastimage_uc_fake_thumbnail = $lastimage_uc_fake_thumbnail_url = $lastimage_uc_thumbnail = $lastimage_uc_name = $lastimage_uc_icon = '';
Please login to merge, or discard this patch.
exif/exif.php 1 patch
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -110,8 +110,7 @@  discard block
 block discarded – undo
110 110
 		if ($this->status == self::DBSAVED)
111 111
 		{
112 112
 			$this->data = @unserialize($data);
113
-		}
114
-		else if (($this->status == self::AVAILABLE) || ($this->status == self::UNKNOWN))
113
+		} else if (($this->status == self::AVAILABLE) || ($this->status == self::UNKNOWN))
115 114
 		{
116 115
 			$this->read();
117 116
 		}
@@ -137,8 +136,7 @@  discard block
 block discarded – undo
137 136
 				if (!in_array($key, self::$allowed_groups))
138 137
 				{
139 138
 					unset($this->data[$key]);
140
-				}
141
-				else
139
+				} else
142 140
 				{
143 141
 					foreach ($this->data[$key] as $subkey => $array)
144 142
 					{
@@ -152,8 +150,7 @@  discard block
 block discarded – undo
152 150
 
153 151
 			$this->serialized = serialize($this->data);
154 152
 			$this->status = self::DBSAVED;
155
-		}
156
-		else
153
+		} else
157 154
 		{
158 155
 			$this->status = self::UNAVAILABLE;
159 156
 		}
@@ -203,8 +200,7 @@  discard block
 block discarded – undo
203 200
 			if (($num > $den) && $den)
204 201
 			{
205 202
 				$exif_exposure = $num / $den;
206
-			}
207
-			else if ($num)
203
+			} else if ($num)
208 204
 			{
209 205
 				$exif_exposure = ' 1/' . $den / $num ;
210 206
 			}
@@ -255,8 +251,7 @@  discard block
 block discarded – undo
255 251
 				if (($num / $den) == 0)
256 252
 				{
257 253
 					$exif_exposure_bias = 0;
258
-				}
259
-				else
254
+				} else
260 255
 				{
261 256
 					$exif_exposure_bias = $this->data["EXIF"]["ExposureBiasValue"];
262 257
 				}
Please login to merge, or discard this patch.