Passed
Pull Request — master (#326)
by
unknown
04:30
created
exif/event/exif_listener.php 3 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -36,16 +36,16 @@
 block discarded – undo
36 36
 	}
37 37
 
38 38
 	/**
39
-	* Constructor
40
-	* NOTE: The parameters of this method must match in order and type with
41
-	* the dependencies defined in the services.yml file for this service.
42
-	*
43
-	* @param \phpbb\user					$user			User object
44
-	* @param \phpbbgallery\core\config		$gallery_config	Core gallery config object
45
-	* @param \phpbbgallery\core\auth\auth	$gallery_auth	Core gallery auth object
46
-	* @param \phpbbgallery\core\url			$gallery_url	Core gallery url object
47
-	* @param \phpbbgallery\core\user		$gallery_user	Core gallery user wraper
48
-	*/
39
+	 * Constructor
40
+	 * NOTE: The parameters of this method must match in order and type with
41
+	 * the dependencies defined in the services.yml file for this service.
42
+	 *
43
+	 * @param \phpbb\user					$user			User object
44
+	 * @param \phpbbgallery\core\config		$gallery_config	Core gallery config object
45
+	 * @param \phpbbgallery\core\auth\auth	$gallery_auth	Core gallery auth object
46
+	 * @param \phpbbgallery\core\url			$gallery_url	Core gallery url object
47
+	 * @param \phpbbgallery\core\user		$gallery_user	Core gallery user wraper
48
+	 */
49 49
 
50 50
 	public function __construct(\phpbb\user $user, \phpbbgallery\core\config $gallery_config, \phpbbgallery\core\auth\auth $gallery_auth, \phpbbgallery\core\url $gallery_url, \phpbbgallery\core\user $gallery_user)
51 51
 	{
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		$this->user = $user;
53 53
 		$this->gallery_config = $gallery_config;
54 54
 		$this->gallery_auth = $gallery_auth;
55
-		$this->gallery_url	= $gallery_url;
55
+		$this->gallery_url = $gallery_url;
56 56
 		$this->gallery_user = $gallery_user;
57 57
 	}
58 58
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 			{
66 66
 				$this->user->add_lang_ext('phpbbgallery/exif', 'exif');
67 67
 
68
-				$return_ary['vars']['IMAGE_SETTINGS']['disp_exifdata'] = array('lang' => 'DISP_EXIF_DATA',		'validate' => 'bool',	'type' => 'radio:yes_no');
68
+				$return_ary['vars']['IMAGE_SETTINGS']['disp_exifdata'] = array('lang' => 'DISP_EXIF_DATA', 'validate' => 'bool', 'type' => 'radio:yes_no');
69 69
 				$event['return_ary'] = $return_ary;
70 70
 			}
71 71
 		}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -146,8 +146,7 @@
 block discarded – undo
146 146
 
147 147
 			$event['additional_sql_data'] = $additional_sql_data;
148 148
 			unset($exif);
149
-		}
150
-		else
149
+		} else
151 150
 		{
152 151
 			$additional_sql_data = $event['additional_sql_data'];
153 152
 			$additional_sql_data['image_exif_data'] = '';
Please login to merge, or discard this patch.
exif/language/en/exif.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 	'EXIF_CAM_MODEL'			=> 'Camera-model',
31 31
 	'EXIF_DATE'					=> 'Image taken on',
32 32
 	'EXIF_EXPOSURE'				=> 'Shutter speed',
33
-	'EXIF_EXPOSURE_EXP'			=> '%s Sec',// 'EXIF_EXPOSURE' unit
33
+	'EXIF_EXPOSURE_EXP'			=> '%s Sec', // 'EXIF_EXPOSURE' unit
34 34
 	'EXIF_EXPOSURE_BIAS'		=> 'Exposure bias',
35
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
35
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
36 36
 	'EXIF_EXPOSURE_PROG'		=> 'Exposure program',
37 37
 	'EXIF_EXPOSURE_PROG_0'		=> 'Not defined',
38 38
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manual',
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	'EXIF_FLASH_CASE_93'		=> 'Flash fired, auto mode, return light not detected, red-eye reduction mode',
73 73
 	'EXIF_FLASH_CASE_95'		=> 'Flash fired, auto mode, return light detected, red-eye reduction mode',
74 74
 	'EXIF_FOCAL'				=> 'Focus length',
75
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
75
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
76 76
 	'EXIF_ISO'					=> 'ISO speed rating',
77 77
 	'EXIF_METERING_MODE'		=> 'Metering mode',
78 78
 	'EXIF_METERING_MODE_0'		=> 'Unknown',
Please login to merge, or discard this patch.
exif/language/ru/exif.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,9 +31,9 @@  discard block
 block discarded – undo
31 31
 	'EXIF_CAM_MODEL'			=> 'Модель камеры',
32 32
 	'EXIF_DATE'					=> 'Изображение заснято',
33 33
 	'EXIF_EXPOSURE'				=> 'Выдержка',
34
-	'EXIF_EXPOSURE_EXP'			=> '%s сек',// 'EXIF_EXPOSURE' unit
34
+	'EXIF_EXPOSURE_EXP'			=> '%s сек', // 'EXIF_EXPOSURE' unit
35 35
 	'EXIF_EXPOSURE_BIAS'		=> 'Корректировка выдержки',
36
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s LW',// 'EXIF_EXPOSURE_BIAS' unit
36
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s LW', // 'EXIF_EXPOSURE_BIAS' unit
37 37
 	'EXIF_EXPOSURE_PROG'		=> 'Программа экспозиции',
38 38
 	'EXIF_EXPOSURE_PROG_0'		=> 'Неопределенно',
39 39
 	'EXIF_EXPOSURE_PROG_1'		=> 'Вручную',
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	'EXIF_FLASH_CASE_93'		=> 'Вспышка сработала, авторежим, нет отражателя вспышки, подавление эффекта красных глаз',
74 74
 	'EXIF_FLASH_CASE_95'		=> 'Вспышка сработала, авторежим, отражатель вспышки сработал, подавление эффекта красных глаз',
75 75
 	'EXIF_FOCAL'				=> 'Фокусное расстояние',
76
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
76
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
77 77
 	'EXIF_ISO'					=> 'ISO-чувствительность',
78 78
 	'EXIF_METERING_MODE'		=> 'Метод выдержки и измерения',
79 79
 	'EXIF_METERING_MODE_0'		=> 'Неизвестно',
Please login to merge, or discard this patch.
exif/language/de/exif.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,9 +31,9 @@  discard block
 block discarded – undo
31 31
 	'EXIF_CAM_MODEL'			=> 'Kamera-Modell',
32 32
 	'EXIF_DATE'					=> 'Bild aufgenommen am',
33 33
 	'EXIF_EXPOSURE'				=> 'Belichtungszeit',
34
-	'EXIF_EXPOSURE_EXP'			=> '%s Sek',// 'EXIF_EXPOSURE' unit
34
+	'EXIF_EXPOSURE_EXP'			=> '%s Sek', // 'EXIF_EXPOSURE' unit
35 35
 	'EXIF_EXPOSURE_BIAS'		=> 'Belichtungskorrektur',
36
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s LW',// 'EXIF_EXPOSURE_BIAS' unit
36
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s LW', // 'EXIF_EXPOSURE_BIAS' unit
37 37
 	'EXIF_EXPOSURE_PROG'		=> 'Belichtungsprogramm',
38 38
 	'EXIF_EXPOSURE_PROG_0'		=> 'Nicht definiert',
39 39
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manuell',
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	'EXIF_FLASH_CASE_93'		=> 'Blitz wurde ausgelöst, Automodus, kein Messblitz-Licht zurückgeworfen, Rote-Augen-Reduzierung',
74 74
 	'EXIF_FLASH_CASE_95'		=> 'Blitz wurde ausgelöst, Automodus, Messblitz-Licht zurückgeworfen, Rote-Augen-Reduzierung',
75 75
 	'EXIF_FOCAL'				=> 'Brennweite',
76
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
76
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
77 77
 	'EXIF_ISO'					=> 'ISO-Empfindlichkeit',
78 78
 	'EXIF_METERING_MODE'		=> 'Belichtungs- Messmethode',
79 79
 	'EXIF_METERING_MODE_0'		=> 'Unbekannt',
Please login to merge, or discard this patch.
exif/language/fr/exif.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,9 +31,9 @@  discard block
 block discarded – undo
31 31
 	'EXIF_CAM_MODEL'			=> 'Modèle d’appareil photo',
32 32
 	'EXIF_DATE'					=> 'Image prise le',
33 33
 	'EXIF_EXPOSURE'				=> 'Vitesse d’obturation',
34
-	'EXIF_EXPOSURE_EXP'			=> '%s Sec',// 'EXIF_EXPOSURE' unit
34
+	'EXIF_EXPOSURE_EXP'			=> '%s Sec', // 'EXIF_EXPOSURE' unit
35 35
 	'EXIF_EXPOSURE_BIAS'		=> 'Angle d’exposition',
36
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
36
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
37 37
 	'EXIF_EXPOSURE_PROG'		=> 'Programme d’exposition',
38 38
 	'EXIF_EXPOSURE_PROG_0'		=> 'Non défini',
39 39
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manuel',
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	'EXIF_FLASH_CASE_93'		=> 'Flash déclenché, mode automatique, avec retour de lumière non détecté, yeux rouges réduits',
74 74
 	'EXIF_FLASH_CASE_95'		=> 'Flash déclenché, mode automatique, avec retour de lumière détecté, yeux rouges réduits',
75 75
 	'EXIF_FOCAL'				=> 'Longueur de focale',
76
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
76
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
77 77
 	'EXIF_ISO'					=> 'Sensibilité ISO',
78 78
 	'EXIF_METERING_MODE'		=> 'Mode de mesure',
79 79
 	'EXIF_METERING_MODE_0'		=> 'Inconnu',
Please login to merge, or discard this patch.
core/report.php 3 patches
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -140,10 +140,10 @@  discard block
 block discarded – undo
140 140
 	}
141 141
 
142 142
 	/**
143
-	* Delete reports for given report_ids
144
-	*
145
-	* @param	mixed	$report_ids		Array or integer with report_id.
146
-	*/
143
+	 * Delete reports for given report_ids
144
+	 *
145
+	 * @param	mixed	$report_ids		Array or integer with report_id.
146
+	 */
147 147
 	public function delete($report_ids)
148 148
 	{
149 149
 		$report_ids = self::cast_mixed_int2array($report_ids);
@@ -163,10 +163,10 @@  discard block
 block discarded – undo
163 163
 
164 164
 
165 165
 	/**
166
-	* Delete reports for given image_ids
167
-	*
168
-	* @param	mixed	$image_ids		Array or integer with image_id.
169
-	*/
166
+	 * Delete reports for given image_ids
167
+	 *
168
+	 * @param	mixed	$image_ids		Array or integer with image_id.
169
+	 */
170 170
 	public function delete_images($image_ids)
171 171
 	{
172 172
 		$image_ids = self::cast_mixed_int2array($image_ids);
@@ -194,10 +194,10 @@  discard block
 block discarded – undo
194 194
 
195 195
 
196 196
 	/**
197
-	* Delete reports for given album_ids
198
-	*
199
-	* @param	mixed	$album_ids		Array or integer with album_id.
200
-	*/
197
+	 * Delete reports for given album_ids
198
+	 *
199
+	 * @param	mixed	$album_ids		Array or integer with album_id.
200
+	 */
201 201
 	public function delete_albums($album_ids)
202 202
 	{
203 203
 		$album_ids = self::cast_mixed_int2array($album_ids);
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -249,8 +249,7 @@  discard block
 block discarded – undo
249 249
 			{
250 250
 				$mod_array[] = 0;
251 251
 			}
252
-		}
253
-		else
252
+		} else
254 253
 		{
255 254
 			$mod_array = array($album);
256 255
 		}
@@ -340,8 +339,7 @@  discard block
 block discarded – undo
340 339
 			$this->template->assign_vars(array(
341 340
 				'TOTAL_PAGES'				=> $this->language->lang('PAGE_TITLE_NUMBER', $page + 1),
342 341
 			));
343
-		}
344
-		else
342
+		} else
345 343
 		{
346 344
 			$this->pagination->generate_template_pagination(array(
347 345
 				'routes' => array(
@@ -396,8 +394,7 @@  discard block
 block discarded – undo
396 394
 		if (is_array($ids))
397 395
 		{
398 396
 			return array_map('intval', $ids);
399
-		}
400
-		else
397
+		} else
401 398
 		{
402 399
 			return array((int) $ids);
403 400
 		}
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 	protected $reports_table;
65 65
 
66 66
 	public function __construct(\phpbbgallery\core\log $gallery_log, \phpbbgallery\core\auth\auth $gallery_auth, \phpbb\user $user,
67
-		\phpbb\language\language $language, \phpbb\db\driver\driver_interface $db,	\phpbb\user_loader $user_loader,
67
+		\phpbb\language\language $language, \phpbb\db\driver\driver_interface $db, \phpbb\user_loader $user_loader,
68 68
 		\phpbbgallery\core\album\album $album, \phpbb\template\template $template, \phpbb\controller\helper $helper,
69 69
 		\phpbbgallery\core\config $gallery_config, \phpbb\pagination $pagination, \phpbbgallery\core\notification\helper $notification_helper,
70 70
 		$images_table, $reports_table)
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
 				'REPORT_TIME'	=> $this->user->format_date($VAR['report_time']),
364 364
 			));
365 365
 			unset($album_tmp);
366
-			$reported_images_count ++;
366
+			$reported_images_count++;
367 367
 		}
368 368
 		$this->template->assign_vars(array(
369 369
 			'TOTAL_IMAGES_REPORTED' => $status == 1 ? $this->language->lang('WAITING_REPORTED_IMAGE', (int) $count) : $this->language->lang('WAITING_REPORTED_DONE', (int) $count),
Please login to merge, or discard this patch.
core/upload.php 3 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 			include_once($this->root_path . 'includes/message_parser.' . $this->php_ext);
280 280
 		}
281 281
 		$message_parser = new \parse_message();
282
-		$message_parser->message	= utf8_normalize_nfc($this->get_description());
282
+		$message_parser->message = utf8_normalize_nfc($this->get_description());
283 283
 		if ($message_parser->message)
284 284
 		{
285 285
 			$message_parser->parse(true, true, true, true, false, true, true, true);
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 
335 335
 		$sql_ary = array_merge($sql_ary, $additional_sql_data);
336 336
 
337
-		$sql = 'UPDATE ' . $this->images_table. ' 
337
+		$sql = 'UPDATE ' . $this->images_table . ' 
338 338
 			SET ' . $this->db->sql_build_array('UPDATE', $sql_ary) . '
339 339
 			WHERE image_id = ' . (int) $image_id;
340 340
 		$this->db->sql_query($sql);
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
452 452
 		// Rotate the image
453 453
 		if ($this->gallery_config->get('allow_rotate') && $this->get_rotating())
454 454
 		{
455
-			$this->tools->rotate_image($this->get_rotating(),$this->gallery_config->get('allow_resize'));
455
+			$this->tools->rotate_image($this->get_rotating(), $this->gallery_config->get('allow_resize'));
456 456
 			if ($this->tools->rotated)
457 457
 			{
458 458
 				$this->tools->write_image($this->tools->image_source, $this->gallery_config->get('jpg_quality'), true);
Please login to merge, or discard this patch.
Braces   +7 added lines, -14 removed lines patch added patch discarded remove patch
@@ -144,8 +144,7 @@  discard block
 block discarded – undo
144 144
 			{
145 145
 				$this->zip_file = $this->file;
146 146
 				$this->upload_zip();
147
-			}
148
-			else
147
+			} else
149 148
 			{
150 149
 				$image_id = $this->prepare_file();
151 150
 				if ($image_id)
@@ -210,8 +209,7 @@  discard block
 block discarded – undo
210 209
 			if (is_dir($current_dir . $file))
211 210
 			{
212 211
 				$this->read_zip_folder($current_dir . $file . '/');
213
-			}
214
-			else if (in_array(utf8_substr(strtolower($file), utf8_strrpos($file, '.') + 1), self::get_allowed_types(false, true)))
212
+			} else if (in_array(utf8_substr(strtolower($file), utf8_strrpos($file, '.') + 1), self::get_allowed_types(false, true)))
215 213
 			{
216 214
 				if (!$this->file_limit || ($this->uploaded_files < $this->file_limit))
217 215
 				{
@@ -231,23 +229,20 @@  discard block
 block discarded – undo
231 229
 					{
232 230
 						$this->uploaded_files++;
233 231
 						$this->images[] = (int) $image_id;
234
-					}
235
-					else
232
+					} else
236 233
 					{
237 234
 						if ($this->file->error)
238 235
 						{
239 236
 							$this->new_error($this->language->lang('UPLOAD_ERROR', $this->file->get('uploadname'), implode('<br />&raquo; ', $this->file->error)));
240 237
 						}
241 238
 					}
242
-				}
243
-				else
239
+				} else
244 240
 				{
245 241
 					$this->quota_error();
246 242
 					@unlink($current_dir . $file);
247 243
 				}
248 244
 
249
-			}
250
-			else
245
+			} else
251 246
 			{
252 247
 				@unlink($current_dir . $file);
253 248
 			}
@@ -356,8 +351,7 @@  discard block
 block discarded – undo
356 351
 		{
357 352
 			$this->file->clean_filename('unique_ext');
358 353
 			$this->file->move_file(substr($this->gallery_url->path('upload'), 0, -1), false, false, CHMOD_ALL);
359
-		}
360
-		else
354
+		} else
361 355
 		{
362 356
 			// Okay, this looks hacky, but what we do here is, we store the directory name in the filename.
363 357
 			// However phpBB strips directories form the filename, when moving, so we need to specify that again.
@@ -411,8 +405,7 @@  discard block
 block discarded – undo
411 405
 					//$this->file->height = $this->tools->image_size['height'];
412 406
 					//$this->file->width = $this->tools->image_size['width'];
413 407
 				}
414
-			}
415
-			else
408
+			} else
416 409
 			{
417 410
 				$this->file->remove();
418 411
 				$this->new_error($this->language->lang('UPLOAD_ERROR', $this->file->get('uploadname'), $this->language->lang('UPLOAD_IMAGE_SIZE_TOO_BIG')));
Please login to merge, or discard this patch.
Indentation   +64 added lines, -64 removed lines patch added patch discarded remove patch
@@ -13,94 +13,94 @@  discard block
 block discarded – undo
13 13
 class upload
14 14
 {
15 15
 	/**
16
-	* @var \phpbb\user
17
-	*/
16
+	 * @var \phpbb\user
17
+	 */
18 18
 	protected $user;
19 19
 
20 20
 	/**
21
-	* @var \phpbb\language\language
22
-	*/
21
+	 * @var \phpbb\language\language
22
+	 */
23 23
 	protected $language;
24 24
 
25 25
 	/**
26
-	* @var \phpbb\db\driver\driver_interface
27
-	*/
26
+	 * @var \phpbb\db\driver\driver_interface
27
+	 */
28 28
 	protected $db;
29 29
 
30 30
 	/**
31
-	* @var \phpbb\event\dispatcher_interface
32
-	*/
31
+	 * @var \phpbb\event\dispatcher_interface
32
+	 */
33 33
 	protected $phpbb_dispatcher;
34 34
 
35 35
 	/**
36
-	* @var \phpbb\request\request
37
-	*/
36
+	 * @var \phpbb\request\request
37
+	 */
38 38
 	protected $request;
39 39
 
40 40
 	/**
41
-	* @var \phpbb\files\upload
42
-	*/
41
+	 * @var \phpbb\files\upload
42
+	 */
43 43
 	protected $file_upload;
44 44
 
45 45
 	/**
46
-	* @var \phpbbgallery\core\image\image
47
-	*/
46
+	 * @var \phpbbgallery\core\image\image
47
+	 */
48 48
 	protected $gallery_image;
49 49
 
50 50
 	/**
51
-	* @var \phpbbgallery\core\config
52
-	*/
51
+	 * @var \phpbbgallery\core\config
52
+	 */
53 53
 	protected $gallery_config;
54 54
 
55 55
 	/**
56
-	* @var \phpbbgallery\core\url
57
-	*/
56
+	 * @var \phpbbgallery\core\url
57
+	 */
58 58
 	protected $gallery_url;
59 59
 
60 60
 	/**
61
-	* @var \phpbbgallery\core\block
62
-	*/
61
+	 * @var \phpbbgallery\core\block
62
+	 */
63 63
 	protected $block;
64 64
 
65 65
 	/**
66
-	* @var \phpbbgallery\core\file\file
67
-	*/
66
+	 * @var \phpbbgallery\core\file\file
67
+	 */
68 68
 	protected $tools;
69 69
 
70 70
 	/**
71
-	* @var string
72
-	*/
71
+	 * @var string
72
+	 */
73 73
 	protected $images_table;
74 74
 
75 75
 	/**
76
-	* @var string
77
-	*/
76
+	 * @var string
77
+	 */
78 78
 	protected $root_path;
79 79
 
80 80
 	/**
81
-	* @var string
82
-	*/
81
+	 * @var string
82
+	 */
83 83
 	protected $php_ext;
84 84
 
85 85
 	/**
86
-	* Number of Files per Directory
87
-	*
88
-	* If this constant is set to a value >0 the gallery will create a new directory,
89
-	* when the current directory has more files in it than set here.
90
-	*/
86
+	 * Number of Files per Directory
87
+	 *
88
+	 * If this constant is set to a value >0 the gallery will create a new directory,
89
+	 * when the current directory has more files in it than set here.
90
+	 */
91 91
 	const NUM_FILES_PER_DIR = 0;
92 92
 
93 93
 	/**
94
-	* Objects: phpBB Upload, 2 Files and Image-Functions
95
-	*/
94
+	 * Objects: phpBB Upload, 2 Files and Image-Functions
95
+	 */
96 96
 	private $upload = null;
97 97
 	private $file = null;
98 98
 	private $zip_file = null;
99 99
 	//private $tools = null;
100 100
 
101 101
 	/**
102
-	* Basic variables...
103
-	*/
102
+	 * Basic variables...
103
+	 */
104 104
 	public $loaded_files = 0;
105 105
 	public $uploaded_files = 0;
106 106
 	public $errors = array();
@@ -228,8 +228,8 @@  discard block
 block discarded – undo
228 228
 	}
229 229
 
230 230
 	/**
231
-	* Upload a zip file and save the images into the import/ directory.
232
-	*/
231
+	 * Upload a zip file and save the images into the import/ directory.
232
+	 */
233 233
 	public function upload_zip()
234 234
 	{
235 235
 		if (!class_exists('compress_zip'))
@@ -377,14 +377,14 @@  discard block
 block discarded – undo
377 377
 		$file_link = $this->gallery_url->path('upload') . $this->image_data[$image_id]['image_filename'];
378 378
 
379 379
 		/**
380
-		* Event upload image before
381
-		*
382
-		* @event phpbbgallery.core.upload.update_image_before
383
-		* @var	array	additional_sql_data		array of additional settings
384
-		* @var	array	image_data				array of image_data
385
-		* @var	string	file_link				link to file
386
-		* @since 1.2.0
387
-		*/
380
+		 * Event upload image before
381
+		 *
382
+		 * @event phpbbgallery.core.upload.update_image_before
383
+		 * @var	array	additional_sql_data		array of additional settings
384
+		 * @var	array	image_data				array of image_data
385
+		 * @var	string	file_link				link to file
386
+		 * @since 1.2.0
387
+		 */
388 388
 		$vars = array('additional_sql_data', 'image_data', 'file_link');
389 389
 		extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.upload.update_image_before', compact($vars)));
390 390
 
@@ -392,12 +392,12 @@  discard block
 block discarded – undo
392 392
 		if (!$this->prepare_file_update($image_id))
393 393
 		{
394 394
 			/**
395
-			* Event upload image update
396
-			*
397
-			* @event phpbbgallery.core.upload.update_image_nofilechange
398
-			* @var	array	additional_sql_data		array of additional settings
399
-			* @since 1.2.0
400
-			*/
395
+			 * Event upload image update
396
+			 *
397
+			 * @event phpbbgallery.core.upload.update_image_nofilechange
398
+			 * @var	array	additional_sql_data		array of additional settings
399
+			 * @since 1.2.0
400
+			 */
401 401
 			$vars = array('additional_sql_data');
402 402
 			extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.upload.update_image_nofilechange', compact($vars)));
403 403
 		}
@@ -415,8 +415,8 @@  discard block
 block discarded – undo
415 415
 	}
416 416
 
417 417
 	/**
418
-	* Prepare file on upload: rotate and resize
419
-	*/
418
+	 * Prepare file on upload: rotate and resize
419
+	 */
420 420
 	public function prepare_file()
421 421
 	{
422 422
 		$upload_dir = $this->get_current_upload_dir();
@@ -446,13 +446,13 @@  discard block
 block discarded – undo
446 446
 		$file = $this->file;
447 447
 
448 448
 		/**
449
-		* Event upload image update
450
-		*
451
-		* @event phpbbgallery.core.upload.prepare_file_before
452
-		* @var	array	additional_sql_data		array of additional settings
453
-		* @var	array	file					File object
454
-		* @since 1.2.0
455
-		*/
449
+		 * Event upload image update
450
+		 *
451
+		 * @event phpbbgallery.core.upload.prepare_file_before
452
+		 * @var	array	additional_sql_data		array of additional settings
453
+		 * @var	array	file					File object
454
+		 * @since 1.2.0
455
+		 */
456 456
 		$vars = array('additional_sql_data', 'file');
457 457
 		extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.upload.prepare_file_before', compact($vars)));
458 458
 
@@ -804,8 +804,8 @@  discard block
 block discarded – undo
804 804
 	}
805 805
 
806 806
 	/**
807
-	* Generate some kind of check so users only complete the uplaod for their images
808
-	*/
807
+	 * Generate some kind of check so users only complete the uplaod for their images
808
+	 */
809 809
 	public function generate_hidden_fields()
810 810
 	{
811 811
 		$checks = array();
Please login to merge, or discard this patch.
core/contest.php 3 patches
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -34,18 +34,18 @@  discard block
 block discarded – undo
34 34
 	const NUM_IMAGES = 3;
35 35
 
36 36
 	/**
37
-	* There are different modes to calculate who won the contest.
38
-	* This value should be one of the constant-names below.
39
-	*/
37
+	 * There are different modes to calculate who won the contest.
38
+	 * This value should be one of the constant-names below.
39
+	 */
40 40
 	static public $mode = self::MODE_AVERAGE;
41 41
 
42 42
 	/**
43
-	* The image with the highest average wins.
44
-	*/
43
+	 * The image with the highest average wins.
44
+	 */
45 45
 	const MODE_AVERAGE = 1;
46 46
 	/**
47
-	* The image with the highest number of total points wins.
48
-	*/
47
+	 * The image with the highest number of total points wins.
48
+	 */
49 49
 	const MODE_SUM = 2;
50 50
 
51 51
 	public function __construct(\phpbb\db\driver\driver_interface $db,
@@ -59,14 +59,14 @@  discard block
 block discarded – undo
59 59
 	}
60 60
 
61 61
 	/**
62
-	* Get the contest row from the table
63
-	*
64
-	* @param	int		$id				ID of the contest or album, depending on second parameter
65
-	* @param	string	$mode			contest or album ID to get the contest.
66
-	* @param	bool	$throw_error	Shall we throw an error if the contest was not found?
67
-	*
68
-	* @return	mixed	Either the array or boolean false if contest does not exist
69
-	*/
62
+	 * Get the contest row from the table
63
+	 *
64
+	 * @param	int		$id				ID of the contest or album, depending on second parameter
65
+	 * @param	string	$mode			contest or album ID to get the contest.
66
+	 * @param	bool	$throw_error	Shall we throw an error if the contest was not found?
67
+	 *
68
+	 * @return	mixed	Either the array or boolean false if contest does not exist
69
+	 */
70 70
 	public function get_contest($id, $mode = 'contest', $throw_error = true)
71 71
 	{
72 72
 		$sql = 'SELECT *
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -190,9 +190,9 @@
 block discarded – undo
190 190
 		$this->db->sql_freeresult($result);
191 191
 
192 192
 		$sql = 'UPDATE ' . $this->contest_table . '
193
-			SET contest_first = ' . (int) $first .',
194
-				contest_second = ' . (int) $second .',
195
-				contest_third = ' . (int) $third .'
193
+			SET contest_first = ' . (int) $first . ',
194
+				contest_second = ' . (int) $second . ',
195
+				contest_third = ' . (int) $third . '
196 196
 			WHERE contest_album_id = ' . (int) $album_id;
197 197
 		$this->db->sql_query($sql);
198 198
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -165,8 +165,7 @@
 block discarded – undo
165 165
 			{
166 166
 				$this->resync($album_id);
167 167
 			}
168
-		}
169
-		else
168
+		} else
170 169
 		{
171 170
 			$this->resync((int) $album_ids);
172 171
 		}
Please login to merge, or discard this patch.
core/rating.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	*/
159 159
 	public function display_box()
160 160
 	{
161
-		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT);//@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
161
+		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT); //@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
162 162
 
163 163
 		switch (self::MODE_SELECT)//@todo: phpbb_ext_gallery_core_config::get('rating_mode'))
164 164
 		{
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 	 */
202 202
 	public function get_image_rating($user_rating = false, $display_contest_end = true)
203 203
 	{
204
-		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT);//@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
204
+		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT); //@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
205 205
 
206 206
 		switch (self::MODE_SELECT)//@todo: phpbb_ext_gallery_core_config::get('rating_mode'))
207 207
 		{
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -216,8 +216,7 @@  discard block
 block discarded – undo
216 216
 						return $this->language->lang('CONTEST_RATING_HIDDEN');
217 217
 					}
218 218
 					return $this->language->lang('CONTEST_RESULT_HIDDEN', $this->user->format_date(($this->album_data('contest_start') + $this->album_data('contest_end')), false, true));
219
-				}
220
-				else
219
+				} else
221 220
 				{
222 221
 					if ($user_rating)
223 222
 					{
@@ -364,8 +363,7 @@  discard block
 block discarded – undo
364 363
 		if (is_array($image_ids))
365 364
 		{
366 365
 			$image_ids = array_map('intval', $image_ids);
367
-		}
368
-		else
366
+		} else
369 367
 		{
370 368
 			$image_ids = (int) $image_ids;
371 369
 		}
@@ -399,8 +397,7 @@  discard block
 block discarded – undo
399 397
 		if (is_array($image_ids))
400 398
 		{
401 399
 			$image_ids = array_map('intval', $image_ids);
402
-		}
403
-		else
400
+		} else
404 401
 		{
405 402
 			$image_ids = (int) $image_ids;
406 403
 		}
Please login to merge, or discard this patch.
Indentation   +69 added lines, -69 removed lines patch added patch discarded remove patch
@@ -13,91 +13,91 @@  discard block
 block discarded – undo
13 13
 class rating
14 14
 {
15 15
 	/**
16
-	* @var \phpbb\db\driver\driver_interface
17
-	*/
16
+	 * @var \phpbb\db\driver\driver_interface
17
+	 */
18 18
 	protected $db;
19 19
 
20 20
 	/**
21
-	* @var \phpbb\template\template
22
-	*/
21
+	 * @var \phpbb\template\template
22
+	 */
23 23
 	protected $template;
24 24
 
25 25
 	/**
26
-	* @var \phpbb\user
27
-	*/
26
+	 * @var \phpbb\user
27
+	 */
28 28
 	protected $user;
29 29
 
30 30
 	/**
31
-	* @var \phpbb\language\language
32
-	*/
31
+	 * @var \phpbb\language\language
32
+	 */
33 33
 	protected $language;
34 34
 
35 35
 	/**
36
-	* @var \phpbb\request\request
37
-	*/
36
+	 * @var \phpbb\request\request
37
+	 */
38 38
 	protected $request;
39 39
 
40 40
 	/**
41
-	* @var \phpbbgallery\core\config
42
-	*/
41
+	 * @var \phpbbgallery\core\config
42
+	 */
43 43
 	protected $gallery_config;
44 44
 
45 45
 	/**
46
-	* @var \phpbbgallery\core\auth\auth
47
-	*/
46
+	 * @var \phpbbgallery\core\auth\auth
47
+	 */
48 48
 	protected $gallery_auth;
49 49
 
50 50
 	/**
51
-	* @var string
52
-	*/
51
+	 * @var string
52
+	 */
53 53
 	protected $images_table;
54 54
 
55 55
 	/**
56
-	* @var string
57
-	*/
56
+	 * @var string
57
+	 */
58 58
 	protected $albums_table;
59 59
 
60 60
 	/**
61
-	* @var string
62
-	*/
61
+	 * @var string
62
+	 */
63 63
 	protected $rates_table;
64 64
 
65 65
 	/**
66
-	* The image ID we want to rate
67
-	*/
66
+	 * The image ID we want to rate
67
+	 */
68 68
 	public $image_id = 0;
69 69
 
70 70
 	/**
71
-	* Private objects with the values for the image/album from the database
72
-	*/
71
+	 * Private objects with the values for the image/album from the database
72
+	 */
73 73
 	private $image_data = null;
74 74
 	private $album_data = null;
75 75
 
76 76
 	/**
77
-	* Rating the user gave the image.
78
-	*/
77
+	 * Rating the user gave the image.
78
+	 */
79 79
 	public $user_rating = null;
80 80
 
81 81
 	/**
82
-	* Is rating currently possible?
83
-	* Might be blocked because of contest-settings.
84
-	*/
82
+	 * Is rating currently possible?
83
+	 * Might be blocked because of contest-settings.
84
+	 */
85 85
 	public $rating_enabled = false;
86 86
 
87 87
 	/**
88
-	* Classic-rating box with a dropdown.
89
-	*/
88
+	 * Classic-rating box with a dropdown.
89
+	 */
90 90
 	const MODE_SELECT = 1;
91 91
 
92 92
 	/**
93
-	* Rating with stars, like the old-system from youtube.
93
+	 * Rating with stars, like the old-system from youtube.
94 94
 	//@todo: const MODE_STARS = 2;
95
-	*/
95
+	 */
96 96
 
97 97
 	/**
98
-	* Simple thumbs up or down.
98
+	 * Simple thumbs up or down.
99 99
 	//@todo: const MODE_THUMB = 3;
100
-	*/
100
+	 */
101 101
 
102 102
 	/**
103 103
 	 * Constructor
@@ -204,8 +204,8 @@  discard block
 block discarded – undo
204 204
 	}
205 205
 
206 206
 	/**
207
-	* Displays the box where the user can rate the image.
208
-	*/
207
+	 * Displays the box where the user can rate the image.
208
+	 */
209 209
 	public function display_box()
210 210
 	{
211 211
 		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT);//@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
@@ -280,8 +280,8 @@  discard block
 block discarded – undo
280 280
 	}
281 281
 
282 282
 	/**
283
-	* Get rated value for a image
284
-	*/
283
+	 * Get rated value for a image
284
+	 */
285 285
 	private function get_image_rating_value()
286 286
 	{
287 287
 		/*if (phpbb_ext_gallery_core_contest::$mode == phpbb_ext_gallery_core_contest::MODE_SUM)
@@ -295,14 +295,14 @@  discard block
 block discarded – undo
295 295
 	}
296 296
 
297 297
 	/**
298
-	* Is the user allowed to rate?
299
-	* Following statements must be true:
300
-	*	- User must have permissions.
301
-	*	- User is neither owner of the image nor guest.
302
-	*	- Album and image are not locked.
303
-	*
304
-	* @return	bool
305
-	*/
298
+	 * Is the user allowed to rate?
299
+	 * Following statements must be true:
300
+	 *	- User must have permissions.
301
+	 *	- User is neither owner of the image nor guest.
302
+	 *	- Album and image are not locked.
303
+	 *
304
+	 * @return	bool
305
+	 */
306 306
 	public function is_allowed()
307 307
 	{
308 308
 		return $this->gallery_auth->acl_check('i_rate', $this->album_data('album_id'), $this->album_data('album_user_id')) &&
@@ -311,25 +311,25 @@  discard block
 block discarded – undo
311 311
 	}
312 312
 
313 313
 	/**
314
-	* Is the user able to rate?
315
-	* Following statements must be true:
316
-	*	- User must be allowed to rate
317
-	*	- If the image is in a contest, it must be in the rating timespan
318
-	*
319
-	* @return	bool
320
-	*/
314
+	 * Is the user able to rate?
315
+	 * Following statements must be true:
316
+	 *	- User must be allowed to rate
317
+	 *	- If the image is in a contest, it must be in the rating timespan
318
+	 *
319
+	 * @return	bool
320
+	 */
321 321
 	public function is_able()
322 322
 	{
323 323
 		return $this->is_allowed(); //&& phpbb_ext_gallery_core_contest::is_step('rate', $this->album_data(true));
324 324
 	}
325 325
 
326 326
 	/**
327
-	* Get rating from a user for a given image
328
-	*
329
-	* @param	int		$user_id
330
-	*
331
-	* @return	mixed	False if the user did not rate or is guest, otherwise int the points.
332
-	*/
327
+	 * Get rating from a user for a given image
328
+	 *
329
+	 * @param	int		$user_id
330
+	 *
331
+	 * @return	mixed	False if the user did not rate or is guest, otherwise int the points.
332
+	 */
333 333
 	public function get_user_rating($user_id)
334 334
 	{
335 335
 		if (isset($this->user_rating[$user_id]))
@@ -405,10 +405,10 @@  discard block
 block discarded – undo
405 405
 	}
406 406
 
407 407
 	/**
408
-	* Recalculate the average image-rating and such stuff.
409
-	*
410
-	* @param	mixed	$image_ids	Array or integer with image_id where we recalculate the rating.
411
-	*/
408
+	 * Recalculate the average image-rating and such stuff.
409
+	 *
410
+	 * @param	mixed	$image_ids	Array or integer with image_id where we recalculate the rating.
411
+	 */
412 412
 	public function recalc_image_rating($image_ids)
413 413
 	{
414 414
 		if (is_array($image_ids))
@@ -439,11 +439,11 @@  discard block
 block discarded – undo
439 439
 	}
440 440
 
441 441
 	/**
442
-	* Delete all ratings for given image_ids
443
-	*
444
-	* @param	mixed	$image_ids		Array or integer with image_id where we delete the rating.
445
-	* @param	bool	$reset_average	Shall we also reset the average? We can save that query, when the images are deleted anyway.
446
-	*/
442
+	 * Delete all ratings for given image_ids
443
+	 *
444
+	 * @param	mixed	$image_ids		Array or integer with image_id where we delete the rating.
445
+	 * @param	bool	$reset_average	Shall we also reset the average? We can save that query, when the images are deleted anyway.
446
+	 */
447 447
 	public function delete_ratings($image_ids, $reset_average = false)
448 448
 	{
449 449
 		if (is_array($image_ids))
Please login to merge, or discard this patch.