satanasov / phpbbgallery

exif/event/exif_listener.php

Braces +1 added lines, -2 removed lines

@@ -146,8 +146,7 @@
 
 			$event['additional_sql_data'] = $additional_sql_data;
 			unset($exif);
-		}
-		else
+		} else
 		{
 			$additional_sql_data = $event['additional_sql_data'];
 			$additional_sql_data['image_exif_data'] = '';

Indentation +10 added lines, -10 removed lines

@@ -54,16 +54,16 @@
 	}
 
 	/**
-	* Constructor
-	* NOTE: The parameters of this method must match in order and type with
-	* the dependencies defined in the services.yml file for this service.
-	*
-	* @param \phpbb\user					$user			User object
-	* @param \phpbbgallery\core\config		$gallery_config	Core gallery config object
-	* @param \phpbbgallery\core\auth\auth	$gallery_auth	Core gallery auth object
-	* @param \phpbbgallery\core\url			$gallery_url	Core gallery url object
-	* @param \phpbbgallery\core\user		$gallery_user	Core gallery user wrapper
-	*/
+	 * Constructor
+	 * NOTE: The parameters of this method must match in order and type with
+	 * the dependencies defined in the services.yml file for this service.
+	 *
+	 * @param \phpbb\user					$user			User object
+	 * @param \phpbbgallery\core\config		$gallery_config	Core gallery config object
+	 * @param \phpbbgallery\core\auth\auth	$gallery_auth	Core gallery auth object
+	 * @param \phpbbgallery\core\url			$gallery_url	Core gallery url object
+	 * @param \phpbbgallery\core\user		$gallery_user	Core gallery user wrapper
+	 */
 
 	public function __construct(\phpbb\user $user, \phpbbgallery\core\config $gallery_config, \phpbbgallery\core\auth\auth $gallery_auth, \phpbbgallery\core\url $gallery_url, \phpbbgallery\core\user $gallery_user)
 	{

Spacing +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
 		$this->user = $user;
 		$this->gallery_config = $gallery_config;
 		$this->gallery_auth = $gallery_auth;
-		$this->gallery_url	= $gallery_url;
+		$this->gallery_url = $gallery_url;
 		$this->gallery_user = $gallery_user;
 	}
 
@@ -83,7 +83,7 @@ 
 			{
 				$this->user->add_lang_ext('phpbbgallery/exif', 'info_exif');
 
-				$return_ary['vars']['IMAGE_SETTINGS']['disp_exifdata'] = array('lang' => 'DISP_EXIF_DATA',		'validate' => 'bool',	'type' => 'radio:yes_no');
+				$return_ary['vars']['IMAGE_SETTINGS']['disp_exifdata'] = array('lang' => 'DISP_EXIF_DATA', 'validate' => 'bool', 'type' => 'radio:yes_no');
 				$event['return_ary'] = $return_ary;
 			}
 		}

core/report.php

Indentation +12 added lines, -12 removed lines

@@ -140,10 +140,10 @@ 
 	}
 
 	/**
-	* Delete reports for given report_ids
-	*
-	* @param	mixed	$report_ids		Array or integer with report_id.
-	*/
+	 * Delete reports for given report_ids
+	 *
+	 * @param	mixed	$report_ids		Array or integer with report_id.
+	 */
 	public function delete($report_ids)
 	{
 		$report_ids = self::cast_mixed_int2array($report_ids);
@@ -163,10 +163,10 @@ 
 
 
 	/**
-	* Delete reports for given image_ids
-	*
-	* @param	mixed	$image_ids		Array or integer with image_id.
-	*/
+	 * Delete reports for given image_ids
+	 *
+	 * @param	mixed	$image_ids		Array or integer with image_id.
+	 */
 	public function delete_images($image_ids)
 	{
 		$image_ids = self::cast_mixed_int2array($image_ids);
@@ -194,10 +194,10 @@ 
 
 
 	/**
-	* Delete reports for given album_ids
-	*
-	* @param	mixed	$album_ids		Array or integer with album_id.
-	*/
+	 * Delete reports for given album_ids
+	 *
+	 * @param	mixed	$album_ids		Array or integer with album_id.
+	 */
 	public function delete_albums($album_ids)
 	{
 		$album_ids = self::cast_mixed_int2array($album_ids);

Braces +3 added lines, -6 removed lines

@@ -249,8 +249,7 @@ 
 			{
 				$mod_array[] = 0;
 			}
-		}
-		else
+		} else
 		{
 			$mod_array = array($album);
 		}
@@ -340,8 +339,7 @@ 
 			$this->template->assign_vars(array(
 				'TOTAL_PAGES'				=> $this->language->lang('PAGE_TITLE_NUMBER', $page + 1),
 			));
-		}
-		else
+		} else
 		{
 			$this->pagination->generate_template_pagination(array(
 				'routes' => array(
@@ -396,8 +394,7 @@ 
 		if (is_array($ids))
 		{
 			return array_map('intval', $ids);
-		}
-		else
+		} else
 		{
 			return array((int) $ids);
 		}

Spacing +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
 	protected $reports_table;
 
 	public function __construct(\phpbbgallery\core\log $gallery_log, \phpbbgallery\core\auth\auth $gallery_auth, \phpbb\user $user,
-		\phpbb\language\language $language, \phpbb\db\driver\driver_interface $db,	\phpbb\user_loader $user_loader,
+		\phpbb\language\language $language, \phpbb\db\driver\driver_interface $db, \phpbb\user_loader $user_loader,
 		\phpbbgallery\core\album\album $album, \phpbb\template\template $template, \phpbb\controller\helper $helper,
 		\phpbbgallery\core\config $gallery_config, \phpbb\pagination $pagination, \phpbbgallery\core\notification\helper $notification_helper,
 		$images_table, $reports_table)
@@ -363,7 +363,7 @@ 
 				'REPORT_TIME'	=> $this->user->format_date($VAR['report_time']),
 			));
 			unset($album_tmp);
-			$reported_images_count ++;
+			$reported_images_count++;
 		}
 		$this->template->assign_vars(array(
 			'TOTAL_IMAGES_REPORTED' => $status == 1 ? $this->language->lang('WAITING_REPORTED_IMAGE', (int) $count) : $this->language->lang('WAITING_REPORTED_DONE', (int) $count),

core/upload.php

Spacing +3 added lines, -3 removed lines

@@ -279,7 +279,7 @@ 
 			include_once($this->root_path . 'includes/message_parser.' . $this->php_ext);
 		}
 		$message_parser = new \parse_message();
-		$message_parser->message	= utf8_normalize_nfc($this->get_description());
+		$message_parser->message = utf8_normalize_nfc($this->get_description());
 		if ($message_parser->message)
 		{
 			$message_parser->parse(true, true, true, true, false, true, true, true);
@@ -334,7 +334,7 @@ 
 
 		$sql_ary = array_merge($sql_ary, $additional_sql_data);
 
-		$sql = 'UPDATE ' . $this->images_table. ' 
+		$sql = 'UPDATE ' . $this->images_table . ' 
 			SET ' . $this->db->sql_build_array('UPDATE', $sql_ary) . '
 			WHERE image_id = ' . (int) $image_id;
 		$this->db->sql_query($sql);
@@ -452,7 +452,7 @@ 
 		// Rotate the image
 		if ($this->gallery_config->get('allow_rotate') && $this->get_rotating())
 		{
-			$this->tools->rotate_image($this->get_rotating(),$this->gallery_config->get('allow_resize'));
+			$this->tools->rotate_image($this->get_rotating(), $this->gallery_config->get('allow_resize'));
 			if ($this->tools->rotated)
 			{
 				$this->tools->write_image($this->tools->image_source, $this->gallery_config->get('jpg_quality'), true);

Braces +7 added lines, -14 removed lines

@@ -144,8 +144,7 @@ 
 			{
 				$this->zip_file = $this->file;
 				$this->upload_zip();
-			}
-			else
+			} else
 			{
 				$image_id = $this->prepare_file();
 				if ($image_id)
@@ -210,8 +209,7 @@ 
 			if (is_dir($current_dir . $file))
 			{
 				$this->read_zip_folder($current_dir . $file . '/');
-			}
-			else if (in_array(utf8_substr(strtolower($file), utf8_strrpos($file, '.') + 1), self::get_allowed_types(false, true)))
+			} else if (in_array(utf8_substr(strtolower($file), utf8_strrpos($file, '.') + 1), self::get_allowed_types(false, true)))
 			{
 				if (!$this->file_limit || ($this->uploaded_files < $this->file_limit))
 				{
@@ -231,23 +229,20 @@ 
 					{
 						$this->uploaded_files++;
 						$this->images[] = (int) $image_id;
-					}
-					else
+					} else
 					{
 						if ($this->file->error)
 						{
 							$this->new_error($this->language->lang('UPLOAD_ERROR', $this->file->get('uploadname'), implode('<br />&raquo; ', $this->file->error)));
 						}
 					}
-				}
-				else
+				} else
 				{
 					$this->quota_error();
 					@unlink($current_dir . $file);
 				}
 
-			}
-			else
+			} else
 			{
 				@unlink($current_dir . $file);
 			}
@@ -356,8 +351,7 @@ 
 		{
 			$this->file->clean_filename('unique_ext');
 			$this->file->move_file(substr($this->gallery_url->path('upload'), 0, -1), false, false, CHMOD_ALL);
-		}
-		else
+		} else
 		{
 			// Okay, this looks hacky, but what we do here is, we store the directory name in the filename.
 			// However phpBB strips directories form the filename, when moving, so we need to specify that again.
@@ -411,8 +405,7 @@ 
 					//$this->file->height = $this->tools->image_size['height'];
 					//$this->file->width = $this->tools->image_size['width'];
 				}
-			}
-			else
+			} else
 			{
 				$this->file->remove();
 				$this->new_error($this->language->lang('UPLOAD_ERROR', $this->file->get('uploadname'), $this->language->lang('UPLOAD_IMAGE_SIZE_TOO_BIG')));

Indentation +64 added lines, -64 removed lines

@@ -15,94 +15,94 @@ 
 class upload
 {
 	/**
-	* @var \phpbb\user
-	*/
+	 * @var \phpbb\user
+	 */
 	protected $user;
 
 	/**
-	* @var \phpbb\language\language
-	*/
+	 * @var \phpbb\language\language
+	 */
 	protected $language;
 
 	/**
-	* @var \phpbb\db\driver\driver_interface
-	*/
+	 * @var \phpbb\db\driver\driver_interface
+	 */
 	protected $db;
 
 	/**
-	* @var \phpbb\event\dispatcher_interface
-	*/
+	 * @var \phpbb\event\dispatcher_interface
+	 */
 	protected $phpbb_dispatcher;
 
 	/**
-	* @var \phpbb\request\request
-	*/
+	 * @var \phpbb\request\request
+	 */
 	protected $request;
 
 	/**
-	* @var \phpbb\files\upload
-	*/
+	 * @var \phpbb\files\upload
+	 */
 	protected $file_upload;
 
 	/**
-	* @var \phpbbgallery\core\image\image
-	*/
+	 * @var \phpbbgallery\core\image\image
+	 */
 	protected $gallery_image;
 
 	/**
-	* @var \phpbbgallery\core\config
-	*/
+	 * @var \phpbbgallery\core\config
+	 */
 	protected $gallery_config;
 
 	/**
-	* @var \phpbbgallery\core\url
-	*/
+	 * @var \phpbbgallery\core\url
+	 */
 	protected $gallery_url;
 
 	/**
-	* @var \phpbbgallery\core\block
-	*/
+	 * @var \phpbbgallery\core\block
+	 */
 	protected $block;
 
 	/**
-	* @var \phpbbgallery\core\file\file
-	*/
+	 * @var \phpbbgallery\core\file\file
+	 */
 	protected $tools;
 
 	/**
-	* @var string
-	*/
+	 * @var string
+	 */
 	protected $images_table;
 
 	/**
-	* @var string
-	*/
+	 * @var string
+	 */
 	protected $root_path;
 
 	/**
-	* @var string
-	*/
+	 * @var string
+	 */
 	protected $php_ext;
 
 	/**
-	* Number of Files per Directory
-	*
-	* If this constant is set to a value >0 the gallery will create a new directory,
-	* when the current directory has more files in it than set here.
-	*/
+	 * Number of Files per Directory
+	 *
+	 * If this constant is set to a value >0 the gallery will create a new directory,
+	 * when the current directory has more files in it than set here.
+	 */
 	const NUM_FILES_PER_DIR = 0;
 
 	/**
-	* Objects: phpBB Upload, 2 Files and Image-Functions
-	*/
+	 * Objects: phpBB Upload, 2 Files and Image-Functions
+	 */
 	private $upload = null;
 	private $file = null;
 	private $zip_file = null;
 	//private $tools = null;
 
 	/**
-	* Basic variables...
-	*/
+	 * Basic variables...
+	 */
 	public $loaded_files = 0;
 	public $uploaded_files = 0;
 	public $errors = array();
@@ -230,8 +230,8 @@ 
 	}
 
 	/**
-	* Upload a zip file and save the images into the import/ directory.
-	*/
+	 * Upload a zip file and save the images into the import/ directory.
+	 */
 	public function upload_zip()
 	{
 		if (!class_exists('compress_zip'))
@@ -379,14 +379,14 @@ 
 		$file_link = $this->gallery_url->path('upload') . $this->image_data[$image_id]['image_filename'];
 
 		/**
-		* Event upload image before
-		*
-		* @event phpbbgallery.core.upload.update_image_before
-		* @var	array	additional_sql_data		array of additional settings
-		* @var	array	image_data				array of image_data
-		* @var	string	file_link				link to file
-		* @since 1.2.0
-		*/
+		 * Event upload image before
+		 *
+		 * @event phpbbgallery.core.upload.update_image_before
+		 * @var	array	additional_sql_data		array of additional settings
+		 * @var	array	image_data				array of image_data
+		 * @var	string	file_link				link to file
+		 * @since 1.2.0
+		 */
 		$vars = array('additional_sql_data', 'image_data', 'file_link');
 		extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.upload.update_image_before', compact($vars)));
 
@@ -394,12 +394,12 @@ 
 		if (!$this->prepare_file_update($image_id))
 		{
 			/**
-			* Event upload image update
-			*
-			* @event phpbbgallery.core.upload.update_image_nofilechange
-			* @var	array	additional_sql_data		array of additional settings
-			* @since 1.2.0
-			*/
+			 * Event upload image update
+			 *
+			 * @event phpbbgallery.core.upload.update_image_nofilechange
+			 * @var	array	additional_sql_data		array of additional settings
+			 * @since 1.2.0
+			 */
 			$vars = array('additional_sql_data');
 			extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.upload.update_image_nofilechange', compact($vars)));
 		}
@@ -415,8 +415,8 @@ 
 	}
 
 	/**
-	* Prepare file on upload: rotate and resize
-	*/
+	 * Prepare file on upload: rotate and resize
+	 */
 	public function prepare_file()
 	{
 		$upload_dir = $this->get_current_upload_dir();
@@ -446,13 +446,13 @@ 
 		$file = $this->file;
 
 		/**
-		* Event upload image update
-		*
-		* @event phpbbgallery.core.upload.prepare_file_before
-		* @var	array	additional_sql_data		array of additional settings
-		* @var	array	file					File object
-		* @since 1.2.0
-		*/
+		 * Event upload image update
+		 *
+		 * @event phpbbgallery.core.upload.prepare_file_before
+		 * @var	array	additional_sql_data		array of additional settings
+		 * @var	array	file					File object
+		 * @since 1.2.0
+		 */
 		$vars = array('additional_sql_data', 'file');
 		extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.upload.prepare_file_before', compact($vars)));
 
@@ -804,8 +804,8 @@ 
 	}
 
 	/**
-	* Generate some kind of check so users only complete the upload for their images
-	*/
+	 * Generate some kind of check so users only complete the upload for their images
+	 */
 	public function generate_hidden_fields()
 	{
 		$checks = array();

core/contest.php

Indentation +15 added lines, -15 removed lines

@@ -34,18 +34,18 @@ 
 	const NUM_IMAGES = 3;
 
 	/**
-	* There are different modes to calculate who won the contest.
-	* This value should be one of the constant-names below.
-	*/
+	 * There are different modes to calculate who won the contest.
+	 * This value should be one of the constant-names below.
+	 */
 	static public $mode = self::MODE_AVERAGE;
 
 	/**
-	* The image with the highest average wins.
-	*/
+	 * The image with the highest average wins.
+	 */
 	const MODE_AVERAGE = 1;
 	/**
-	* The image with the highest number of total points wins.
-	*/
+	 * The image with the highest number of total points wins.
+	 */
 	const MODE_SUM = 2;
 
 	public function __construct(\phpbb\db\driver\driver_interface $db,
@@ -59,14 +59,14 @@ 
 	}
 
 	/**
-	* Get the contest row from the table
-	*
-	* @param	int		$id				ID of the contest or album, depending on second parameter
-	* @param	string	$mode			contest or album ID to get the contest.
-	* @param	bool	$throw_error	Shall we throw an error if the contest was not found?
-	*
-	* @return	mixed	Either the array or boolean false if contest does not exist
-	*/
+	 * Get the contest row from the table
+	 *
+	 * @param	int		$id				ID of the contest or album, depending on second parameter
+	 * @param	string	$mode			contest or album ID to get the contest.
+	 * @param	bool	$throw_error	Shall we throw an error if the contest was not found?
+	 *
+	 * @return	mixed	Either the array or boolean false if contest does not exist
+	 */
 	public function get_contest($id, $mode = 'contest', $throw_error = true)
 	{
 		$sql = 'SELECT *

Spacing +3 added lines, -3 removed lines

@@ -190,9 +190,9 @@
 		$this->db->sql_freeresult($result);
 
 		$sql = 'UPDATE ' . $this->contest_table . '
-			SET contest_first = ' . (int) $first .',
-				contest_second = ' . (int) $second .',
-				contest_third = ' . (int) $third .'
+			SET contest_first = ' . (int) $first . ',
+				contest_second = ' . (int) $second . ',
+				contest_third = ' . (int) $third . '
 			WHERE contest_album_id = ' . (int) $album_id;
 		$this->db->sql_query($sql);
 

Braces +1 added lines, -2 removed lines

@@ -165,8 +165,7 @@
 			{
 				$this->resync($album_id);
 			}
-		}
-		else
+		} else
 		{
 			$this->resync((int) $album_ids);
 		}

core/rating.php

Spacing +2 added lines, -2 removed lines

@@ -158,7 +158,7 @@ 
 	*/
 	public function display_box()
 	{
-		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT);//@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
+		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT); //@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
 
 		switch (self::MODE_SELECT)//@todo: phpbb_ext_gallery_core_config::get('rating_mode'))
 		{
@@ -201,7 +201,7 @@ 
 	 */
 	public function get_image_rating($user_rating = false, $display_contest_end = true)
 	{
-		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT);//@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
+		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT); //@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
 
 		switch (self::MODE_SELECT)//@todo: phpbb_ext_gallery_core_config::get('rating_mode'))
 		{

Braces +3 added lines, -6 removed lines

@@ -216,8 +216,7 @@ 
 						return $this->language->lang('CONTEST_RATING_HIDDEN');
 					}
 					return $this->language->lang('CONTEST_RESULT_HIDDEN', $this->user->format_date(($this->album_data('contest_start') + $this->album_data('contest_end')), false, true));
-				}
-				else
+				} else
 				{
 					if ($user_rating)
 					{
@@ -364,8 +363,7 @@ 
 		if (is_array($image_ids))
 		{
 			$image_ids = array_map('intval', $image_ids);
-		}
-		else
+		} else
 		{
 			$image_ids = (int) $image_ids;
 		}
@@ -399,8 +397,7 @@ 
 		if (is_array($image_ids))
 		{
 			$image_ids = array_map('intval', $image_ids);
-		}
-		else
+		} else
 		{
 			$image_ids = (int) $image_ids;
 		}

Indentation +69 added lines, -69 removed lines

@@ -13,91 +13,91 @@ 
 class rating
 {
 	/**
-	* @var \phpbb\db\driver\driver_interface
-	*/
+	 * @var \phpbb\db\driver\driver_interface
+	 */
 	protected $db;
 
 	/**
-	* @var \phpbb\template\template
-	*/
+	 * @var \phpbb\template\template
+	 */
 	protected $template;
 
 	/**
-	* @var \phpbb\user
-	*/
+	 * @var \phpbb\user
+	 */
 	protected $user;
 
 	/**
-	* @var \phpbb\language\language
-	*/
+	 * @var \phpbb\language\language
+	 */
 	protected $language;
 
 	/**
-	* @var \phpbb\request\request
-	*/
+	 * @var \phpbb\request\request
+	 */
 	protected $request;
 
 	/**
-	* @var \phpbbgallery\core\config
-	*/
+	 * @var \phpbbgallery\core\config
+	 */
 	protected $gallery_config;
 
 	/**
-	* @var \phpbbgallery\core\auth\auth
-	*/
+	 * @var \phpbbgallery\core\auth\auth
+	 */
 	protected $gallery_auth;
 
 	/**
-	* @var string
-	*/
+	 * @var string
+	 */
 	protected $images_table;
 
 	/**
-	* @var string
-	*/
+	 * @var string
+	 */
 	protected $albums_table;
 
 	/**
-	* @var string
-	*/
+	 * @var string
+	 */
 	protected $rates_table;
 
 	/**
-	* The image ID we want to rate
-	*/
+	 * The image ID we want to rate
+	 */
 	public $image_id = 0;
 
 	/**
-	* Private objects with the values for the image/album from the database
-	*/
+	 * Private objects with the values for the image/album from the database
+	 */
 	private $image_data = null;
 	private $album_data = null;
 
 	/**
-	* Rating the user gave the image.
-	*/
+	 * Rating the user gave the image.
+	 */
 	public $user_rating = null;
 
 	/**
-	* Is rating currently possible?
-	* Might be blocked because of contest-settings.
-	*/
+	 * Is rating currently possible?
+	 * Might be blocked because of contest-settings.
+	 */
 	public $rating_enabled = false;
 
 	/**
-	* Classic-rating box with a dropdown.
-	*/
+	 * Classic-rating box with a dropdown.
+	 */
 	const MODE_SELECT = 1;
 
 	/**
-	* Rating with stars, like the old-system from youtube.
+	 * Rating with stars, like the old-system from youtube.
 	//@todo: const MODE_STARS = 2;
-	*/
+	 */
 
 	/**
-	* Simple thumbs up or down.
+	 * Simple thumbs up or down.
 	//@todo: const MODE_THUMB = 3;
-	*/
+	 */
 
 	/**
 	 * Constructor
@@ -204,8 +204,8 @@ 
 	}
 
 	/**
-	* Displays the box where the user can rate the image.
-	*/
+	 * Displays the box where the user can rate the image.
+	 */
 	public function display_box()
 	{
 		$this->template->assign_var('GALLERY_RATING', self::MODE_SELECT);//@todo: phpbb_ext_gallery_core_config::get('rating_mode'));
@@ -280,8 +280,8 @@ 
 	}
 
 	/**
-	* Get rated value for a image
-	*/
+	 * Get rated value for a image
+	 */
 	private function get_image_rating_value()
 	{
 		/*if (phpbb_ext_gallery_core_contest::$mode == phpbb_ext_gallery_core_contest::MODE_SUM)
@@ -295,14 +295,14 @@ 
 	}
 
 	/**
-	* Is the user allowed to rate?
-	* Following statements must be true:
-	*	- User must have permissions.
-	*	- User is neither owner of the image nor guest.
-	*	- Album and image are not locked.
-	*
-	* @return	bool
-	*/
+	 * Is the user allowed to rate?
+	 * Following statements must be true:
+	 *	- User must have permissions.
+	 *	- User is neither owner of the image nor guest.
+	 *	- Album and image are not locked.
+	 *
+	 * @return	bool
+	 */
 	public function is_allowed()
 	{
 		return $this->gallery_auth->acl_check('i_rate', $this->album_data('album_id'), $this->album_data('album_user_id')) &&
@@ -311,25 +311,25 @@ 
 	}
 
 	/**
-	* Is the user able to rate?
-	* Following statements must be true:
-	*	- User must be allowed to rate
-	*	- If the image is in a contest, it must be in the rating timespan
-	*
-	* @return	bool
-	*/
+	 * Is the user able to rate?
+	 * Following statements must be true:
+	 *	- User must be allowed to rate
+	 *	- If the image is in a contest, it must be in the rating timespan
+	 *
+	 * @return	bool
+	 */
 	public function is_able()
 	{
 		return $this->is_allowed(); //&& phpbb_ext_gallery_core_contest::is_step('rate', $this->album_data(true));
 	}
 
 	/**
-	* Get rating from a user for a given image
-	*
-	* @param	int		$user_id
-	*
-	* @return	mixed	False if the user did not rate or is guest, otherwise int the points.
-	*/
+	 * Get rating from a user for a given image
+	 *
+	 * @param	int		$user_id
+	 *
+	 * @return	mixed	False if the user did not rate or is guest, otherwise int the points.
+	 */
 	public function get_user_rating($user_id)
 	{
 		if (isset($this->user_rating[$user_id]))
@@ -405,10 +405,10 @@ 
 	}
 
 	/**
-	* Recalculate the average image-rating and such stuff.
-	*
-	* @param	mixed	$image_ids	Array or integer with image_id where we recalculate the rating.
-	*/
+	 * Recalculate the average image-rating and such stuff.
+	 *
+	 * @param	mixed	$image_ids	Array or integer with image_id where we recalculate the rating.
+	 */
 	public function recalc_image_rating($image_ids)
 	{
 		if (is_array($image_ids))
@@ -439,11 +439,11 @@ 
 	}
 
 	/**
-	* Delete all ratings for given image_ids
-	*
-	* @param	mixed	$image_ids		Array or integer with image_id where we delete the rating.
-	* @param	bool	$reset_average	Shall we also reset the average? We can save that query, when the images are deleted anyway.
-	*/
+	 * Delete all ratings for given image_ids
+	 *
+	 * @param	mixed	$image_ids		Array or integer with image_id where we delete the rating.
+	 * @param	bool	$reset_average	Shall we also reset the average? We can save that query, when the images are deleted anyway.
+	 */
 	public function delete_ratings($image_ids, $reset_average = false)
 	{
 		if (is_array($image_ids))

core/block.php

Spacing +8 added lines, -8 removed lines

@@ -23,13 +23,13 @@ 
 	 *
 	 * Constants defining some album properties
 	 */
-	const PUBLIC_ALBUM		= 0;
+	const PUBLIC_ALBUM = 0;
 
-	const TYPE_CAT			= 0;
-	const TYPE_UPLOAD		= 1;
+	const TYPE_CAT = 0;
+	const TYPE_UPLOAD = 1;
 	const TYPE_CONTEST		= 2;
 
-	const ALBUM_OPEN		= 0;
+	const ALBUM_OPEN = 0;
 	const ALBUM_LOCKED		= 1;
 
 	/**
@@ -58,22 +58,22 @@ 
 	/**
 	 * Only visible for moderators.
 	 */
-	const STATUS_UNAPPROVED	= 0;
+	const STATUS_UNAPPROVED = 0;
 
 	/**
 	 * Visible for everyone with the i_view-permissions
 	 */
-	const STATUS_APPROVED	= 1;
+	const STATUS_APPROVED = 1;
 
 	/**
 	 * Visible for everyone with the i_view-permissions, but only moderators can comment.
 	 */
-	const STATUS_LOCKED		= 2;
+	const STATUS_LOCKED = 2;
 
 	/**
 	 * Orphan files are only visible for their author, because they're not yet ready uploaded.
 	 */
-	const STATUS_ORPHAN		= 3;
+	const STATUS_ORPHAN = 3;
 
 	/**
 	 * Constants regarding the image contest relation

core/controller/file.php

Spacing +1 added lines, -1 removed lines

@@ -316,7 +316,7 @@
 
 	public function generate_image_src()
 	{
-		$this->image_src = $this->path  . $this->data['image_filename'];
+		$this->image_src = $this->path . $this->data['image_filename'];
 
 		if ($this->data['image_filemissing'] || !file_exists($this->path_source . $this->data['image_filename']))
 		{

Indentation +23 added lines, -23 removed lines

@@ -104,12 +104,12 @@ 
 	}
 
 	/**
-	* Image File Controller
-	*	Route: gallery/image/{image_id}/source
-	*
-	* @param	int		$image_id
-	* @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
-	*/
+	 * Image File Controller
+	 *	Route: gallery/image/{image_id}/source
+	 *
+	 * @param	int		$image_id
+	 * @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
+	 */
 	public function source($image_id)
 	{
 		$this->auth->load_user_permissions($this->user->data['user_id']);
@@ -160,12 +160,12 @@ 
 	}
 
 	/**
-	* Image File Controller
-	*	Route: gallery/image/{image_id}/medium
-	*
-	* @param	int		$image_id
-	* @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
-	*/
+	 * Image File Controller
+	 *	Route: gallery/image/{image_id}/medium
+	 *
+	 * @param	int		$image_id
+	 * @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
+	 */
 	public function medium($image_id)
 	{
 
@@ -195,12 +195,12 @@ 
 	}
 
 	/**
-	* Image File Controller
-	*	Route: gallery/image/{image_id}/mini
-	*
-	* @param	int		$image_id
-	* @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
-	*/
+	 * Image File Controller
+	 *	Route: gallery/image/{image_id}/mini
+	 *
+	 * @param	int		$image_id
+	 * @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
+	 */
 	public function mini($image_id)
 	{
 		$this->path = $this->path_mini;
@@ -356,11 +356,11 @@ 
 	}
 
 	/**
-	* Image File Controller
-	*	Route: gallery/image/{image_id}/x
-	*
-	* @return \Symfony\Component\HttpFoundation\BinaryFileResponseResponse A Symfony Response object
-	*/
+	 * Image File Controller
+	 *	Route: gallery/image/{image_id}/x
+	 *
+	 * @return \Symfony\Component\HttpFoundation\BinaryFileResponseResponse A Symfony Response object
+	 */
 	public function display()
 	{
 		$this->tool->set_last_modified($this->gallery_user->get_data('user_permissions_changed'));

Braces +2 added lines, -4 removed lines

@@ -238,8 +238,7 @@ 
 			$this->data['album_user_id'] = 1;
 			$this->data['image_filemissing'] = 0;
 			$this->data['album_watermark'] = 0;
-		}
-		else
+		} else
 		{
 			$sql = 'SELECT *
 				FROM ' . $this->table_images . ' i
@@ -409,8 +408,7 @@ 
 			{
 				$response->headers->set('expires', '-1');
 			}
-		}
-		else
+		} else
 		{
 			$response->headers->set('Content-Disposition', 'inline; ' . $this->tool->header_filename(htmlspecialchars_decode($this->tool->image_name) . '.' . $this->tool->image_type));
 			if ($this->tool->is_ie_greater7($this->user->browser))

core/controller/upload.php

Braces +6 added lines, -12 removed lines

@@ -249,8 +249,7 @@ 
 					'last_image'	=> end($process->images),
 				);
 				$this->notification_helper->new_image($data);
-			}
-			else
+			} else
 			{
 				$target = array(
 					'album_id'	=>	$album_id,
@@ -355,8 +354,7 @@ 
 					{
 						$this->language->add_lang('ucp');
 						$error_array[] = $this->language->lang($result . '_USERNAME');
-					}
-					else
+					} else
 					{
 						$process->set_username($username);
 					}
@@ -375,8 +373,7 @@ 
 				if (!$process->uploaded_files)
 				{
 					$process->new_error($this->language->lang('UPLOAD_NO_FILE'));
-				}
-				else
+				} else
 				{
 					$mode = 'upload_edit';
 					// Remove submit, so we get the first screen of step 2.
@@ -422,8 +419,7 @@ 
 						if ($VAR == 'zip')
 						{
 							continue;
-						}
-						else
+						} else
 						{
 							$filetypes[] = $VAR;
 						}
@@ -523,8 +519,7 @@ 
 						'last_image'	=> end($process->images),
 					);
 					$this->notification_helper->new_image($data);
-				}
-				else
+				} else
 				{
 					$target = array(
 						'album_id'	=>	(int) $album_id,
@@ -591,8 +586,7 @@ 
 		if (file_exists($phpbbgallery_core_file) && is_writable($phpbbgallery_core_file) && file_exists($phpbbgallery_core_file_source) && is_writable($phpbbgallery_core_file_source) && file_exists($phpbbgallery_core_file_medium) && is_writable($phpbbgallery_core_file_medium) && file_exists($phpbbgallery_core_file_mini) && is_writable($phpbbgallery_core_file_mini))
 		{
 			return true;
-		}
-		else
+		} else
 		{
 			return false;
 		}

core/controller/search.php

Indentation +7 added lines, -7 removed lines

@@ -165,8 +165,8 @@ 
 		$this->language->add_lang(array('gallery'), 'phpbbgallery/core');
 		$this->language->add_lang('search');
 		/**
-		* Build the sort options
-		*/
+		 * Build the sort options
+		 */
 		$limit_days = array(0 => $this->language->lang('ALL_IMAGES'), 1 => $this->language->lang('1_DAY'), 7 => $this->language->lang('7_DAYS'), 14 => $this->language->lang('2_WEEKS'), 30 => $this->language->lang('1_MONTH'), 90 => $this->language->lang('3_MONTHS'), 180 => $this->language->lang('6_MONTHS'), 365 => $this->language->lang('1_YEAR'));
 		$sort_by_text = array('t' => $this->language->lang('TIME'), 'n' => $this->language->lang('IMAGE_NAME'), 'u' => $this->language->lang('SORT_USERNAME'), 'vc' => $this->language->lang('GALLERY_VIEWS'));
 		$sort_by_sql = array('t' => 'image_time', 'n' => 'image_name_clean', 'u' => 'image_username_clean', 'vc' => 'image_view_count');
@@ -369,11 +369,11 @@ 
 	}
 
 	/**
-	* Index Controller
-	*	Route: gallery/search/random
-	*
-	* @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
-	*/
+	 * Index Controller
+	 *	Route: gallery/search/random
+	 *
+	 * @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
+	 */
 	public function random()
 	{
 		$this->language->add_lang(array('gallery'), 'phpbbgallery/core');

Braces +2 added lines, -4 removed lines

@@ -232,8 +232,7 @@ 
 				if ($search_terms == 'all')
 				{
 					$keywords .= ' ' . $add_keywords;
-				}
-				else
+				} else
 				{
 					$search_terms = 'all';
 					$keywords = preg_replace('#\s+#u', ' |', $keywords) . ' ' .$add_keywords;
@@ -271,8 +270,7 @@ 
 			if (empty($search_album))
 			{
 				$sql_where[] = $this->db->sql_in_set('i.image_album_id', $this->gallery_auth->acl_album_ids('i_view'));
-			}
-			else
+			} else
 			{
 				$sql_where[] = $this->db->sql_in_set('i.image_album_id', $search_album);
 			}

Spacing +12 added lines, -12 removed lines

@@ -141,10 +141,10 @@ 
 
 	public function base($page = 1)
 	{
-		$search_id		= $this->request->variable('search_id', '');
+		$search_id = $this->request->variable('search_id', '');
 		$image_id		= $this->request->variable('image_id', 0);
 
-		$submit			= $this->request->variable('submit', false);
+		$submit = $this->request->variable('submit', false);
 		$keywords		= utf8_normalize_nfc($this->request->variable('keywords', '', true));
 		$add_keywords	= utf8_normalize_nfc($this->request->variable('add_keywords', '', true));
 		$username		= $this->request->variable('username', '', true);
@@ -152,13 +152,13 @@ 
 		$search_terms	= $this->request->variable('terms', 'all');
 		$search_album	= $this->request->variable('aid', array(0));
 		$search_child	= $this->request->variable('sc', true);
-		$search_fields	= $this->request->variable('sf', 'all');
-		$sort_days		= $this->request->variable('st', 0);
+		$search_fields = $this->request->variable('sf', 'all');
+		$sort_days = $this->request->variable('st', 0);
 		$sort_key		= $this->request->variable('sk', 't');
 		$sort_dir		= $this->request->variable('sd', 'd');
 		$filtered		= $this->request->variable('filtered', false);
 
-		$start 			= ($page - 1) * $this->gallery_config->get('items_per_page');
+		$start = ($page - 1) * $this->gallery_config->get('items_per_page');
 		if ($filtered)
 		{
 			$submit = true;
@@ -175,7 +175,7 @@ 
 		if ($this->gallery_config->get('allow_rates'))
 		{
 			$sort_by_text['ra'] = $this->language->lang('RATING');
-			$sort_by_sql['ra'] = 'image_rate_points';//@todo: (phpbb_gallery_contest::$mode == phpbb_gallery_contest::MODE_SUM) ? 'image_rate_points' : 'image_rate_avg';
+			$sort_by_sql['ra'] = 'image_rate_points'; //@todo: (phpbb_gallery_contest::$mode == phpbb_gallery_contest::MODE_SUM) ? 'image_rate_points' : 'image_rate_avg';
 			$sort_by_text['r'] = $this->language->lang('RATES_COUNT');
 			$sort_by_sql['r'] = 'image_rates';
 		}
@@ -206,7 +206,7 @@ 
 				{
 					trigger_error(sprintf($this->language->lang('TOO_FEW_AUTHOR_CHARS'), $this->config['min_search_author_chars']));
 				}
-				$username_parsed = (strpos($username, '*') !== false) ? ' username_clean ' . $this->db->sql_like_expression(str_replace('*', $this->db->get_any_char(), utf8_clean_string($this->db->sql_escape($username)))) : ' username_clean = \'' . $this->db->sql_escape(utf8_clean_string($username)) .'\'';
+				$username_parsed = (strpos($username, '*') !== false) ? ' username_clean ' . $this->db->sql_like_expression(str_replace('*', $this->db->get_any_char(), utf8_clean_string($this->db->sql_escape($username)))) : ' username_clean = \'' . $this->db->sql_escape(utf8_clean_string($username)) . '\'';
 				$sql = 'SELECT user_id
 					FROM ' . USERS_TABLE . '
 					WHERE ' . $username_parsed . '
@@ -224,7 +224,7 @@ 
 
 			if (!empty($user_id))
 			{
-				$sql_where[] =  $this->db->sql_in_set('i.image_user_id', $user_id);
+				$sql_where[] = $this->db->sql_in_set('i.image_user_id', $user_id);
 			}
 			// if we search in an existing search result just add the additional keywords. But we need to use "all search terms"-mode
 			// so we can keep the old keywords in their old mode, but add the new ones as required words
@@ -237,7 +237,7 @@ 
 				else
 				{
 					$search_terms = 'all';
-					$keywords = preg_replace('#\s+#u', ' |', $keywords) . ' ' .$add_keywords;
+					$keywords = preg_replace('#\s+#u', ' |', $keywords) . ' ' . $add_keywords;
 				}
 			}
 			$keywords_ary = ($keywords) ? explode(' ', $keywords) : array();
@@ -262,7 +262,7 @@ 
 				$match_search_query = '';
 				foreach ($matches as $match)
 				{
-					$match_search_query .= (($match_search_query) ? ' OR ' : '') . 'LOWER('. $match . ') ';
+					$match_search_query .= (($match_search_query) ? ' OR ' : '') . 'LOWER(' . $match . ') ';
 					$match_search_query .= $this->db->sql_like_expression(str_replace('*', $this->db->get_any_char(), $this->db->get_any_char() . mb_strtolower($word) . $this->db->get_any_char()));
 				}
 				$search_query .= ((!$search_query) ? '' : (($search_terms == 'all') ? ' AND ' : ' OR ')) . '(' . $match_search_query . ')';
@@ -291,7 +291,7 @@ 
 				trigger_error('NO_SEARCH_RESULTS');
 			}
 			$sql_array['SELECT'] = '*, a.album_name, a.album_status, a.album_user_id, a.album_id';
-			$sql_array['LEFT_JOIN']	= array(
+			$sql_array['LEFT_JOIN'] = array(
 				array(
 					'FROM'		=> array($this->albums_table => 'a'),
 					'ON'		=> 'a.album_id = i.image_album_id',
@@ -319,7 +319,7 @@ 
 			{
 				$this->image->assign_block('imageblock.image', $row, $show_options, $thumbnail_link, $imagename_link);
 			}
-			$current_page = $page*$this->gallery_config->get('items_per_page');
+			$current_page = $page * $this->gallery_config->get('items_per_page');
 			$this->pagination->generate_template_pagination(array(
 				'routes' => array(
 					'phpbbgallery_core_search',