Completed
Push — development ( b15f63...e85e87 )
by Claudio
02:46
created
app/Http/Controllers/AccountController.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -229,7 +229,7 @@
 block discarded – undo
229 229
 
230 230
         DB::table('users')->where('mail', $mailRequest->mail)->update(['mail_verified' => 1]);
231 231
 
232
-        if($request->user() !== null)
232
+        if ($request->user() !== null)
233 233
             $request->user()->mailVerified = true;
234 234
 
235 235
         return response()->json(['email' => $mailRequest->mail, 'emailVerified' => true, 'identityVerified' => true]);
Please login to merge, or discard this patch.
Braces   +21 added lines, -14 removed lines patch added patch discarded remove patch
@@ -27,8 +27,9 @@  discard block
 block discarded – undo
27 27
      */
28 28
     public function checkName(Request $request): JsonResponse
29 29
     {
30
-        if (User::where('username', $request->json()->get('name'))->count() > 0)
31
-            return response()->json(['code' => 'NAME_IN_USE', 'validationResult' => null, 'suggestions' => []]);
30
+        if (User::where('username', $request->json()->get('name'))->count() > 0) {
31
+                    return response()->json(['code' => 'NAME_IN_USE', 'validationResult' => null, 'suggestions' => []]);
32
+        }
32 33
 
33 34
         return response()->json(['code' => 'OK', 'validationResult' => null, 'suggestions' => []]);
34 35
     }
@@ -76,8 +77,9 @@  discard block
 block discarded – undo
76 77
      */
77 78
     public function selectRoom(Request $request): JsonResponse
78 79
     {
79
-        if (!in_array($request->json()->get('roomIndex'), [1, 2, 3]))
80
-            return response('', 400);
80
+        if (!in_array($request->json()->get('roomIndex'), [1, 2, 3])) {
81
+                    return response('', 400);
82
+        }
81 83
 
82 84
         $request->user()->traits = ["USER"];
83 85
 
@@ -107,8 +109,9 @@  discard block
 block discarded – undo
107 109
     {
108 110
         $userPreferences = UserPreferences::find($request->user()->uniqueId);
109 111
 
110
-        foreach ($userPreferences->getAttributes() as $attributeName => $attributeValue)
111
-            $userPreferences->{$attributeName} = $attributeValue == 1;
112
+        foreach ($userPreferences->getAttributes() as $attributeName => $attributeValue) {
113
+                    $userPreferences->{$attributeName} = $attributeValue == 1;
114
+        }
112 115
 
113 116
         return response()->json($userPreferences);
114 117
     }
@@ -154,8 +157,9 @@  discard block
 block discarded – undo
154 157
      */
155 158
     public function checkNewName(Request $request): JsonResponse
156 159
     {
157
-        if (User::where('username', $request->input('name'))->count() > 0)
158
-            return response()->json(['isAvailable' => false]);
160
+        if (User::where('username', $request->input('name'))->count() > 0) {
161
+                    return response()->json(['isAvailable' => false]);
162
+        }
159 163
 
160 164
         return response()->json(['isAvailable' => true]);
161 165
     }
@@ -168,8 +172,9 @@  discard block
 block discarded – undo
168 172
      */
169 173
     public function createAvatar(Request $request): JsonResponse
170 174
     {
171
-        if (User::where('username', $request->json()->get('name'))->count() > 0)
172
-            return response()->json(['isAvailable' => false]);
175
+        if (User::where('username', $request->json()->get('name'))->count() > 0) {
176
+                    return response()->json(['isAvailable' => false]);
177
+        }
173 178
 
174 179
         $request->user()->name = $request->json()->get('name');
175 180
 
@@ -222,15 +227,17 @@  discard block
 block discarded – undo
222 227
     {
223 228
         $mailRequest = Mail::where('token', $request->json()->get('token'))->where('used', '0')->first();
224 229
 
225
-        if ($mailRequest == null)
226
-            return response()->json(['error' => 'activation.invalid_token'], 400);
230
+        if ($mailRequest == null) {
231
+                    return response()->json(['error' => 'activation.invalid_token'], 400);
232
+        }
227 233
 
228 234
         $mailRequest->update(['used' => '1']);
229 235
 
230 236
         DB::table('users')->where('mail', $mailRequest->mail)->update(['mail_verified' => 1]);
231 237
 
232
-        if($request->user() !== null)
233
-            $request->user()->mailVerified = true;
238
+        if($request->user() !== null) {
239
+                    $request->user()->mailVerified = true;
240
+        }
234 241
 
235 242
         return response()->json(['email' => $mailRequest->mail, 'emailVerified' => true, 'identityVerified' => true]);
236 243
     }
Please login to merge, or discard this patch.
app/Http/Controllers/AccountSecurityController.php 1 patch
Braces   +33 added lines, -22 removed lines patch added patch discarded remove patch
@@ -29,8 +29,9 @@  discard block
 block discarded – undo
29 29
      */
30 30
     public function featureStatus(Request $request): Response
31 31
     {
32
-        if ($request->user()->emailVerified == false)
33
-            return response('identity_verification_required', 200);
32
+        if ($request->user()->emailVerified == false) {
33
+                    return response('identity_verification_required', 200);
34
+        }
34 35
 
35 36
         $featureEnabled = UserSecurity::find($request->user()->uniqueId);
36 37
 
@@ -45,8 +46,9 @@  discard block
 block discarded – undo
45 46
      */
46 47
     public function saveQuestions(Request $request): JsonResponse
47 48
     {
48
-        if (User::where('password', hash('sha256', $request->json()->get('password')))->count() == 0)
49
-            return response()->json(['error' => 'invalid_password'], 400);
49
+        if (User::where('password', hash('sha256', $request->json()->get('password')))->count() == 0) {
50
+                    return response()->json(['error' => 'invalid_password'], 400);
51
+        }
50 52
 
51 53
         UserSecurity::updateOrCreate([
52 54
             'user_id' => $request->user()->uniqueId,
@@ -94,12 +96,14 @@  discard block
 block discarded – undo
94 96
      */
95 97
     public function changePassword(Request $request): JsonResponse
96 98
     {
97
-        if (strlen($request->json()->get('password')) < 6)
98
-            return response()->json(['error' => 'password.current_password.invalid'], 409);
99
+        if (strlen($request->json()->get('password')) < 6) {
100
+                    return response()->json(['error' => 'password.current_password.invalid'], 409);
101
+        }
99 102
 
100 103
         //@TODO: This search the whole base. If anyone has the same password.. This will give error. Is this good?
101
-        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() >= 1)
102
-            return response()->json(['error' => 'password.used_earlier'], 409);
104
+        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() >= 1) {
105
+                    return response()->json(['error' => 'password.used_earlier'], 409);
106
+        }
103 107
 
104 108
         User::find($request->user()->uniqueId)->update(['password' => hash('sha256', $request->json()->get('password'))]);
105 109
 
@@ -117,14 +121,17 @@  discard block
 block discarded – undo
117 121
      */
118 122
     public function changeMail(Request $request): JsonResponse
119 123
     {
120
-        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() == 0)
121
-            return response()->json(['error' => 'changeEmail.invalid_password'], 400);
124
+        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() == 0) {
125
+                    return response()->json(['error' => 'changeEmail.invalid_password'], 400);
126
+        }
122 127
 
123
-        if (strpos($request->json()->get('newEmail'), '@') == false)
124
-            return response()->json(['error' => 'registration_email'], 400);
128
+        if (strpos($request->json()->get('newEmail'), '@') == false) {
129
+                    return response()->json(['error' => 'registration_email'], 400);
130
+        }
125 131
 
126
-        if (ChocolateyId::where('mail', $request->json()->get('newEmail'))->count() > 0)
127
-            return response()->json(['error' => 'changeEmail.email_already_in_use'], 400);
132
+        if (ChocolateyId::where('mail', $request->json()->get('newEmail'))->count() > 0) {
133
+                    return response()->json(['error' => 'changeEmail.email_already_in_use'], 400);
134
+        }
128 135
 
129 136
         // @TODO: In the future the e-mail only will be changed after e-mail confirmation
130 137
         $request->user()->update(['mail' => $request->json()->get('newEmail')]);
@@ -142,8 +149,9 @@  discard block
 block discarded – undo
142 149
      */
143 150
     public function getQuestions(Request $request): JsonResponse
144 151
     {
145
-        if (UserSecurity::find($request->user()->uniqueId) == null)
146
-            return response()->json('');
152
+        if (UserSecurity::find($request->user()->uniqueId) == null) {
153
+                    return response()->json('');
154
+        }
147 155
 
148 156
         $userSecurity = UserSecurity::find($request->user()->uniqueId);
149 157
 
@@ -170,8 +178,9 @@  discard block
 block discarded – undo
170 178
                 ->where('firstAnswer', $request->json()->get('answer1'))
171 179
                 ->where('secondAnswer', $request->json()->get('answer2'))->count() > 0
172 180
         ):
173
-            if ($request->json()->get('trust') == true)
174
-                (new TrustedDevice)->store($request->user()->uniqueId, $request->ip())->save();
181
+            if ($request->json()->get('trust') == true) {
182
+                            (new TrustedDevice)->store($request->user()->uniqueId, $request->ip())->save();
183
+            }
175 184
 
176 185
             return response()->json('', 204);
177 186
         endif;
@@ -189,13 +198,15 @@  discard block
 block discarded – undo
189 198
     {
190 199
         $mailRequest = Mail::where('token', $request->json()->get('token'))->where('used', '0')->first();
191 200
 
192
-        if ($mailRequest == null)
193
-            return response()->json('', 404);
201
+        if ($mailRequest == null) {
202
+                    return response()->json('', 404);
203
+        }
194 204
 
195 205
         if (User::where('mail', $mailRequest->mail)
196 206
                 ->where('password', hash('sha256', $request->json()->get('password')))->count() >= 1
197
-        )
198
-            return response()->json(['error' => 'password.used_earlier'], 400);
207
+        ) {
208
+                    return response()->json(['error' => 'password.used_earlier'], 400);
209
+        }
199 210
 
200 211
         $mailRequest->update(['used' => '1']);
201 212
 
Please login to merge, or discard this patch.