Completed
Pull Request — development (#288)
by Claudio
07:22 queued 05:08
created
app/Providers/AppServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
     public function register()
15 15
     {
16 16
         // Register Mailing Services
17
-        $this->app->singleton('mailer', function ($app) {
17
+        $this->app->singleton('mailer', function($app) {
18 18
             return $app->loadComponent('mail', 'Illuminate\Mail\MailServiceProvider', 'mailer');
19 19
         });
20 20
     }
Please login to merge, or discard this patch.
app/Providers/SessionServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
      */
19 19
     public function register()
20 20
     {
21
-        $this->app->bind('chocosession', function () {
21
+        $this->app->bind('chocosession', function() {
22 22
             return Session::getInstance();
23 23
         });
24 24
 
Please login to merge, or discard this patch.
app/Providers/NuxServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
      */
19 19
     public function register()
20 20
     {
21
-        $this->app->bind('choconux', function () {
21
+        $this->app->bind('choconux', function() {
22 22
             return Nux::getInstance();
23 23
         });
24 24
     }
Please login to merge, or discard this patch.
app/Http/Middleware/Maintenance.php 2 patches
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
      */
22 22
     public function handle($request, Closure $next)
23 23
     {
24
-        return Config::get('maintenance.enforce') ? response()->json(['error' => 'maintenance'], 503) :
25
-            $next($request);
24
+        return Config::get('maintenance.enforce') ? response()->json(['error' => 'maintenance'], 503) : $next($request);
26 25
     }
27 26
 }
Please login to merge, or discard this patch.
Switch Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@  discard block
 block discarded – undo
1
-<?php
1
+ <?php
2 2
 
3
-namespace App\Http\Middleware;
3
+ namespace App\Http\Middleware;
4 4
 
5
-use Closure;
6
-use Illuminate\Http\Request;
7
-use Illuminate\Support\Facades\Config;
5
+ use Closure;
6
+ use Illuminate\Http\Request;
7
+ use Illuminate\Support\Facades\Config;
8 8
 
9 9
 /**
10 10
  * Class Maintenance.
11 11
  */
12
-class Maintenance
13
-{
14
-    /**
12
+ class Maintenance
13
+ {
14
+     /**
15 15
      * Handle an incoming request.
16 16
      *
17 17
      * @param Request $request
@@ -19,9 +19,9 @@  discard block
 block discarded – undo
19 19
      *
20 20
      * @return mixed
21 21
      */
22
-    public function handle($request, Closure $next)
23
-    {
24
-        return Config::get('maintenance.enforce') ? response()->json(['error' => 'maintenance'], 503) :
25
-            $next($request);
26
-    }
22
+     public function handle($request, Closure $next)
23
+     {
24
+         return Config::get('maintenance.enforce') ? response()->json(['error' => 'maintenance'], 503) :
25
+             $next($request);
26
+     }
27 27
 }
Please login to merge, or discard this patch.
app/Models/Room.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
      */
168 168
     public function getTagsAttribute(): array
169 169
     {
170
-        return array_filter(explode(';', $this->attributes['tags']), function ($element) {
170
+        return array_filter(explode(';', $this->attributes['tags']), function($element) {
171 171
             return !empty($element);
172 172
         });
173 173
     }
Please login to merge, or discard this patch.
app/Providers/UserServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
      */
19 19
     public function register()
20 20
     {
21
-        $this->app->bind('chocouser', function () {
21
+        $this->app->bind('chocouser', function() {
22 22
             return User::getInstance();
23 23
         });
24 24
     }
Please login to merge, or discard this patch.
app/Providers/MailServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
      */
19 19
     public function register()
20 20
     {
21
-        $this->app->bind('chocomail', function () {
21
+        $this->app->bind('chocomail', function() {
22 22
             return Mail::getInstance();
23 23
         });
24 24
     }
Please login to merge, or discard this patch.
app/Http/Controllers/AccountSecurityController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@
 block discarded – undo
200 200
      *
201 201
      * @param Request $request
202 202
      *
203
-     * @return mixed
203
+     * @return JsonResponse
204 204
      */
205 205
     public function confirmChangePassword(Request $request): JsonResponse
206 206
     {
Please login to merge, or discard this patch.
Switch Indentation   +139 added lines, -139 removed lines patch added patch discarded remove patch
@@ -1,89 +1,89 @@  discard block
 block discarded – undo
1
-<?php
2
-
3
-namespace App\Http\Controllers;
4
-
5
-use App\Facades\Mail;
6
-use App\Facades\User as UserFacade;
7
-use App\Models\ChocolateyId;
8
-use App\Models\Question;
9
-use App\Models\TrustedDevice;
10
-use App\Models\User;
11
-use App\Models\UserSecurity;
12
-use Illuminate\Http\JsonResponse;
13
-use Illuminate\Http\Request;
14
-use Illuminate\Http\Response;
15
-use Illuminate\Support\Facades\Config;
16
-use Laravel\Lumen\Routing\Controller as BaseController;
1
+ <?php
2
+
3
+ namespace App\Http\Controllers;
4
+
5
+ use App\Facades\Mail;
6
+ use App\Facades\User as UserFacade;
7
+ use App\Models\ChocolateyId;
8
+ use App\Models\Question;
9
+ use App\Models\TrustedDevice;
10
+ use App\Models\User;
11
+ use App\Models\UserSecurity;
12
+ use Illuminate\Http\JsonResponse;
13
+ use Illuminate\Http\Request;
14
+ use Illuminate\Http\Response;
15
+ use Illuminate\Support\Facades\Config;
16
+ use Laravel\Lumen\Routing\Controller as BaseController;
17 17
 
18 18
 /**
19 19
  * Class AccountSecurityController.
20 20
  */
21
-class AccountSecurityController extends BaseController
22
-{
23
-    /**
21
+ class AccountSecurityController extends BaseController
22
+ {
23
+     /**
24 24
      * Check if Feature Status is Enabled.
25 25
      *
26 26
      * @return Response
27 27
      */
28
-    public function featureStatus(): Response
29
-    {
30
-        if (UserFacade::getUser()->emailVerified == false) {
31
-            return response('identity_verification_required', 200);
32
-        }
28
+     public function featureStatus(): Response
29
+     {
30
+         if (UserFacade::getUser()->emailVerified == false) {
31
+             return response('identity_verification_required', 200);
32
+         }
33 33
 
34
-        $featureEnabled = UserSecurity::find(UserFacade::getUser()->uniqueId);
34
+         $featureEnabled = UserSecurity::find(UserFacade::getUser()->uniqueId);
35 35
 
36
-        return response($featureEnabled !== null ? 'enabled' : 'disabled', 200);
37
-    }
36
+         return response($featureEnabled !== null ? 'enabled' : 'disabled', 200);
37
+     }
38 38
 
39
-    /**
39
+     /**
40 40
      * Save Security Questions.
41 41
      *
42 42
      * @param Request $request
43 43
      *
44 44
      * @return JsonResponse
45 45
      */
46
-    public function saveQuestions(Request $request): JsonResponse
47
-    {
48
-        if (UserFacade::getUser()->getChocolateyId()->password != hash(Config::get('chocolatey.security.hash'), $request->json()->get('password'))) {
49
-            return response()->json(['error' => 'invalid_password'], 400);
50
-        }
51
-
52
-        UserSecurity::updateOrCreate([
53
-            'user_id'        => UserFacade::getUser()->uniqueId,
54
-            'firstQuestion'  => $request->json()->get('questionId1'),
55
-            'secondQuestion' => $request->json()->get('questionId2'),
56
-            'firstAnswer'    => $request->json()->get('answer1'),
57
-            'secondAnswer'   => $request->json()->get('answer2'), ]);
58
-
59
-        return response()->json(null, 204);
60
-    }
61
-
62
-    /**
46
+     public function saveQuestions(Request $request): JsonResponse
47
+     {
48
+         if (UserFacade::getUser()->getChocolateyId()->password != hash(Config::get('chocolatey.security.hash'), $request->json()->get('password'))) {
49
+             return response()->json(['error' => 'invalid_password'], 400);
50
+         }
51
+
52
+         UserSecurity::updateOrCreate([
53
+             'user_id'        => UserFacade::getUser()->uniqueId,
54
+             'firstQuestion'  => $request->json()->get('questionId1'),
55
+             'secondQuestion' => $request->json()->get('questionId2'),
56
+             'firstAnswer'    => $request->json()->get('answer1'),
57
+             'secondAnswer'   => $request->json()->get('answer2'), ]);
58
+
59
+         return response()->json(null, 204);
60
+     }
61
+
62
+     /**
63 63
      * Disable Safety Lock.
64 64
      *
65 65
      * @return JsonResponse
66 66
      */
67
-    public function disable(): JsonResponse
68
-    {
69
-        UserSecurity::find(UserFacade::getUser()->uniqueId)->delete();
67
+     public function disable(): JsonResponse
68
+     {
69
+         UserSecurity::find(UserFacade::getUser()->uniqueId)->delete();
70 70
 
71
-        return response()->json(null, 204);
72
-    }
71
+         return response()->json(null, 204);
72
+     }
73 73
 
74
-    /**
74
+     /**
75 75
      * Reset Trusted Devices.
76 76
      *
77 77
      * @return JsonResponse
78 78
      */
79
-    public function reset(): JsonResponse
80
-    {
81
-        TrustedDevice::find(UserFacade::getUser()->uniqueId)->delete();
79
+     public function reset(): JsonResponse
80
+     {
81
+         TrustedDevice::find(UserFacade::getUser()->uniqueId)->delete();
82 82
 
83
-        return response()->json(null, 204);
84
-    }
83
+         return response()->json(null, 204);
84
+     }
85 85
 
86
-    /**
86
+     /**
87 87
      * Change User Password.
88 88
      *
89 89
      * @TODO: Implement Notification E-mail of Password change
@@ -92,139 +92,139 @@  discard block
 block discarded – undo
92 92
      *
93 93
      * @return JsonResponse
94 94
      */
95
-    public function changePassword(Request $request): JsonResponse
96
-    {
97
-        UserFacade::getUser()->getChocolateyId()->update(['password' => hash(Config::get('chocolatey.security.hash'),
98
-            $request->json()->get('password'))]);
95
+     public function changePassword(Request $request): JsonResponse
96
+     {
97
+         UserFacade::getUser()->getChocolateyId()->update(['password' => hash(Config::get('chocolatey.security.hash'),
98
+             $request->json()->get('password'))]);
99 99
 
100
-        return response()->json(null, 204);
101
-    }
100
+         return response()->json(null, 204);
101
+     }
102 102
 
103
-    /**
103
+     /**
104 104
      * Confirm E-Mail Activation.
105 105
      *
106 106
      * @param Request $request
107 107
      *
108 108
      * @return JsonResponse
109 109
      */
110
-    public function confirmActivation(Request $request): JsonResponse
111
-    {
112
-        if (Mail::get($request->json()->get('token')) == null) {
113
-            return response()->json(['error' => 'activation.invalid_token'], 400);
114
-        }
110
+     public function confirmActivation(Request $request): JsonResponse
111
+     {
112
+         if (Mail::get($request->json()->get('token')) == null) {
113
+             return response()->json(['error' => 'activation.invalid_token'], 400);
114
+         }
115 115
 
116
-        ChocolateyId::find(Mail::get()->mail)->update(['mail_verified' => '1']);
116
+         ChocolateyId::find(Mail::get()->mail)->update(['mail_verified' => '1']);
117 117
 
118
-        if (strpos(Mail::get()->link, 'change-email') !== false) {
119
-            $email = str_replace('change-email/', '', Mail::get()->link);
118
+         if (strpos(Mail::get()->link, 'change-email') !== false) {
119
+             $email = str_replace('change-email/', '', Mail::get()->link);
120 120
 
121
-            User::where('mail', Mail::get()->mail)->update(['mail' => $email]);
121
+             User::where('mail', Mail::get()->mail)->update(['mail' => $email]);
122 122
 
123
-            ChocolateyId::find(Mail::get()->mail)->update(['mail' => $email]);
124
-        }
123
+             ChocolateyId::find(Mail::get()->mail)->update(['mail' => $email]);
124
+         }
125 125
 
126
-        return response()->json(['email' => Mail::get()->mail, 'emailVerified' => true, 'identityVerified' => true]);
127
-    }
126
+         return response()->json(['email' => Mail::get()->mail, 'emailVerified' => true, 'identityVerified' => true]);
127
+     }
128 128
 
129
-    /**
129
+     /**
130 130
      * Change User E-mail.
131 131
      *
132 132
      * @param Request $request
133 133
      *
134 134
      * @return JsonResponse
135 135
      */
136
-    public function changeMail(Request $request): JsonResponse
137
-    {
138
-        if (User::where('password', hash(Config::get('chocolatey.security.hash'), $request->json()->get('currentPassword')))->count() == 0) {
139
-            return response()->json(['error' => 'changeEmail.invalid_password'], 400);
140
-        }
136
+     public function changeMail(Request $request): JsonResponse
137
+     {
138
+         if (User::where('password', hash(Config::get('chocolatey.security.hash'), $request->json()->get('currentPassword')))->count() == 0) {
139
+             return response()->json(['error' => 'changeEmail.invalid_password'], 400);
140
+         }
141 141
 
142
-        if (ChocolateyId::where('mail', $request->json()->get('newEmail'))->count() > 0) {
143
-            return response()->json(['error' => 'changeEmail.email_already_in_use'], 400);
144
-        }
142
+         if (ChocolateyId::where('mail', $request->json()->get('newEmail'))->count() > 0) {
143
+             return response()->json(['error' => 'changeEmail.email_already_in_use'], 400);
144
+         }
145 145
 
146
-        $this->sendChangeMailConfirmation($request);
146
+         $this->sendChangeMailConfirmation($request);
147 147
 
148
-        return response()->json(['email' => $request->json()->get('newEmail')], 200);
149
-    }
148
+         return response()->json(['email' => $request->json()->get('newEmail')], 200);
149
+     }
150 150
 
151
-    /**
151
+     /**
152 152
      * Send the E-Mail confirmation.
153 153
      *
154 154
      * @param Request $request
155 155
      */
156
-    protected function sendChangeMailConfirmation(Request $request)
157
-    {
158
-        Mail::send(['email' => UserFacade::getUser()->email,
159
-            'name'          => UserFacade::getUser()->name, 'subject' => 'Email change alert',
160
-        ], 'habbo-web-mail.mail-change-alert');
156
+     protected function sendChangeMailConfirmation(Request $request)
157
+     {
158
+         Mail::send(['email' => UserFacade::getUser()->email,
159
+             'name'          => UserFacade::getUser()->name, 'subject' => 'Email change alert',
160
+         ], 'habbo-web-mail.mail-change-alert');
161 161
 
162
-        $generatedToken = Mail::store(UserFacade::getUser()->email,
163
-            "change-email/{$request->json()->get('newEmail')}");
162
+         $generatedToken = Mail::store(UserFacade::getUser()->email,
163
+             "change-email/{$request->json()->get('newEmail')}");
164 164
 
165
-        Mail::send(['email' => $request->json()->get('newEmail'), 'name' => UserFacade::getUser()->name,
166
-            'subject'       => 'Email change confirmation', 'url' => "/activate/{$generatedToken}",
167
-        ], 'habbo-web-mail.confirm-mail-change');
168
-    }
165
+         Mail::send(['email' => $request->json()->get('newEmail'), 'name' => UserFacade::getUser()->name,
166
+             'subject'       => 'Email change confirmation', 'url' => "/activate/{$generatedToken}",
167
+         ], 'habbo-web-mail.confirm-mail-change');
168
+     }
169 169
 
170
-    /**
170
+     /**
171 171
      * Get User Security Questions.
172 172
      *
173 173
      * @return JsonResponse
174 174
      */
175
-    public function getQuestions(): JsonResponse
176
-    {
177
-        if (UserSecurity::find(UserFacade::getUser()->uniqueId) == null) {
178
-            return response()->json('');
179
-        }
180
-
181
-        $userSecurity = UserSecurity::find(UserFacade::getUser()->uniqueId);
182
-
183
-        return response()->json([
184
-            new Question($userSecurity->firstQuestion,
185
-                "IDENTITY_SAFETYQUESTION_{$userSecurity->firstQuestion}"),
186
-            new Question($userSecurity->secondQuestion,
187
-                "IDENTITY_SAFETYQUESTION_{$userSecurity->secondQuestion}"),
188
-        ]);
189
-    }
190
-
191
-    /**
175
+     public function getQuestions(): JsonResponse
176
+     {
177
+         if (UserSecurity::find(UserFacade::getUser()->uniqueId) == null) {
178
+             return response()->json('');
179
+         }
180
+
181
+         $userSecurity = UserSecurity::find(UserFacade::getUser()->uniqueId);
182
+
183
+         return response()->json([
184
+             new Question($userSecurity->firstQuestion,
185
+                 "IDENTITY_SAFETYQUESTION_{$userSecurity->firstQuestion}"),
186
+             new Question($userSecurity->secondQuestion,
187
+                 "IDENTITY_SAFETYQUESTION_{$userSecurity->secondQuestion}"),
188
+         ]);
189
+     }
190
+
191
+     /**
192 192
      * Verify User Security Questions.
193 193
      *
194 194
      * @param Request $request
195 195
      *
196 196
      * @return JsonResponse
197 197
      */
198
-    public function verifyQuestions(Request $request): JsonResponse
199
-    {
200
-        $questions = UserSecurity::find(UserFacade::getUser()->uniqueId);
198
+     public function verifyQuestions(Request $request): JsonResponse
199
+     {
200
+         $questions = UserSecurity::find(UserFacade::getUser()->uniqueId);
201 201
 
202
-        if ($questions->firstAnswer == $request->json()->get('answer1') && $questions->secondAnswer == $request->json()->get('answer2')) {
203
-            if ($request->json()->get('trust') == true) {
204
-                (new TrustedDevice())->store(UserFacade::getUser()->uniqueId, $request->ip());
205
-            }
202
+         if ($questions->firstAnswer == $request->json()->get('answer1') && $questions->secondAnswer == $request->json()->get('answer2')) {
203
+             if ($request->json()->get('trust') == true) {
204
+                 (new TrustedDevice())->store(UserFacade::getUser()->uniqueId, $request->ip());
205
+             }
206 206
 
207
-            return response()->json(null, 204);
208
-        }
207
+             return response()->json(null, 204);
208
+         }
209 209
 
210
-        return response()->json(null, 409);
211
-    }
210
+         return response()->json(null, 409);
211
+     }
212 212
 
213
-    /**
213
+     /**
214 214
      * Confirm User Change Password.
215 215
      *
216 216
      * @param Request $request
217 217
      *
218 218
      * @return mixed
219 219
      */
220
-    public function confirmChangePassword(Request $request): JsonResponse
221
-    {
222
-        if (Mail::get($request->json()->get('token')) == null) {
223
-            return response()->json(null, 404);
224
-        }
220
+     public function confirmChangePassword(Request $request): JsonResponse
221
+     {
222
+         if (Mail::get($request->json()->get('token')) == null) {
223
+             return response()->json(null, 404);
224
+         }
225 225
 
226
-        ChocolateyId::find(Mail::get()->mail)->update(['password' => hash(Config::get('chocolatey.security.hash'), $request->json()->get('password'))]);
226
+         ChocolateyId::find(Mail::get()->mail)->update(['password' => hash(Config::get('chocolatey.security.hash'), $request->json()->get('password'))]);
227 227
 
228
-        return response()->json(null);
229
-    }
228
+         return response()->json(null);
229
+     }
230 230
 }
Please login to merge, or discard this patch.
app/Models/User.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
     {
346 346
         $accountCreated = $this->attributes['account_created'] ?? time();
347 347
 
348
-        return date('Y-m-d', $accountCreated).'T'.date('H:i:s.ZZZZ+ZZZZ', $accountCreated);
348
+        return date('Y-m-d', $accountCreated) . 'T' . date('H:i:s.ZZZZ+ZZZZ', $accountCreated);
349 349
     }
350 350
 
351 351
     /**
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
     {
358 358
         $accountCreated = $this->attributes['account_created'] ?? time();
359 359
 
360
-        return date('Y-m-d', $accountCreated).'T'.date('H:i:s.ZZZZ+ZZZZ', $accountCreated);
360
+        return date('Y-m-d', $accountCreated) . 'T' . date('H:i:s.ZZZZ+ZZZZ', $accountCreated);
361 361
     }
362 362
 
363 363
     /**
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
     {
380 380
         $lastLogin = $this->attributes['last_login'] ?? time();
381 381
 
382
-        return date('Y-m-d', $lastLogin).'T'.date('H:i:s.ZZZZ+ZZZZ', $lastLogin);
382
+        return date('Y-m-d', $lastLogin) . 'T' . date('H:i:s.ZZZZ+ZZZZ', $lastLogin);
383 383
     }
384 384
 
385 385
     /**
Please login to merge, or discard this patch.