Completed
Push — development ( 9515cf...3cb16f )
by Claudio
02:12
created
app/Models/User.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -234,8 +234,9 @@
 block discarded – undo
234 234
      */
235 235
     public function getTrustedAttribute(): bool
236 236
     {
237
-        if (UserSecurity::find($this->attributes['id']) == null)
238
-            return true;
237
+        if (UserSecurity::find($this->attributes['id']) == null) {
238
+                    return true;
239
+        }
239 240
 
240 241
         return in_array($this->attributes['ip_current'],
241 242
             UserSecurity::find($this->attributes['id'])->trustedDevices);
Please login to merge, or discard this patch.
app/Models/UserSecurity.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
     public function getTrustedDevicesAttribute(): array
69 69
     {
70 70
         return TrustedDevice::where('user_id', $this->attributes['user_id'])->get(['ip_address'])
71
-            ->map(function ($item) {
71
+            ->map(function($item) {
72 72
                 return $item->ip_address;
73 73
             })->toArray();
74 74
     }
Please login to merge, or discard this patch.
app/Http/Controllers/ArticleController.php 2 patches
Spacing   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,8 +27,7 @@  discard block
 block discarded – undo
27 27
 
28 28
         $categoryPage = strstr(strrev($articleCategory), '_', true);
29 29
 
30
-        return $articleCategory == 'front' ? $this->front() :
31
-            $this->category($countryId, $category, $categoryPage,
30
+        return $articleCategory == 'front' ? $this->front() : $this->category($countryId, $category, $categoryPage,
32 31
                 $categoryPage == 1 ? 0 : (10 * ($categoryPage - 1)));
33 32
     }
34 33
 
@@ -57,7 +56,7 @@  discard block
 block discarded – undo
57 56
     protected function category(string $countryId, ArticleCategory $category, int $categoryPage, int $start): Response
58 57
     {
59 58
         $articles = Article::where('id', '>=', $start)
60
-            ->limit(10)->get()->filter(function ($item) use ($category) {
59
+            ->limit(10)->get()->filter(function($item) use ($category) {
61 60
                 return $category->name == 'all' || in_array($category, $item->categories);
62 61
             });
63 62
 
@@ -86,7 +85,7 @@  discard block
 block discarded – undo
86 85
         if (($article = Article::find(strstr($articleName, '_', true))) == null)
87 86
             return response()->json(null, 404);
88 87
 
89
-        $related = ($latest = Article::all())->filter(function ($item) use ($article) {
88
+        $related = ($latest = Article::all())->filter(function($item) use ($article) {
90 89
             return in_array($article->categories[0], $item->categories);
91 90
         });
92 91
 
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -61,8 +61,9 @@  discard block
 block discarded – undo
61 61
                 return $category->name == 'all' || in_array($category, $item->categories);
62 62
             });
63 63
 
64
-        if ($articles->count() == 0)
65
-            return response()->json(null, 404);
64
+        if ($articles->count() == 0) {
65
+                    return response()->json(null, 404);
66
+        }
66 67
 
67 68
         return response(view('habbo-web-news.articles-category', [
68 69
             'category' => $category,
@@ -83,8 +84,9 @@  discard block
 block discarded – undo
83 84
      */
84 85
     public function one(string $countryId, string $articleName): Response
85 86
     {
86
-        if (($article = Article::find(strstr($articleName, '_', true))) == null)
87
-            return response()->json(null, 404);
87
+        if (($article = Article::find(strstr($articleName, '_', true))) == null) {
88
+                    return response()->json(null, 404);
89
+        }
88 90
 
89 91
         $related = ($latest = Article::all())->filter(function ($item) use ($article) {
90 92
             return in_array($article->categories[0], $item->categories);
Please login to merge, or discard this patch.
app/Http/Controllers/AccountController.php 1 patch
Braces   +24 added lines, -16 removed lines patch added patch discarded remove patch
@@ -26,8 +26,9 @@  discard block
 block discarded – undo
26 26
      */
27 27
     public function checkName(Request $request): JsonResponse
28 28
     {
29
-        if (User::where('username', $request->json()->get('name'))->count() > 0)
30
-            return response()->json(['code' => 'NAME_IN_USE', 'validationResult' => null, 'suggestions' => []]);
29
+        if (User::where('username', $request->json()->get('name'))->count() > 0) {
30
+                    return response()->json(['code' => 'NAME_IN_USE', 'validationResult' => null, 'suggestions' => []]);
31
+        }
31 32
 
32 33
         return response()->json(['code' => 'OK', 'validationResult' => null, 'suggestions' => []]);
33 34
     }
@@ -75,8 +76,9 @@  discard block
 block discarded – undo
75 76
      */
76 77
     public function selectRoom(Request $request): JsonResponse
77 78
     {
78
-        if (!in_array($request->json()->get('roomIndex'), [1, 2, 3]))
79
-            return response('', 400);
79
+        if (!in_array($request->json()->get('roomIndex'), [1, 2, 3])) {
80
+                    return response('', 400);
81
+        }
80 82
 
81 83
         $request->user()->traits = ["USER"];
82 84
 
@@ -106,8 +108,9 @@  discard block
 block discarded – undo
106 108
     {
107 109
         $userPreferences = UserPreferences::find($request->user()->uniqueId);
108 110
 
109
-        foreach ($userPreferences->getAttributes() as $attributeName => $attributeValue)
110
-            $userPreferences->{$attributeName} = $attributeValue == 1;
111
+        foreach ($userPreferences->getAttributes() as $attributeName => $attributeValue) {
112
+                    $userPreferences->{$attributeName} = $attributeValue == 1;
113
+        }
111 114
 
112 115
         return response()->json($userPreferences);
113 116
     }
@@ -153,8 +156,9 @@  discard block
 block discarded – undo
153 156
      */
154 157
     public function checkNewName(Request $request): JsonResponse
155 158
     {
156
-        if (User::where('username', $request->input('name'))->count() > 0)
157
-            return response()->json(['isAvailable' => false]);
159
+        if (User::where('username', $request->input('name'))->count() > 0) {
160
+                    return response()->json(['isAvailable' => false]);
161
+        }
158 162
 
159 163
         return response()->json(['isAvailable' => true]);
160 164
     }
@@ -167,8 +171,9 @@  discard block
 block discarded – undo
167 171
      */
168 172
     public function createAvatar(Request $request): JsonResponse
169 173
     {
170
-        if (User::where('username', $request->json()->get('name'))->count() > 0)
171
-            return response()->json(['isAvailable' => false]);
174
+        if (User::where('username', $request->json()->get('name'))->count() > 0) {
175
+                    return response()->json(['isAvailable' => false]);
176
+        }
172 177
 
173 178
         $request->user()->name = $request->json()->get('name');
174 179
 
@@ -228,8 +233,9 @@  discard block
 block discarded – undo
228 233
      */
229 234
     public function confirmActivation(Request $request): JsonResponse
230 235
     {
231
-        if (($mailRequest = (new MailController)->getMail($request->json()->get('token'))) == null)
232
-            return response()->json(['error' => 'activation.invalid_token'], 400);
236
+        if (($mailRequest = (new MailController)->getMail($request->json()->get('token'))) == null) {
237
+                    return response()->json(['error' => 'activation.invalid_token'], 400);
238
+        }
233 239
 
234 240
         if (strpos($mailRequest->link, 'change-email') !== false):
235 241
             $mail = str_replace('change-email/', '', $mailRequest->link);
@@ -240,8 +246,9 @@  discard block
 block discarded – undo
240 246
 
241 247
         DB::table('users')->where('mail', $mailRequest->mail)->update(['mail_verified' => 1]);
242 248
 
243
-        if ($request->user() !== null)
244
-            $request->user()->emailVerified = true;
249
+        if ($request->user() !== null) {
250
+                    $request->user()->emailVerified = true;
251
+        }
245 252
 
246 253
         return response()->json(['email' => $mailRequest->mail, 'emailVerified' => true, 'identityVerified' => true]);
247 254
     }
@@ -254,8 +261,9 @@  discard block
 block discarded – undo
254 261
      */
255 262
     public function forgotPassword(Request $request): JsonResponse
256 263
     {
257
-        if (($user = User::where('mail', $request->json()->get('email'))->first()) == null)
258
-            return response()->json(['email' => $request->json()->get('email')]);
264
+        if (($user = User::where('mail', $request->json()->get('email'))->first()) == null) {
265
+                    return response()->json(['email' => $request->json()->get('email')]);
266
+        }
259 267
 
260 268
         $mailController = new MailController;
261 269
 
Please login to merge, or discard this patch.
app/Http/Controllers/AccountSecurityController.php 1 patch
Braces   +30 added lines, -20 removed lines patch added patch discarded remove patch
@@ -28,8 +28,9 @@  discard block
 block discarded – undo
28 28
      */
29 29
     public function featureStatus(Request $request): Response
30 30
     {
31
-        if ($request->user()->emailVerified == false)
32
-            return response('identity_verification_required', 200);
31
+        if ($request->user()->emailVerified == false) {
32
+                    return response('identity_verification_required', 200);
33
+        }
33 34
 
34 35
         $featureEnabled = UserSecurity::find($request->user()->uniqueId);
35 36
 
@@ -44,8 +45,9 @@  discard block
 block discarded – undo
44 45
      */
45 46
     public function saveQuestions(Request $request): JsonResponse
46 47
     {
47
-        if (User::where('password', hash('sha256', $request->json()->get('password')))->count() == 0)
48
-            return response()->json(['error' => 'invalid_password'], 400);
48
+        if (User::where('password', hash('sha256', $request->json()->get('password')))->count() == 0) {
49
+                    return response()->json(['error' => 'invalid_password'], 400);
50
+        }
49 51
 
50 52
         UserSecurity::updateOrCreate([
51 53
             'user_id' => $request->user()->uniqueId,
@@ -93,12 +95,14 @@  discard block
 block discarded – undo
93 95
      */
94 96
     public function changePassword(Request $request): JsonResponse
95 97
     {
96
-        if (strlen($request->json()->get('password')) < 6)
97
-            return response()->json(['error' => 'password.current_password.invalid'], 409);
98
+        if (strlen($request->json()->get('password')) < 6) {
99
+                    return response()->json(['error' => 'password.current_password.invalid'], 409);
100
+        }
98 101
 
99 102
         //@TODO: This search the whole base. If anyone has the same password.. This will give error. Is this good?
100
-        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() >= 1)
101
-            return response()->json(['error' => 'password.used_earlier'], 409);
103
+        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() >= 1) {
104
+                    return response()->json(['error' => 'password.used_earlier'], 409);
105
+        }
102 106
 
103 107
         User::find($request->user()->uniqueId)->update(['password' =>
104 108
             hash('sha256', $request->json()->get('password'))]);
@@ -114,11 +118,13 @@  discard block
 block discarded – undo
114 118
      */
115 119
     public function changeMail(Request $request): JsonResponse
116 120
     {
117
-        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() == 0)
118
-            return response()->json(['error' => 'changeEmail.invalid_password'], 400);
121
+        if (User::where('password', hash('sha256', $request->json()->get('currentPassword')))->count() == 0) {
122
+                    return response()->json(['error' => 'changeEmail.invalid_password'], 400);
123
+        }
119 124
 
120
-        if (ChocolateyId::where('mail', $request->json()->get('newEmail'))->count() > 0)
121
-            return response()->json(['error' => 'changeEmail.email_already_in_use'], 400);
125
+        if (ChocolateyId::where('mail', $request->json()->get('newEmail'))->count() > 0) {
126
+                    return response()->json(['error' => 'changeEmail.email_already_in_use'], 400);
127
+        }
122 128
 
123 129
         $this->sendChangeMailConfirmation($request);
124 130
 
@@ -159,8 +165,9 @@  discard block
 block discarded – undo
159 165
      */
160 166
     public function getQuestions(Request $request): JsonResponse
161 167
     {
162
-        if (UserSecurity::find($request->user()->uniqueId) == null)
163
-            return response()->json('');
168
+        if (UserSecurity::find($request->user()->uniqueId) == null) {
169
+                    return response()->json('');
170
+        }
164 171
 
165 172
         $userSecurity = UserSecurity::find($request->user()->uniqueId);
166 173
 
@@ -184,8 +191,9 @@  discard block
 block discarded – undo
184 191
                 ->where('firstAnswer', $request->json()->get('answer1'))
185 192
                 ->where('secondAnswer', $request->json()->get('answer2'))->count() > 0
186 193
         ):
187
-            if ($request->json()->get('trust') == true)
188
-                (new TrustedDevice)->store($request->user()->uniqueId, $request->ip())->save();
194
+            if ($request->json()->get('trust') == true) {
195
+                            (new TrustedDevice)->store($request->user()->uniqueId, $request->ip())->save();
196
+            }
189 197
 
190 198
             $request->user()->trusted = true;
191 199
 
@@ -205,11 +213,13 @@  discard block
 block discarded – undo
205 213
     {
206 214
         $mailRequest = Mail::where('token', $request->json()->get('token'))->where('used', '0')->first();
207 215
 
208
-        if ($mailRequest == null)
209
-            return response()->json(null, 404);
216
+        if ($mailRequest == null) {
217
+                    return response()->json(null, 404);
218
+        }
210 219
 
211
-        if (User::where('password', hash('sha256', $request->json()->get('password')))->count() >= 1)
212
-            return response()->json(['error' => 'password.used_earlier'], 400);
220
+        if (User::where('password', hash('sha256', $request->json()->get('password')))->count() >= 1) {
221
+                    return response()->json(['error' => 'password.used_earlier'], 400);
222
+        }
213 223
 
214 224
         $mailRequest->update(['used' => '1']);
215 225
 
Please login to merge, or discard this patch.
app/Http/Controllers/MailController.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,8 +76,9 @@
 block discarded – undo
76 76
     {
77 77
         $mailRequest = MailModel::where('token', $token)->where('used', '0')->first();
78 78
 
79
-        if ($mailRequest !== null)
80
-            $mailRequest->update(['used' => '1']);
79
+        if ($mailRequest !== null) {
80
+                    $mailRequest->update(['used' => '1']);
81
+        }
81 82
 
82 83
         return $mailRequest;
83 84
     }
Please login to merge, or discard this patch.