RoomsController::getRoom() - Code Metrics - sant0ro/chocolatey - Measure and Improve Code Quality continuously with Scrutinizer

RoomsController::getRoom() A
last analyzed 2017-11-06 14:00 UTC

↳ Parent: RoomsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace App\Http\Controllers;

use App\Models\Room;
use Illuminate\Http\JsonResponse;
use Laravel\Lumen\Routing\Controller as BaseController;

/**
 * Class RoomsController.
 */
class RoomsController extends BaseController
{
    /**
     * Get LeaderBoard Data.
     *
     * @TODO: Make Possible Filter with all the Possible Criteria
     *
     * @param string $countryId
     * @param string $roomRange
     * @param string $roomInterval
     *
     * @return JsonResponse
     */
    public function getLeader($countryId, $roomRange, $roomInterval): JsonResponse

    {
        $leaderRank = 1;

        foreach (($leaderBoard = Room::where('state', '!=', 'invisible')->orderBy('score', 'DESC')->orderBy('users', 'DESC')->limit(50)->get()) as $room) {
            $room->leaderboardRank = $leaderRank++;
        }

        return response()->json($leaderBoard, 200, [], JSON_UNESCAPED_SLASHES);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Get a specific Room Data.
     *
     * @param int $roomId
     *
     * @return JsonResponse
     */
    public function getRoom($roomId): JsonResponse
    {
        return response()->json(Room::find($roomId) ?? ['error' => 'not-found'], 200, [], JSON_UNESCAPED_SLASHES);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Models\Room;
6			use Illuminate\Http\JsonResponse;
7			use Laravel\Lumen\Routing\Controller as BaseController;
8
9			/**
10			* Class RoomsController.
11			*/
12			class RoomsController extends BaseController
13			{
14			/**
15			* Get LeaderBoard Data.
16			*
17			* @TODO: Make Possible Filter with all the Possible Criteria
18			*
19			* @param string $countryId
20			* @param string $roomRange
21			* @param string $roomInterval
22			*
23			* @return JsonResponse
24			*/
25			public function getLeader($countryId, $roomRange, $roomInterval): JsonResponse
			0 ignored issues – show Unused Code introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report The parameter `$countryId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report The parameter `$roomRange` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-05 22:32 UTC by Report Bug Copy Issue Report The parameter `$roomInterval` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
26			{
27			$leaderRank = 1;
28
29			foreach (($leaderBoard = Room::where('state', '!=', 'invisible')->orderBy('score', 'DESC')->orderBy('users', 'DESC')->limit(50)->get()) as $room) {
30			$room->leaderboardRank = $leaderRank++;
31			}
32
33			return response()->json($leaderBoard, 200, [], JSON_UNESCAPED_SLASHES);
			0 ignored issues – show Bug introduced 2017-01-31 02:42 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
34			}
35
36			/**
37			* Get a specific Room Data.
38			*
39			* @param int $roomId
40			*
41			* @return JsonResponse
42			*/
43			public function getRoom($roomId): JsonResponse
44			{
45			return response()->json(Room::find($roomId) ?? ['error' => 'not-found'], 200, [], JSON_UNESCAPED_SLASHES);
			0 ignored issues – show Bug introduced 2017-04-23 20:58 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Laravel\Lumen\Http\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
46			}
47			}
48

sant0ro / chocolatey

RoomsController::getRoom() A last analyzed 2017-11-06 14:00 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RoomsController::getRoom() A
last analyzed 2017-11-06 14:00 UTC