App\Http\Controllers\RoomsController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRoom()	0	4	1
A	getLeader()	0	10	2

<?php

namespace App\Http\Controllers;

use App\Models\Room;
use Illuminate\Http\JsonResponse;
use Laravel\Lumen\Routing\Controller as BaseController;

/**
 * Class RoomsController.
 */
class RoomsController extends BaseController
{
    /**
     * Get LeaderBoard Data.
     *
     * @TODO: Make Possible Filter with all the Possible Criteria
     *
     * @param string $countryId
     * @param string $roomRange
     * @param string $roomInterval
     *
     * @return JsonResponse
     */
    public function getLeader($countryId, $roomRange, $roomInterval): JsonResponse

The parameter $countryId is not used and could be removed.

The parameter $roomRange is not used and could be removed.

The parameter $roomInterval is not used and could be removed.

    {
        $leaderRank = 1;

        foreach (($leaderBoard = Room::where('state', '!=', 'invisible')->orderBy('score', 'DESC')->orderBy('users', 'DESC')->limit(50)->get()) as $room) {
            $room->leaderboardRank = $leaderRank++;
        }

        return response()->json($leaderBoard, 200, [], JSON_UNESCAPED_SLASHES);

The method json does only exist in Laravel\Lumen\Http\ResponseFactory, but not in Illuminate\Http\Response.

    }

    /**
     * Get a specific Room Data.
     *
     * @param int $roomId
     *
     * @return JsonResponse
     */
    public function getRoom($roomId): JsonResponse
    {
        return response()->json(Room::find($roomId) ?? ['error' => 'not-found'], 200, [], JSON_UNESCAPED_SLASHES);

The method json does only exist in Laravel\Lumen\Http\ResponseFactory, but not in Illuminate\Http\Response.

    }
}