PageController::habboPage() - Code Metrics - sant0ro/chocolatey - Measure and Improve Code Quality continuously with Scrutinizer

PageController::habboPage() A
last analyzed 2017-11-06 14:00 UTC

↳ Parent: PageController

Complexity

Conditions	2
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	2
eloc	2
nc	1
nop	2

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Response;
use Laravel\Lumen\Routing\Controller as BaseController;

/**
 * Class PageController.
 */
class PageController extends BaseController
{
    /**
     * Render a HabboWEB Page.
     *
     * @param string $pageCategory
     * @param string $pageFile
     *
     * @return Response
     */
    public function show(string $pageCategory, string $pageFile): Response
    {
        $pageArray = explode('.', $pageFile);

        return response(view("habbo-web-pages.{$pageCategory}.{$pageArray[0]}"));
    }

    /**
     * Render a HabboPage.
     *
     * @WARNING: Categories can still be pages
     *
     * @param string $category
     * @param string $page
     *
     * @return Response
     */
    public function habboPage(string $category, string $page = '')
    {
        return response(view(empty($page) ? "habbo-pages.{$category}" : "habbo-pages.{$category}.{$page}"));

    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Http\Response;
6			use Laravel\Lumen\Routing\Controller as BaseController;
7
8			/**
9			* Class PageController.
10			*/
11			class PageController extends BaseController
12			{
13			/**
14			* Render a HabboWEB Page.
15			*
16			* @param string $pageCategory
17			* @param string $pageFile
18			*
19			* @return Response
20			*/
21			public function show(string $pageCategory, string $pageFile): Response
22			{
23			$pageArray = explode('.', $pageFile);
24
25			return response(view("habbo-web-pages.{$pageCategory}.{$pageArray[0]}"));
26			}
27
28			/**
29			* Render a HabboPage.
30			*
31			* @WARNING: Categories can still be pages
32			*
33			* @param string $category
34			* @param string $page
35			*
36			* @return Response
37			*/
38			public function habboPage(string $category, string $page = '')
39			{
40			return response(view(empty($page) ? "habbo-pages.{$category}" : "habbo-pages.{$category}.{$page}"));
			0 ignored issues – show Bug Compatibility introduced 2017-04-18 19:58 UTC by Report Bug Copy Issue Report The expression `response(view(empty($pag...{$category}.{$page}"));` of type `Laravel\Lumen\Http\Respo...lluminate\Http\Response` adds the type `Laravel\Lumen\Http\ResponseFactory` to the return on line 40 which is incompatible with the return type documented by `App\Http\Controllers\PageController::habboPage` of type `Illuminate\Http\Response`. Loading history...
41			}
42			}
43

sant0ro / chocolatey

PageController::habboPage() A last analyzed 2017-11-06 14:00 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PageController::habboPage() A
last analyzed 2017-11-06 14:00 UTC