App\Http\Controllers\PageController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	6	1
A	habboPage()	0	4	2

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Response;
use Laravel\Lumen\Routing\Controller as BaseController;

/**
 * Class PageController.
 */
class PageController extends BaseController
{
    /**
     * Render a HabboWEB Page.
     *
     * @param string $pageCategory
     * @param string $pageFile
     *
     * @return Response
     */
    public function show(string $pageCategory, string $pageFile): Response
    {
        $pageArray = explode('.', $pageFile);

        return response(view("habbo-web-pages.{$pageCategory}.{$pageArray[0]}"));
    }

    /**
     * Render a HabboPage.
     *
     * @WARNING: Categories can still be pages
     *
     * @param string $category
     * @param string $page
     *
     * @return Response
     */
    public function habboPage(string $category, string $page = '')
    {
        return response(view(empty($page) ? "habbo-pages.{$category}" : "habbo-pages.{$category}.{$page}"));

The expression response(view(empty($page) ? "habbo-pages.{$category}" : "habbo-pages.{$category}.{$page}")); of type Laravel\Lumen\Http\ResponseFactory|Illuminate\Http\Response adds the type Laravel\Lumen\Http\ResponseFactory to the return on line 40 which is incompatible with the return type documented by App\Http\Controllers\PageController::habboPage of type Illuminate\Http\Response.

    }
}