samwilson / taggedfiles

src/Controllers/FileController.php

Unused Use Statements -4 removed lines

@@ -7,11 +7,7 @@
 use Symfony\Component\HttpFoundation\BinaryFileResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\ResponseHeaderBag;
-use Symfony\Component\HttpFoundation\StreamedResponse;
-use Intervention\Image\Facades\Image;
-use Intervention\Image\ImageManager;
 
 class FileController extends Base
 {

src/Template.php

Doc Comments +3 added lines

@@ -15,6 +15,9 @@
     const WARNING = 'warning';
     const ERROR = 'error';
 
+    /**
+     * @param string $template
+     */
     public function __construct($template)
     {
         $this->template = $template;

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
         $twig->addExtension(new \Twig_Extension_Debug());
 
         // Mardown support.
-        $twig->addFilter(new \Twig_SimpleFilter('markdown', function ($text) {
+        $twig->addFilter(new \Twig_SimpleFilter('markdown', function($text) {
             $parsedown = new \Parsedown();
             return $parsedown->text($text);
         }));

src/Db.php

Indentation +5 added lines, -5 removed lines

@@ -119,11 +119,11 @@
             . " php_format VARCHAR(50) NOT NULL UNIQUE"
             . ")");
         $granularities = [
-             [1, 'Exact', 'Y-m-d H:i:s'],
-             [2, 'Day', 'j F Y'],
-             [3, 'Month', 'F Y'],
-             [4, 'Year', 'Y'],
-             [5, 'Circa', '\\c. Y'],
+                [1, 'Exact', 'Y-m-d H:i:s'],
+                [2, 'Day', 'j F Y'],
+                [3, 'Month', 'F Y'],
+                [4, 'Year', 'Y'],
+                [5, 'Circa', '\\c. Y'],
         ];
         foreach ($granularities as $gran) {
             $this->query(

Spacing +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
             . " `password` VARCHAR(255) NULL DEFAULT NULL,"
             . " `reminder_token` VARCHAR(255) NULL DEFAULT NULL,"
             . " `reminder_time` DATETIME NULL DEFAULT NULL,"
-            . " `default_group` INT(5) UNSIGNED NOT NULL DEFAULT ".User::GROUP_PUBLIC.","
+            . " `default_group` INT(5) UNSIGNED NOT NULL DEFAULT " . User::GROUP_PUBLIC . ","
             . "     FOREIGN KEY (`default_group`) REFERENCES `groups` (`id`)"
             . ")");
         $this->query("CREATE TABLE IF NOT EXISTS `user_groups` ("

src/App.php

Spacing +1 added lines, -2 removed lines

@@ -76,7 +76,6 @@
             return false;
         }
         return is_file($path) ?
-            @unlink($path) :
-            array_map([__CLASS__, __FUNCTION__], glob($path . '/*')) == @rmdir($path);
+            @unlink($path) : array_map([__CLASS__, __FUNCTION__], glob($path . '/*')) == @rmdir($path);
     }
 }

src/Item.php

Spacing +2 added lines, -2 removed lines

@@ -248,7 +248,7 @@ 
             $version = $this->getVersionCount();
         }
         if ($version > $this->getVersionCount()) {
-            throw new Exception("Version $version does not exist for Item ".$this->getId());
+            throw new Exception("Version $version does not exist for Item " . $this->getId());
         }
         $filesystem = App::getFilesystem();
         $path = $this->getFilePath($version);
@@ -279,7 +279,7 @@ 
             $height = $image->getHeight();
             $newWidth = ($width > $height) ? 700 : null;
             $newHeight = ($width > $height) ? null : 700;
-            $image->resize($newWidth, $newHeight, function (Constraint $constraint) {
+            $image->resize($newWidth, $newHeight, function(Constraint $constraint) {
                 $constraint->aspectRatio();
                 $constraint->upsize();
             });

src/Commands/UpgradeCommand.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     public function run()
     {
         $config = new Config();
-        $this->write("Upgrading ".$config->siteTitle()." . . . ");
+        $this->write("Upgrading " . $config->siteTitle() . " . . . ");
         $db = new Db();
         $db->install();
         $this->write("Upgrade complete");

src/Controllers/TagController.php

Spacing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
             . " FROM item_tags selected_tags"
             . " JOIN item_tags related_tags ON selected_tags.item = related_tags.item"
             . " JOIN tags ON related_tags.tag = tags.id"
-            . (!$tags->isEmpty() ? " WHERE selected_tags.tag IN (".$tags->toString().") " : '')
+            . (!$tags->isEmpty() ? " WHERE selected_tags.tag IN (" . $tags->toString() . ") " : '')
             . " GROUP BY tags.id ORDER BY tags.title ASC";
         $params = [];
         $template->tags = $this->db->query($tagsSql, $params);

bootstrap.php

Spacing +3 added lines, -3 removed lines

@@ -12,17 +12,17 @@
 /**
  * Exception handling.
  */
-set_exception_handler([ \App\App::class, 'exceptionHandler' ]);
+set_exception_handler([\App\App::class, 'exceptionHandler']);
 
 /**
  * Configuration file. When testing, the tests/config.php file is used.
  */
-if (substr(basename($_SERVER['PHP_SELF']), 0, 7)==='phpunit') {
+if (substr(basename($_SERVER['PHP_SELF']), 0, 7) === 'phpunit') {
     define('CONFIG_FILE', __DIR__ . '/tests/config.php');
 } else {
     define('CONFIG_FILE', __DIR__ . '/config.php');
 }
 if (!file_exists(CONFIG_FILE)) {
-    echo "Please copy <code>config.example.php</code> to <code>".CONFIG_FILE."</code> and edit the values therein";
+    echo "Please copy <code>config.example.php</code> to <code>" . CONFIG_FILE . "</code> and edit the values therein";
     exit(1);
 }

src/TagsIdentifier.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     }
 
     /**
-     * @param $str
+     * @param string $str
      * @return $this
      */
     public function removeFromString($str)