Passed
Push — master ( d7fd0c...0cd2cd )
by Sam
04:33
created
tests/ServerTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -38,12 +38,12 @@  discard block
 block discarded – undo
38 38
     public function setUp()
39 39
     {
40 40
         $xmlResolver = new XmlResolver([
41
-            __DIR__.'/Resources/test.com.xml',
41
+            __DIR__ . '/Resources/test.com.xml',
42 42
         ]);
43 43
 
44 44
         $jsonResolver = new JsonResolver([
45
-            __DIR__.'/Resources/test_records.json',
46
-            __DIR__.'/Resources/example.com.json',
45
+            __DIR__ . '/Resources/test_records.json',
46
+            __DIR__ . '/Resources/example.com.json',
47 47
         ]);
48 48
 
49 49
         $resolver = new StackableResolver([
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         $qname = Encoder::encodeDomainName($name);
67 67
         $flags = 0b0000000000000000;
68 68
         $header = pack('nnnnnn', $id, $flags, 1, 0, 0, 0);
69
-        $question = $qname.pack('nn', $type, 1);
69
+        $question = $qname . pack('nn', $type, 1);
70 70
 
71 71
         return [$header, $question];
72 72
     }
@@ -79,16 +79,16 @@  discard block
 block discarded – undo
79 79
     private function mockQueryAndResponse(): array
80 80
     {
81 81
         list($queryHeader, $question) = $this->encodeQuery($name = 'test.com.', RecordTypeEnum::TYPE_A, $id = 1337);
82
-        $query = $queryHeader.$question;
82
+        $query = $queryHeader . $question;
83 83
 
84 84
         $flags = 0b1000010000000000;
85 85
         $qname = Encoder::encodeDomainName($name);
86 86
         $header = pack('nnnnnn', $id, $flags, 1, 1, 0, 0);
87 87
 
88 88
         $rdata = inet_pton('111.111.111.111');
89
-        $answer = $qname.pack('nnNn', 1, 1, 300, strlen($rdata)).$rdata;
89
+        $answer = $qname . pack('nnNn', 1, 1, 300, strlen($rdata)) . $rdata;
90 90
 
91
-        $response = $header.$question.$answer;
91
+        $response = $header . $question . $answer;
92 92
 
93 93
         return [$query, $response];
94 94
     }
Please login to merge, or discard this patch.
tests/DecoderTest.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
     public function testDecodeDomainName()
23 23
     {
24 24
         $decoded_1 = 'www.example.com.';
25
-        $encoded_1 = chr(3).'www'.chr(7).'example'.chr(3).'com'."\0";
25
+        $encoded_1 = chr(3) . 'www' . chr(7) . 'example' . chr(3) . 'com' . "\0";
26 26
 
27 27
         $decoded_2 = '.';
28 28
         $encoded_2 = "\0";
29 29
 
30 30
         $decoded_3 = 'tld.';
31
-        $encoded_3 = chr(3).'tld'."\0";
31
+        $encoded_3 = chr(3) . 'tld' . "\0";
32 32
 
33 33
         $offset = 0;
34 34
         $this->assertEquals($decoded_1, Decoder::decodeDomainName($encoded_1, $offset));
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             ->setQuestion(true);
52 52
 
53 53
         $encoded_1 =
54
-            chr(3).'www'.chr(7).'example'.chr(3).'com'."\0".
54
+            chr(3) . 'www' . chr(7) . 'example' . chr(3) . 'com' . "\0" .
55 55
             pack('nn', 1, 1);
56 56
 
57 57
         $decoded_2[] = (new ResourceRecord())
@@ -60,11 +60,11 @@  discard block
 block discarded – undo
60 60
             ->setQuestion(true);
61 61
 
62 62
         $encoded_2 =
63
-            chr(6).'domain'.chr(3).'com'.chr(2).'au'."\0".
63
+            chr(6) . 'domain' . chr(3) . 'com' . chr(2) . 'au' . "\0" .
64 64
             pack('nn', 15, 1);
65 65
 
66 66
         $decoded_3 = [$decoded_1[0], $decoded_2[0]];
67
-        $encoded_3 = $encoded_1.$encoded_2;
67
+        $encoded_3 = $encoded_1 . $encoded_2;
68 68
 
69 69
         $offset = 0;
70 70
         $this->assertEquals($decoded_1, Decoder::decodeResourceRecords($encoded_1, 1, $offset, true));
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         $type = RecordTypeEnum::TYPE_MX;
90 90
         $ipAddress = '192.163.5.2';
91 91
 
92
-        $rdata = pack('n', $priority).$exchangeEncoded;
92
+        $rdata = pack('n', $priority) . $exchangeEncoded;
93 93
         $rdata2 = inet_pton($ipAddress);
94 94
 
95 95
         $decoded1[] = (new ResourceRecord())
@@ -111,9 +111,9 @@  discard block
 block discarded – undo
111 111
 
112 112
         $decoded3 = array_merge($decoded1, $decoded2);
113 113
 
114
-        $encoded1 = $nameEncoded.pack('nnNn', $type, $class, $ttl, strlen($rdata)).$rdata;
115
-        $encoded2 = $nameEncoded.pack('nnNn', 1, $class, $ttl, strlen($rdata2)).$rdata2;
116
-        $encoded3 = $encoded1.$encoded2;
114
+        $encoded1 = $nameEncoded . pack('nnNn', $type, $class, $ttl, strlen($rdata)) . $rdata;
115
+        $encoded2 = $nameEncoded . pack('nnNn', 1, $class, $ttl, strlen($rdata2)) . $rdata2;
116
+        $encoded3 = $encoded1 . $encoded2;
117 117
 
118 118
         $this->assertEquals($decoded1, Decoder::decodeResourceRecords($encoded1));
119 119
         $this->assertEquals($decoded2, Decoder::decodeResourceRecords($encoded2));
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
         $encoded_2 = inet_pton($decoded_2);
133 133
 
134 134
         $decoded_5 = 'dns1.example.com.';
135
-        $encoded_5 = chr(4).'dns1'.chr(7).'example'.chr(3).'com'."\0";
135
+        $encoded_5 = chr(4) . 'dns1' . chr(7) . 'example' . chr(3) . 'com' . "\0";
136 136
 
137 137
         $decoded_6_prime = [
138 138
             'mname' => 'example.com.',
@@ -145,18 +145,18 @@  discard block
 block discarded – undo
145 145
         ];
146 146
 
147 147
         $encoded_6 =
148
-            chr(7).'example'.chr(3).'com'."\0".
149
-            chr(10).'postmaster'.chr(7).'example'.chr(3).'com'."\0".
148
+            chr(7) . 'example' . chr(3) . 'com' . "\0" .
149
+            chr(10) . 'postmaster' . chr(7) . 'example' . chr(3) . 'com' . "\0" .
150 150
             pack('NNNNN', 1970010188, 1800, 7200, 10800, 3600);
151 151
 
152
-        $encoded_7 = pack('n', 10).chr(4).'mail'.chr(7).'example'.chr(3).'com'."\0";
152
+        $encoded_7 = pack('n', 10) . chr(4) . 'mail' . chr(7) . 'example' . chr(3) . 'com' . "\0";
153 153
         $decoded_7_prime = [
154 154
             'preference' => 10,
155 155
             'exchange' => 'mail.example.com.',
156 156
         ];
157 157
 
158 158
         $decoded_8 = 'This is a comment.';
159
-        $encoded_8 = chr(strlen($decoded_8)).$decoded_8;
159
+        $encoded_8 = chr(strlen($decoded_8)) . $decoded_8;
160 160
 
161 161
         $this->assertEquals($decoded_1, Decoder::decodeRdata(RecordTypeEnum::TYPE_A, $encoded_1));
162 162
         $this->assertEquals($decoded_2, Decoder::decodeRdata(RecordTypeEnum::TYPE_AAAA, $encoded_2));
Please login to merge, or discard this patch.
tests/Resolver/YamlResolverTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,8 +24,8 @@  discard block
 block discarded – undo
24 24
     public function setUp()
25 25
     {
26 26
         $files = [
27
-            __DIR__.'/../Resources/records.yml',
28
-            __DIR__.'/../Resources/example.com.yml',
27
+            __DIR__ . '/../Resources/records.yml',
28
+            __DIR__ . '/../Resources/example.com.yml',
29 29
         ];
30 30
         $this->resolver = new YamlResolver($files);
31 31
     }
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     public function testParseException()
37 37
     {
38 38
         $this->expectException(ParseException::class);
39
-        new YamlResolver([__DIR__.'/../Resources/invalid_dns_records.json']);
39
+        new YamlResolver([__DIR__ . '/../Resources/invalid_dns_records.json']);
40 40
     }
41 41
 
42 42
     public function testResolveLegacyRecord()
Please login to merge, or discard this patch.
tests/Resolver/XmlResolverTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,9 +21,9 @@
 block discarded – undo
21 21
     public function setUp()
22 22
     {
23 23
         $files = [
24
-            __DIR__.'/../Resources/example.com.xml',
25
-            __DIR__.'/../Resources/test.com.xml',
26
-            __DIR__.'/../Resources/test2.com.xml',
24
+            __DIR__ . '/../Resources/example.com.xml',
25
+            __DIR__ . '/../Resources/test.com.xml',
26
+            __DIR__ . '/../Resources/test2.com.xml',
27 27
         ];
28 28
         $this->resolver = new XmlResolver($files);
29 29
     }
Please login to merge, or discard this patch.
tests/Resolver/StackableResolverTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -24,19 +24,19 @@
 block discarded – undo
24 24
     public function setUp()
25 25
     {
26 26
         $jsonFiles = [
27
-            __DIR__.'/../Resources/example.com.json',
28
-            __DIR__.'/../Resources/test_records.json',
27
+            __DIR__ . '/../Resources/example.com.json',
28
+            __DIR__ . '/../Resources/test_records.json',
29 29
         ];
30 30
 
31 31
         $xmlFiles = [
32
-            __DIR__.'/../Resources/example.com.xml',
33
-            __DIR__.'/../Resources/test.com.xml',
34
-            __DIR__.'/../Resources/test2.com.xml',
32
+            __DIR__ . '/../Resources/example.com.xml',
33
+            __DIR__ . '/../Resources/test.com.xml',
34
+            __DIR__ . '/../Resources/test2.com.xml',
35 35
         ];
36 36
 
37 37
         $ymlFiles = [
38
-            __DIR__.'/../Resources/records.yml',
39
-            __DIR__.'/../Resources/example.com.yml',
38
+            __DIR__ . '/../Resources/records.yml',
39
+            __DIR__ . '/../Resources/example.com.yml',
40 40
         ];
41 41
 
42 42
         $this->resolver = new StackableResolver([
Please login to merge, or discard this patch.
tests/Resolver/JsonResolverTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,8 @@
 block discarded – undo
23 23
     public function setUp()
24 24
     {
25 25
         $files = [
26
-            __DIR__.'/../Resources/example.com.json',
27
-            __DIR__.'/../Resources/test_records.json',
26
+            __DIR__ . '/../Resources/example.com.json',
27
+            __DIR__ . '/../Resources/test_records.json',
28 28
         ];
29 29
         $this->resolver = new JsonResolver($files, 300);
30 30
     }
Please login to merge, or discard this patch.
tests/EncoderTest.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -23,13 +23,13 @@  discard block
 block discarded – undo
23 23
     public function testEncodeDomainName()
24 24
     {
25 25
         $input_1 = 'www.example.com.';
26
-        $expectation_1 = chr(3).'www'.chr(7).'example'.chr(3).'com'."\0";
26
+        $expectation_1 = chr(3) . 'www' . chr(7) . 'example' . chr(3) . 'com' . "\0";
27 27
 
28 28
         $input_2 = '.';
29 29
         $expectation_2 = "\0";
30 30
 
31 31
         $input_3 = 'tld.';
32
-        $expectation_3 = chr(3).'tld'."\0";
32
+        $expectation_3 = chr(3) . 'tld' . "\0";
33 33
 
34 34
         $this->assertEquals($expectation_1, Encoder::encodeDomainName($input_1));
35 35
         $this->assertEquals($expectation_2, Encoder::encodeDomainName($input_2));
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             ->setQuestion(true);
50 50
 
51 51
         $expectation_1 =
52
-            chr(3).'www'.chr(7).'example'.chr(3).'com'."\0".
52
+            chr(3) . 'www' . chr(7) . 'example' . chr(3) . 'com' . "\0" .
53 53
             pack('nn', 1, 1);
54 54
 
55 55
         $input_2 = [];
@@ -60,11 +60,11 @@  discard block
 block discarded – undo
60 60
             ->setQuestion(2);
61 61
 
62 62
         $expectation_2 =
63
-            chr(6).'domain'.chr(3).'com'.chr(2).'au'."\0".
63
+            chr(6) . 'domain' . chr(3) . 'com' . chr(2) . 'au' . "\0" .
64 64
             pack('nn', 15, 1);
65 65
 
66 66
         $input_3 = [$input_1[0], $input_2[0]];
67
-        $expectation_3 = $expectation_1.$expectation_2;
67
+        $expectation_3 = $expectation_1 . $expectation_2;
68 68
 
69 69
         $this->assertEquals($expectation_1, Encoder::encodeResourceRecords($input_1));
70 70
         $this->assertEquals($expectation_2, Encoder::encodeResourceRecords($input_2));
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         $type = RecordTypeEnum::TYPE_MX;
87 87
         $ipAddress = '192.163.5.2';
88 88
 
89
-        $rdata = pack('n', $preference).$exchangeEncoded;
89
+        $rdata = pack('n', $preference) . $exchangeEncoded;
90 90
         $rdata2 = inet_pton($ipAddress);
91 91
 
92 92
         $decoded1 = (new ResourceRecord())
@@ -104,8 +104,8 @@  discard block
 block discarded – undo
104 104
             ->setType(RecordTypeEnum::TYPE_A)
105 105
             ->setRdata($ipAddress);
106 106
 
107
-        $encoded1 = $nameEncoded.pack('nnNn', $type, $class, $ttl, strlen($rdata)).$rdata;
108
-        $encoded2 = $nameEncoded.pack('nnNn', 1, $class, $ttl, strlen($rdata2)).$rdata2;
107
+        $encoded1 = $nameEncoded . pack('nnNn', $type, $class, $ttl, strlen($rdata)) . $rdata;
108
+        $encoded2 = $nameEncoded . pack('nnNn', 1, $class, $ttl, strlen($rdata2)) . $rdata2;
109 109
 
110 110
         $this->assertEquals($encoded1, Encoder::encodeResourceRecords([$decoded1]));
111 111
         $this->assertEquals($encoded2, Encoder::encodeResourceRecords([$decoded2]));
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         $encoded_2 = inet_pton($decoded_2);
124 124
 
125 125
         $decoded_5 = 'dns1.example.com.';
126
-        $encoded_5 = chr(4).'dns1'.chr(7).'example'.chr(3).'com'."\0";
126
+        $encoded_5 = chr(4) . 'dns1' . chr(7) . 'example' . chr(3) . 'com' . "\0";
127 127
 
128 128
         $decoded_6 = [
129 129
             'mname' => 'example.com.',
@@ -136,8 +136,8 @@  discard block
 block discarded – undo
136 136
         ];
137 137
 
138 138
         $encoded_6 =
139
-            chr(7).'example'.chr(3).'com'."\0".
140
-            chr(10).'postmaster'.chr(7).'example'.chr(3).'com'."\0".
139
+            chr(7) . 'example' . chr(3) . 'com' . "\0" .
140
+            chr(10) . 'postmaster' . chr(7) . 'example' . chr(3) . 'com' . "\0" .
141 141
             pack('NNNNN', 1970010188, 1800, 7200, 10800, 3600);
142 142
 
143 143
         $decoded_7 = [
@@ -145,10 +145,10 @@  discard block
 block discarded – undo
145 145
             'exchange' => 'mail.example.com.',
146 146
         ];
147 147
 
148
-        $encoded_7 = pack('n', 15).chr(4).'mail'.chr(7).'example'.chr(3).'com'."\0";
148
+        $encoded_7 = pack('n', 15) . chr(4) . 'mail' . chr(7) . 'example' . chr(3) . 'com' . "\0";
149 149
 
150 150
         $decoded_8 = 'This is a comment.';
151
-        $encoded_8 = chr(18).$decoded_8;
151
+        $encoded_8 = chr(18) . $decoded_8;
152 152
 
153 153
         $this->assertEquals($encoded_1, Encoder::encodeRdata(1, $decoded_1));
154 154
         $this->assertEquals($encoded_2, Encoder::encodeRdata(28, $decoded_2));
Please login to merge, or discard this patch.