samsonframework\container\definition\analyzer\annotation\AnnotationMethodAnalyzer::analyze()

Complexity

Conditions	4
Paths	6

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

0

<?php declare(strict_types=1);

    public function analyze(

        DefinitionAnalyzer $analyzer,

        \ReflectionMethod $reflectionMethod,

        ClassDefinition $classDefinition,

        MethodDefinition $methodDefinition = null

    ) {

        // Define property if not exists

        if (!$methodDefinition) {

            $methodDefinition = $classDefinition->defineMethod($reflectionMethod->getName());

Consider using $reflectionMethod->name. There is an issue with getName() and APC-enabled PHP versions.

        }

        // Resolve annotations

        $annotations = $this->reader->getMethodAnnotations($reflectionMethod);

        foreach ($annotations as $annotation) {

            if ($annotation instanceof ResolveMethodInterface) {

                $annotation->resolveMethod($analyzer, $reflectionMethod, $classDefinition, $methodDefinition);

$methodDefinition of type object<samsonframework\container\definition\MethodBuilderInterface> is not a sub-type of object<samsonframework\container\definition\MethodDefinition>. It seems like you assume a concrete implementation of the interface samsonframework\container\definition\MethodBuilderInterface to be always present.

            }

        }

    }

}