samsonframework\container\definition\analyzer\annotation\AnnotationMethodAnalyzer

Complexity

Total Complexity

4

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	analyze()	0	18	4

<?php declare(strict_types=1);

End of line character is invalid; expected "\n" but found "\r\n"

/**

 * Created by Ruslan Molodyko.

 * Date: 10.09.2016

 * Time: 17:48

 */

namespace samsonframework\container\definition\analyzer\annotation;


use samsonframework\container\definition\analyzer\DefinitionAnalyzer;

use samsonframework\container\definition\analyzer\MethodAnalyzerInterface;

use samsonframework\container\definition\ClassDefinition;

use samsonframework\container\definition\exception\MethodDefinitionAlreadyExistsException;

use samsonframework\container\definition\MethodDefinition;


class AnnotationMethodAnalyzer extends AbstractAnnotationAnalyzer implements MethodAnalyzerInterface

{

    /**

     * {@inheritdoc}

     * @throws MethodDefinitionAlreadyExistsException

     */

    public function analyze(

        DefinitionAnalyzer $analyzer,

        \ReflectionMethod $reflectionMethod,

        ClassDefinition $classDefinition,

        MethodDefinition $methodDefinition = null

    ) {

        // Define property if not exists

        if (!$methodDefinition) {

            $methodDefinition = $classDefinition->defineMethod($reflectionMethod->getName());

Consider using $reflectionMethod->name. There is an issue with getName() and APC-enabled PHP versions.

        }

        // Resolve annotations

        $annotations = $this->reader->getMethodAnnotations($reflectionMethod);

        foreach ($annotations as $annotation) {

            if ($annotation instanceof ResolveMethodInterface) {

                $annotation->resolveMethod($analyzer, $reflectionMethod, $classDefinition, $methodDefinition);

$methodDefinition of type object<samsonframework\container\definition\MethodBuilderInterface> is not a sub-type of object<samsonframework\container\definition\MethodDefinition>. It seems like you assume a concrete implementation of the interface samsonframework\container\definition\MethodBuilderInterface to be always present.

            }

        }

    }

}