Completed
Push — master ( c41372...e6a376 )
by Simon
04:10
created
tests/ShortlistTest.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@
 block discarded – undo
4 4
 {
5 5
     protected static $fixture_file = 'fixtures.yml';
6 6
 
7
-	public function testShortlistCreation()
8
-	{
7
+    public function testShortlistCreation()
8
+    {
9 9
         $shortlists = ShortList::get();
10 10
 
11 11
         $this->get('shortlist');
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         Session::start();
48 48
         $sessionID = session_id();
49 49
 
50
-        $response = $this->get('shortlist/add?id=' . $testpage->ID . '&type=Page&s=' . $sessionID . '&output=0');
50
+        $response = $this->get('shortlist/add?id='.$testpage->ID.'&type=Page&s='.$sessionID.'&output=0');
51 51
 
52 52
         $shortlist = DataObject::get_one('ShortList', array('SessionID' => $sessionID));
53 53
 
@@ -61,11 +61,11 @@  discard block
 block discarded – undo
61 61
         Session::start();
62 62
         $sessionID = session_id();
63 63
 
64
-        $this->get('shortlist/add?id=' . $testpage->ID . '&type=Page&s=' . $sessionID . '&output=0');
64
+        $this->get('shortlist/add?id='.$testpage->ID.'&type=Page&s='.$sessionID.'&output=0');
65 65
 
66 66
         $shortlist = DataObject::get_one('ShortList', array('SessionID' => $sessionID));
67 67
 
68
-        $this->get('shortlist/remove?id=' . $testpage->ID . '&type=Page&s=' . $sessionID . '&output=0');
68
+        $this->get('shortlist/remove?id='.$testpage->ID.'&type=Page&s='.$sessionID.'&output=0');
69 69
 
70 70
         $this->assertEquals($shortlist->ShortListItems()->Count(), 0);
71 71
     }
Please login to merge, or discard this patch.
code/extensions/ShortListPaginationExtension.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
  * Provides Pagination for shortlist controller
6 6
  */
7 7
 class ShortListPaginationExtension extends DataExtension {
8
-	/**
8
+    /**
9 9
      * Get a paginated list of the shortlist items.
10 10
      *
11 11
      * @return mixed the paginated list of items, or false if the list cannot be found.
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     public function nextPage()
38 38
     {
39 39
         if ($this->owner->list->CurrentPage() < $this->owner->list->TotalPages()) {
40
-            return '?page=' . ($this->owner->list->CurrentPage() + 1);
40
+            return '?page='.($this->owner->list->CurrentPage() + 1);
41 41
         }
42 42
 
43 43
         return false;
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     public function prevPage()
47 47
     {
48 48
         if ($this->owner->list->CurrentPage() > 1) {
49
-            return '?page=' . ($this->owner->list->CurrentPage() - 1);
49
+            return '?page='.($this->owner->list->CurrentPage() - 1);
50 50
         }
51 51
 
52 52
         return false;
Please login to merge, or discard this patch.
code/models/ShortList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
      */
82 82
     public function Link($action = null)
83 83
     {
84
-        return Config::inst()->get('ShortList', 'URLSegment') . $this->URL;
84
+        return Config::inst()->get('ShortList', 'URLSegment').$this->URL;
85 85
     }
86 86
 
87 87
     /**
Please login to merge, or discard this patch.
code/factories/RemoveFromshortlistAction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
             return false;
23 23
         }
24 24
 
25
-        $query = "ItemType = '" . $type . "' AND ItemID = " . $ID . ' AND ShortListID = ' . $shortlist->ID;
25
+        $query = "ItemType = '".$type."' AND ItemID = ".$ID.' AND ShortListID = '.$shortlist->ID;
26 26
 
27 27
         $item = DataObject::get_one('ShortListItem', $filter = $query);
28 28
 
Please login to merge, or discard this patch.
code/controllers/ShortListController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,12 +36,12 @@
 block discarded – undo
36 36
     public function index($request)
37 37
     {
38 38
         if (($shortlist = $this->getSessionShortList())) {
39
-            return $this->redirect(Config::inst()->get('ShortList', 'URLSegment') . $shortlist->URL);
39
+            return $this->redirect(Config::inst()->get('ShortList', 'URLSegment').$shortlist->URL);
40 40
         } else {
41 41
             $CrawlerDetect = new CrawlerDetect;
42 42
 
43 43
             // Check the user agent of the current 'visitor'
44
-            if($CrawlerDetect->isCrawler()) {
44
+            if ($CrawlerDetect->isCrawler()) {
45 45
                 return $this->httpError(403);
46 46
             }
47 47
 
Please login to merge, or discard this patch.