Completed
Push — master ( 24dcff...a3e8b1 )
by Simon
02:24
created
code/controllers/ShortListController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
     public function index($request)
36 36
     {
37 37
         if (($shortlist = $this->getSessionShortList())) {
38
-            return $this->redirect(Config::inst()->get('ShortList', 'URLSegment') . $shortlist->URL);
38
+            return $this->redirect(Config::inst()->get('ShortList', 'URLSegment').$shortlist->URL);
39 39
         } else {
40 40
             /*
41 41
 if (!ShortList::isBrowser()) {
Please login to merge, or discard this patch.
code/factories/RemoveFromshortlistAction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
             return false;
23 23
         }
24 24
 
25
-        $query = "ItemType = '" . $type . "' AND ItemID = " . $ID . ' AND ShortListID = ' . $shortlist->ID;
25
+        $query = "ItemType = '".$type."' AND ItemID = ".$ID.' AND ShortListID = '.$shortlist->ID;
26 26
 
27 27
         $item = DataObject::get_one('ShortListItem', $filter = $query);
28 28
 
Please login to merge, or discard this patch.
tests/ShortlistTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         Session::start();
48 48
         $sessionID = session_id();
49 49
 
50
-        $response = $this->get('shortlist/add?id=' . $testpage->ID . '&type=Page&s=' . $sessionID . '&output=0');
50
+        $response = $this->get('shortlist/add?id='.$testpage->ID.'&type=Page&s='.$sessionID.'&output=0');
51 51
 
52 52
         $shortlist = DataObject::get_one('ShortList', array('SessionID' => $sessionID));
53 53
 
@@ -61,11 +61,11 @@  discard block
 block discarded – undo
61 61
         Session::start();
62 62
         $sessionID = session_id();
63 63
 
64
-        $this->get('shortlist/add?id=' . $testpage->ID . '&type=Page&s=' . $sessionID . '&output=0');
64
+        $this->get('shortlist/add?id='.$testpage->ID.'&type=Page&s='.$sessionID.'&output=0');
65 65
 
66 66
         $shortlist = DataObject::get_one('ShortList', array('SessionID' => $sessionID));
67 67
 
68
-        $this->get('shortlist/remove?id=' . $testpage->ID . '&type=Page&s=' . $sessionID . '&output=0');
68
+        $this->get('shortlist/remove?id='.$testpage->ID.'&type=Page&s='.$sessionID.'&output=0');
69 69
 
70 70
         $this->assertEquals($shortlist->ShortListItems()->Count(), 0);
71 71
     }
Please login to merge, or discard this patch.