Inspection of "Sort strings by codepoint, after they've been spli..." - s9e/RegexpBuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e62d73...091f5a )

by Josh

created 2016-09-14 07:56 UTC

Status

Indentation +119 added lines, -119 removed lines patch added patch discarded remove patch

@@ -18,123 +18,123 @@
 block discarded – undo
 
 class Builder
 {
-	/**
-	* @var InputInterface
-	*/
-	protected $input;
-
-	/**
-	* @var Runner
-	*/
-	protected $runner;
-
-	/**
-	* @var Serializer
-	*/
-	protected $serializer;
-
-	/**
-	* @param array $config
-	*/
-	public function __construct(array $config = [])
-	{
-		$config = $this->getConfig($config);
-
-		$this->input      = $config['input'];
-		$this->runner     = $config['runner'];
-		$this->serializer = new Serializer($config['output'], $config['escaper']);
-	}
-
-	/**
-	* Build and return a regular expression that matches all of the given strings
-	*
-	* @param  string[] $strings Literal strings to be matched
-	* @return string            Regular expression (without delimiters)
-	*/
-	public function build(array $strings)
-	{
-		$strings = array_unique($strings);
-		if ($strings === [''])
-		{
-			return '';
-		}
-
-		$strings = $this->splitStrings($strings);
-		usort($strings, __CLASS__ . '::compareStrings');
-		$strings = $this->runner->run($strings);
-
-		return $this->serializer->serializeStrings($strings);
-	}
-
-	/**
-	* Compare two split strings
-	*
-	* Will sort strings in ascending order
-	*
-	* @param  integer[] $a
-	* @param  integer[] $b
-	* @return integer
-	*/
-	protected function compareStrings(array $a, array $b)
-	{
-		foreach ($b as $k => $v)
-		{
-			if (!isset($a[$k]) || $a[$k] < $b[$k])
-			{
-				// A is shorter or A[k] is less than B[k]. Sort A before B
-				return -1;
-			}
-			if ($a[$k] > $b[$k])
-			{
-				// A[k] comes after B[k]. Sort A after B
-				return 1;
-			}
-		}
-
-		// A is longer than B. Sort A after B
-		return 1;
-	}
-
-	/**
-	* Build the full config array based on given input
-	*
-	* @param  array $config Sparse config
-	* @return array         Full config
-	*/
-	protected function getConfig(array $config)
-	{
-		$config += [
-			'delimiter' => '/',
-			'input'     => 'Bytes',
-			'output'    => 'Bytes'
-		];
-		$config['escaper'] = new Escaper($config['delimiter']);
-
-		$className = __NAMESPACE__ . '\\Input\\' . $config['input'];
-		$config['input'] = new $className;
-
-		$className = __NAMESPACE__ . '\\Output\\' . $config['output'];
-		$config['output'] = new $className;
-
-		$config['runner'] = new Runner;
-		$config['runner']->addPass(new MergePrefix);
-		$config['runner']->addPass(new GroupSingleCharacters);
-		$config['runner']->addPass(new Recurse($config['runner']));
-		$config['runner']->addPass(new PromoteSingleStrings);
-		$config['runner']->addPass(new MergeSuffix);
-		$config['runner']->addPass(new CoalesceSingleCharacterPrefix);
-
-		return $config;
-	}
-
-	/**
-	* Split all given strings by character
-	*
-	* @param  string[] $strings List of strings
-	* @return array[]           List of arrays
-	*/
-	protected function splitStrings(array $strings)
-	{
-		return array_map([$this->input, 'split'], $strings);
-	}
+    /**
+     * @var InputInterface
+     */
+    protected $input;
+
+    /**
+     * @var Runner
+     */
+    protected $runner;
+
+    /**
+     * @var Serializer
+     */
+    protected $serializer;
+
+    /**
+     * @param array $config
+     */
+    public function __construct(array $config = [])
+    {
+        $config = $this->getConfig($config);
+
+        $this->input      = $config['input'];
+        $this->runner     = $config['runner'];
+        $this->serializer = new Serializer($config['output'], $config['escaper']);
+    }
+
+    /**
+     * Build and return a regular expression that matches all of the given strings
+     *
+     * @param  string[] $strings Literal strings to be matched
+     * @return string            Regular expression (without delimiters)
+     */
+    public function build(array $strings)
+    {
+        $strings = array_unique($strings);
+        if ($strings === [''])
+        {
+            return '';
+        }
+
+        $strings = $this->splitStrings($strings);
+        usort($strings, __CLASS__ . '::compareStrings');
+        $strings = $this->runner->run($strings);
+
+        return $this->serializer->serializeStrings($strings);
+    }
+
+    /**
+     * Compare two split strings
+     *
+     * Will sort strings in ascending order
+     *
+     * @param  integer[] $a
+     * @param  integer[] $b
+     * @return integer
+     */
+    protected function compareStrings(array $a, array $b)
+    {
+        foreach ($b as $k => $v)
+        {
+            if (!isset($a[$k]) || $a[$k] < $b[$k])
+            {
+                // A is shorter or A[k] is less than B[k]. Sort A before B
+                return -1;
+            }
+            if ($a[$k] > $b[$k])
+            {
+                // A[k] comes after B[k]. Sort A after B
+                return 1;
+            }
+        }
+
+        // A is longer than B. Sort A after B
+        return 1;
+    }
+
+    /**
+     * Build the full config array based on given input
+     *
+     * @param  array $config Sparse config
+     * @return array         Full config
+     */
+    protected function getConfig(array $config)
+    {
+        $config += [
+            'delimiter' => '/',
+            'input'     => 'Bytes',
+            'output'    => 'Bytes'
+        ];
+        $config['escaper'] = new Escaper($config['delimiter']);
+
+        $className = __NAMESPACE__ . '\\Input\\' . $config['input'];
+        $config['input'] = new $className;
+
+        $className = __NAMESPACE__ . '\\Output\\' . $config['output'];
+        $config['output'] = new $className;
+
+        $config['runner'] = new Runner;
+        $config['runner']->addPass(new MergePrefix);
+        $config['runner']->addPass(new GroupSingleCharacters);
+        $config['runner']->addPass(new Recurse($config['runner']));
+        $config['runner']->addPass(new PromoteSingleStrings);
+        $config['runner']->addPass(new MergeSuffix);
+        $config['runner']->addPass(new CoalesceSingleCharacterPrefix);
+
+        return $config;
+    }
+
+    /**
+     * Split all given strings by character
+     *
+     * @param  string[] $strings List of strings
+     * @return array[]           List of arrays
+     */
+    protected function splitStrings(array $strings)
+    {
+        return array_map([$this->input, 'split'], $strings);
+    }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -18,123 +18,123 @@
		block discarded – undo
18	18
19	19	class Builder
20	20	{
21		- /**
22		- * @var InputInterface
23		- */
24		- protected $input;
25		-
26		- /**
27		- * @var Runner
28		- */
29		- protected $runner;
30		-
31		- /**
32		- * @var Serializer
33		- */
34		- protected $serializer;
35		-
36		- /**
37		- * @param array $config
38		- */
39		- public function __construct(array $config = [])
40		- {
41		- $config = $this->getConfig($config);
42		-
43		- $this->input = $config['input'];
44		- $this->runner = $config['runner'];
45		- $this->serializer = new Serializer($config['output'], $config['escaper']);
46		- }
47		-
48		- /**
49		- * Build and return a regular expression that matches all of the given strings
50		- *
51		- * @param string[] $strings Literal strings to be matched
52		- * @return string Regular expression (without delimiters)
53		- */
54		- public function build(array $strings)
55		- {
56		- $strings = array_unique($strings);
57		- if ($strings === [''])
58		- {
59		- return '';
60		- }
61		-
62		- $strings = $this->splitStrings($strings);
63		- usort($strings, __CLASS__ . '::compareStrings');
64		- $strings = $this->runner->run($strings);
65		-
66		- return $this->serializer->serializeStrings($strings);
67		- }
68		-
69		- /**
70		- * Compare two split strings
71		- *
72		- * Will sort strings in ascending order
73		- *
74		- * @param integer[] $a
75		- * @param integer[] $b
76		- * @return integer
77		- */
78		- protected function compareStrings(array $a, array $b)
79		- {
80		- foreach ($b as $k => $v)
81		- {
82		- if (!isset($a[$k]) \|\| $a[$k] < $b[$k])
83		- {
84		- // A is shorter or A[k] is less than B[k]. Sort A before B
85		- return -1;
86		- }
87		- if ($a[$k] > $b[$k])
88		- {
89		- // A[k] comes after B[k]. Sort A after B
90		- return 1;
91		- }
92		- }
93		-
94		- // A is longer than B. Sort A after B
95		- return 1;
96		- }
97		-
98		- /**
99		- * Build the full config array based on given input
100		- *
101		- * @param array $config Sparse config
102		- * @return array Full config
103		- */
104		- protected function getConfig(array $config)
105		- {
106		- $config += [
107		- 'delimiter' => '/',
108		- 'input' => 'Bytes',
109		- 'output' => 'Bytes'
110		- ];
111		- $config['escaper'] = new Escaper($config['delimiter']);
112		-
113		- $className = __NAMESPACE__ . '\\Input\\' . $config['input'];
114		- $config['input'] = new $className;
115		-
116		- $className = __NAMESPACE__ . '\\Output\\' . $config['output'];
117		- $config['output'] = new $className;
118		-
119		- $config['runner'] = new Runner;
120		- $config['runner']->addPass(new MergePrefix);
121		- $config['runner']->addPass(new GroupSingleCharacters);
122		- $config['runner']->addPass(new Recurse($config['runner']));
123		- $config['runner']->addPass(new PromoteSingleStrings);
124		- $config['runner']->addPass(new MergeSuffix);
125		- $config['runner']->addPass(new CoalesceSingleCharacterPrefix);
126		-
127		- return $config;
128		- }
129		-
130		- /**
131		- * Split all given strings by character
132		- *
133		- * @param string[] $strings List of strings
134		- * @return array[] List of arrays
135		- */
136		- protected function splitStrings(array $strings)
137		- {
138		- return array_map([$this->input, 'split'], $strings);
139		- }
	21	+ /**
	22	+ * @var InputInterface
	23	+ */
	24	+ protected $input;
	25	+
	26	+ /**
	27	+ * @var Runner
	28	+ */
	29	+ protected $runner;
	30	+
	31	+ /**
	32	+ * @var Serializer
	33	+ */
	34	+ protected $serializer;
	35	+
	36	+ /**
	37	+ * @param array $config
	38	+ */
	39	+ public function __construct(array $config = [])
	40	+ {
	41	+ $config = $this->getConfig($config);
	42	+
	43	+ $this->input = $config['input'];
	44	+ $this->runner = $config['runner'];
	45	+ $this->serializer = new Serializer($config['output'], $config['escaper']);
	46	+ }
	47	+
	48	+ /**
	49	+ * Build and return a regular expression that matches all of the given strings
	50	+ *
	51	+ * @param string[] $strings Literal strings to be matched
	52	+ * @return string Regular expression (without delimiters)
	53	+ */
	54	+ public function build(array $strings)
	55	+ {
	56	+ $strings = array_unique($strings);
	57	+ if ($strings === [''])
	58	+ {
	59	+ return '';
	60	+ }
	61	+
	62	+ $strings = $this->splitStrings($strings);
	63	+ usort($strings, __CLASS__ . '::compareStrings');
	64	+ $strings = $this->runner->run($strings);
	65	+
	66	+ return $this->serializer->serializeStrings($strings);
	67	+ }
	68	+
	69	+ /**
	70	+ * Compare two split strings
	71	+ *
	72	+ * Will sort strings in ascending order
	73	+ *
	74	+ * @param integer[] $a
	75	+ * @param integer[] $b
	76	+ * @return integer
	77	+ */
	78	+ protected function compareStrings(array $a, array $b)
	79	+ {
	80	+ foreach ($b as $k => $v)
	81	+ {
	82	+ if (!isset($a[$k]) \|\| $a[$k] < $b[$k])
	83	+ {
	84	+ // A is shorter or A[k] is less than B[k]. Sort A before B
	85	+ return -1;
	86	+ }
	87	+ if ($a[$k] > $b[$k])
	88	+ {
	89	+ // A[k] comes after B[k]. Sort A after B
	90	+ return 1;
	91	+ }
	92	+ }
	93	+
	94	+ // A is longer than B. Sort A after B
	95	+ return 1;
	96	+ }
	97	+
	98	+ /**
	99	+ * Build the full config array based on given input
	100	+ *
	101	+ * @param array $config Sparse config
	102	+ * @return array Full config
	103	+ */
	104	+ protected function getConfig(array $config)
	105	+ {
	106	+ $config += [
	107	+ 'delimiter' => '/',
	108	+ 'input' => 'Bytes',
	109	+ 'output' => 'Bytes'
	110	+ ];
	111	+ $config['escaper'] = new Escaper($config['delimiter']);
	112	+
	113	+ $className = __NAMESPACE__ . '\\Input\\' . $config['input'];
	114	+ $config['input'] = new $className;
	115	+
	116	+ $className = __NAMESPACE__ . '\\Output\\' . $config['output'];
	117	+ $config['output'] = new $className;
	118	+
	119	+ $config['runner'] = new Runner;
	120	+ $config['runner']->addPass(new MergePrefix);
	121	+ $config['runner']->addPass(new GroupSingleCharacters);
	122	+ $config['runner']->addPass(new Recurse($config['runner']));
	123	+ $config['runner']->addPass(new PromoteSingleStrings);
	124	+ $config['runner']->addPass(new MergeSuffix);
	125	+ $config['runner']->addPass(new CoalesceSingleCharacterPrefix);
	126	+
	127	+ return $config;
	128	+ }
	129	+
	130	+ /**
	131	+ * Split all given strings by character
	132	+ *
	133	+ * @param string[] $strings List of strings
	134	+ * @return array[] List of arrays
	135	+ */
	136	+ protected function splitStrings(array $strings)
	137	+ {
	138	+ return array_map([$this->input, 'split'], $strings);
	139	+ }
140	140	}
141	141	\ No newline at end of file

s9e / RegexpBuilder

Push — master ( e62d73...091f5a )

Status

Category

Indentation +119 added lines, -119 removed lines patch added patch discarded remove patch