NonCompliantDecoder::decodeDictionary() - Code Metrics - Inspection of "Added support for decoding non-compliant input" - s9e/Bencode - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 71dbb5...c2c480 )

by Josh

created 2021-09-18 16:05 UTC

NonCompliantDecoder::decodeDictionary() A

↳ Parent: NonCompliantDecoder

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	7
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	12
ccs	8
cts	8
cp	1
crap	2
rs	10

<?php declare(strict_types=1);

/**
* @package   s9e\Bencode
* @copyright Copyright (c) 2014-2021 The s9e authors
* @license   http://www.opensource.org/licenses/mit-license.php The MIT License
*/
namespace s9e\Bencode;

use ArrayObject;
use const SORT_STRING, false, true;
use function strcmp;

class NonCompliantDecoder extends Decoder
{
	/**
	* @var string Whether current dictionary needs to be sorted
	*/
	protected bool $sortDictionary = false;

	protected function checkDictionaryCompliance(string $key, string $lastKey): void
	{
		if (!$this->sortDictionary && strcmp($key, $lastKey) < 0)
		{
			$this->sortDictionary = true;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
		}
	}

	protected function complianceError(string $message, int $offset): void
	{
		// Do nothing
	}

	protected function decodeDictionary(): ArrayObject
	{
		$previousState        = $this->sortDictionary;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
		$this->sortDictionary = false;
		$dictionary           = parent::decodeDictionary();
		if ($this->sortDictionary)
		{
			$dictionary->ksort(SORT_STRING);
		}
		$this->sortDictionary = $previousState;

		return $dictionary;
	}
}

1		<?php declare(strict_types=1);
2
3		/**
4		* @package s9e\Bencode
5		* @copyright Copyright (c) 2014-2021 The s9e authors
6		* @license http://www.opensource.org/licenses/mit-license.php The MIT License
7		*/
8		namespace s9e\Bencode;
9
10		use ArrayObject;
11		use const SORT_STRING, false, true;
12		use function strcmp;
13
14		class NonCompliantDecoder extends Decoder
15		{
16		/**
17		* @var string Whether current dictionary needs to be sorted
18		*/
19		protected bool $sortDictionary = false;
20
21	4	protected function checkDictionaryCompliance(string $key, string $lastKey): void
22		{
23	4	if (!$this->sortDictionary && strcmp($key, $lastKey) < 0)
24		{
25	2	$this->sortDictionary = true;
		0 ignored issues – show Documentation Bug introduced 2021-09-18 16:07 UTC by Report Bug Copy Issue Report The property `$sortDictionary` was declared of type `string`, but `true` is of type `true`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
26		}
27	4	}
28
29	7	protected function complianceError(string $message, int $offset): void
30		{
31		// Do nothing
32	7	}
33
34	4	protected function decodeDictionary(): ArrayObject
35		{
36	4	$previousState = $this->sortDictionary;
		0 ignored issues – show Documentation Bug introduced 2021-09-18 16:07 UTC by Report Bug Copy Issue Report The property `$sortDictionary` was declared of type `string`, but `$this->sortDictionary` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
37	4	$this->sortDictionary = false;
38	4	$dictionary = parent::decodeDictionary();
39	4	if ($this->sortDictionary)
40		{
41	2	$dictionary->ksort(SORT_STRING);
42		}
43	4	$this->sortDictionary = $previousState;
44
45	4	return $dictionary;
46		}
47		}

s9e / Bencode

Push — master ( 71dbb5...c2c480 )

NonCompliantDecoder::decodeDictionary() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like