s9e\Bencode\NonCompliantDecoder

Complexity

Total Complexity

6

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	decodeDictionary()	0	12	2
A	complianceError()	0	2	1
A	checkDictionaryCompliance()	0	5	3

<?php declare(strict_types=1);

/**
* @package   s9e\Bencode
* @copyright Copyright (c) 2014-2021 The s9e authors
* @license   http://www.opensource.org/licenses/mit-license.php The MIT License
*/
namespace s9e\Bencode;

use ArrayObject;
use const SORT_STRING, false, true;
use function strcmp;

class NonCompliantDecoder extends Decoder
{
	/**
	* @var string Whether current dictionary needs to be sorted
	*/
	protected bool $sortDictionary = false;

	protected function checkDictionaryCompliance(string $key, string $lastKey): void
	{
		if (!$this->sortDictionary && strcmp($key, $lastKey) < 0)
		{
			$this->sortDictionary = true;

The property $sortDictionary was declared of type string, but true is of type true. Maybe add a type cast?

		}
	}

	protected function complianceError(string $message, int $offset): void
	{
		// Do nothing
	}

	protected function decodeDictionary(): ArrayObject
	{
		$previousState        = $this->sortDictionary;

The property $sortDictionary was declared of type string, but $this->sortDictionary is of type boolean. Maybe add a type cast?

		$this->sortDictionary = false;
		$dictionary           = parent::decodeDictionary();
		if ($this->sortDictionary)
		{
			$dictionary->ksort(SORT_STRING);
		}
		$this->sortDictionary = $previousState;

		return $dictionary;
	}
}