Rudolf\Modules\Appearance\Menu\Navigation::create()

Complexity

Conditions	11
Paths	43

Size

Total Lines	126
Code Lines	59

Duplication

Lines	19
Ratio	15.08 %

Importance

Changes

0

<?php
    public function create()
    {
        $root_id = $this->getRootID();
        $items = $this->getItems();
        $nesting = $this->getNesting();

        if (empty($items)) {
            return false;
        }

        foreach ($items as $item) {

This code seems to be duplicated across your project.

            if (null !== $item->getParentId()) {
                $children[$item->getParentId()][] = $item;

$children was never initialized. Although not strictly required by PHP, it is generally a good practice to add $children = array(); before regardless.

            }
        }

        // loop will be false if the root has no children (i.e., an empty menu!)
        $loop = !empty($children[$root_id]);

        // initializing $parent as the root
        $parent = $root_id;
        $parent_stack = array();

        $html = [];

        // HTML wrapper for the menu (open)
        $html[] = '<ul>';

        $html[] = !empty($before['first_root_li']) ? str_repeat("\t", $nesting + 1).$before['first_root_li'] : '';

The variable $before seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        // loop
        while ($loop && (($item = each($children[$parent])) || ($parent > $root_id))) {

The variable $children does not seem to be defined for all execution paths leading up to this point.

            if (is_object($item['value'])) {

This code seems to be duplicated across your project.

                /**
                 * @var MenuItem $obj
                 */
                $obj = $item['value'];
                $item = [
                    'id' => $obj->getId(),
                    'parent_id' => $obj->getParentId(),
                    'title' => $obj->getTitle(),
                    'slug' => $obj->getSlug(),
                    'caption' => $obj->getCaption(),
                    'position' => $obj->getPosition(),
                ];
            }

            // HTML for menu item containing children (close)
            if ($item === false) {
                $parent = array_pop($parent_stack);
                $html[] = str_repeat("\t", (count($parent_stack) + 1) * 2 + $nesting).'</ul>';
                $html[] = str_repeat("\t", (count($parent_stack) + 1) * 2 - 1 + $nesting).'</li>';
            }

            // HTML for menu item containing children (open)
            elseif (!empty($children[$item['id']])) {
                $tab = str_repeat("\t", (count($parent_stack) + 1) * 2 - 1 + $nesting);

                /*
                 * <li> with <ul>
                 */
                $html[] = sprintf(
                    '%1$s'.'<li>%2$s - <a'.'%3$s'.' href="'.'%4$s'.'">%5$s</a> – pozycja: %6$s'.
                    ' <a href="/admin/appearance/menu/edit/%2$s" class="btn btn-primary btn-xs">Edytuj</a>'.
                    ' <a href="/admin/appearance/menu/del/%2$s" class="btn btn-danger btn-xs">Usuń</a>',
                    # %1$s tabulation
                    $tab,

                    $item['id'],

                    # %2$s a title=""
                    $this->isAttribute('title', $item['caption']),

                    # %3$s a href=""
                    $item['slug'],

                    # %4$s text inside item
                    $item['title'],

                    $item['position']
                );

                /*
                 * sub <ul> in <li>
                 */
                $html[] = sprintf(
                    '%1$s'.'<ul>',
                    # %1$s tabulation
                    $tab."\t"
                );

                $parent_stack[] = $item['parent_id'];
                $parent         = $item['id'];
            }

            // HTML for menu item with no children (aka "leaf")
            else {
                $html[] = sprintf(
                    '%1$s'.'<li>%2$s - <a'.'%3$s'.' href="'.'%4$s'.'">%5$s</a> – pozycja: %6$s'.
                    ' <a href="/admin/appearance/menu/edit/%2$s" class="btn btn-primary btn-xs">Edytuj</a>'.
                    ' <a href="/admin/appearance/menu/del/%2$s" class="btn btn-danger btn-xs">Edytuj</a>',

                    # %1$s tabulation
                    str_repeat("\t", (count($parent_stack) + 1) * 2 - 1 + $nesting),

                    $item['id'],

                    # %2$s a title=""
                    $this->isAttribute('title', $item['caption']),

                    # %3$s a href=""
                    $item['slug'],

                    # %4$s text inside item
                    $item['title'],

                    $item['position']
                );
            }
        }

        // HTML wrapper for the menu (close)
        $html[] = str_repeat("\t", $nesting).'</ul>';

        return implode("\n", array_filter($html))."\n";
    }
}