Rudolf\Modules\Appearance\Menu\Navigation

Complexity

Total Complexity

24

Size/Duplication

Total Lines	250
Duplicated Lines	12 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	setRootID()	0	4	1
A	getRootID()	0	4	1
A	setType()	0	4	1
A	getType()	0	4	1
A	setItems()	0	4	1
A	getItems()	0	4	1
A	setNesting()	0	4	1
A	getNesting()	0	4	1
B	isAttribute()	11	11	5
C	create()	19	126	11

<?php

namespace Rudolf\Modules\Appearance\Menu;

use Rudolf\Component\Helpers\Navigation\MenuItem;

This use statement conflicts with another class in this namespace, Rudolf\Modules\Appearance\Menu\MenuItem.

use Rudolf\Component\Helpers\Navigation\MenuItemCollection;

class Navigation
{
    /**
     * @var int
     */
    private $rootID = 0;

    /**
     * @var string
     */
    private $type;

    /**
     * @var MenuItemCollection
     */
    private $menuItemsCollection;
    /**
     * @var int
     */
    private $nesting;

    /**
     * Set root ID.
     *
     * @param int $id ID of element to start create tree. Set 0 to create full tree
     */
    public function setRootID($id)
    {
        $this->rootID = (int) $id;
    }

    /**
     * @return int
     */
    public function getRootID()
    {
        return $this->rootID;
    }

    /**
     * Menu type defined in menu_types table.
     *
     * @param string $type
     */
    public function setType($type)
    {
        $this->type = $type;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * Set items.
     *
     * @param MenuItemCollection $items
     */
    public function setItems(MenuItemCollection $items)
    {
        $this->menuItemsCollection = $items;
    }

    /**
     * @return array
     */
    public function getItems()
    {
        return $this->menuItemsCollection->getByType($this->getType());
    }

    /**
     * Set generated menu code nesting.
     *
     * @param int $nesting
     */
    public function setNesting($nesting)
    {
        $this->nesting = $nesting;
    }

    /**
     * @return mixed
     */
    public function getNesting()
    {
        return $this->nesting;
    }

    /**
     * Put value is not empty.
     *
     * @param string       $attribute
     * @param string|array $value
     *
     * @return string
     */
    private function isAttribute($attribute, $value)

This method seems to be duplicated in your project.

    {
        if (is_array($value)) {
            array_filter($value);
            $value = trim(implode(' ', $value));

            return !empty($value) ? ' '.$attribute.'="'.$value.'"' : '';
        }

        return (isset($value) and !empty($value)) ? ' '.$attribute.'="'.trim($value).'"' : '';

Using logical operators such as and instead of && is generally not recommended.

    }


    /**
     * Menu creator.
     *
     * @link http://pastebin.com/GAFvSew4
     *
     * @author J. Bruni - original author
     *
     * @return string|bool
     */
    public function create()
    {
        $root_id = $this->getRootID();
        $items = $this->getItems();
        $nesting = $this->getNesting();

        if (empty($items)) {
            return false;
        }

        foreach ($items as $item) {

This code seems to be duplicated across your project.

            if (null !== $item->getParentId()) {
                $children[$item->getParentId()][] = $item;

$children was never initialized. Although not strictly required by PHP, it is generally a good practice to add $children = array(); before regardless.

            }
        }

        // loop will be false if the root has no children (i.e., an empty menu!)
        $loop = !empty($children[$root_id]);

        // initializing $parent as the root
        $parent = $root_id;
        $parent_stack = array();

        $html = [];

        // HTML wrapper for the menu (open)
        $html[] = '<ul>';

        $html[] = !empty($before['first_root_li']) ? str_repeat("\t", $nesting + 1).$before['first_root_li'] : '';

The variable $before seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        // loop
        while ($loop && (($item = each($children[$parent])) || ($parent > $root_id))) {

The variable $children does not seem to be defined for all execution paths leading up to this point.

            if (is_object($item['value'])) {

This code seems to be duplicated across your project.

                /**
                 * @var MenuItem $obj
                 */
                $obj = $item['value'];
                $item = [
                    'id' => $obj->getId(),
                    'parent_id' => $obj->getParentId(),
                    'title' => $obj->getTitle(),
                    'slug' => $obj->getSlug(),
                    'caption' => $obj->getCaption(),
                    'position' => $obj->getPosition(),
                ];
            }

            // HTML for menu item containing children (close)
            if ($item === false) {
                $parent = array_pop($parent_stack);
                $html[] = str_repeat("\t", (count($parent_stack) + 1) * 2 + $nesting).'</ul>';
                $html[] = str_repeat("\t", (count($parent_stack) + 1) * 2 - 1 + $nesting).'</li>';
            }

            // HTML for menu item containing children (open)
            elseif (!empty($children[$item['id']])) {
                $tab = str_repeat("\t", (count($parent_stack) + 1) * 2 - 1 + $nesting);

                /*
                 * <li> with <ul>
                 */
                $html[] = sprintf(
                    '%1$s'.'<li>%2$s - <a'.'%3$s'.' href="'.'%4$s'.'">%5$s</a> – pozycja: %6$s'.
                    ' <a href="/admin/appearance/menu/edit/%2$s" class="btn btn-primary btn-xs">Edytuj</a>'.
                    ' <a href="/admin/appearance/menu/del/%2$s" class="btn btn-danger btn-xs">Usuń</a>',
                    # %1$s tabulation
                    $tab,

                    $item['id'],

                    # %2$s a title=""
                    $this->isAttribute('title', $item['caption']),

                    # %3$s a href=""
                    $item['slug'],

                    # %4$s text inside item
                    $item['title'],

                    $item['position']
                );

                /*
                 * sub <ul> in <li>
                 */
                $html[] = sprintf(
                    '%1$s'.'<ul>',
                    # %1$s tabulation
                    $tab."\t"
                );

                $parent_stack[] = $item['parent_id'];
                $parent         = $item['id'];
            }

            // HTML for menu item with no children (aka "leaf")
            else {
                $html[] = sprintf(
                    '%1$s'.'<li>%2$s - <a'.'%3$s'.' href="'.'%4$s'.'">%5$s</a> – pozycja: %6$s'.
                    ' <a href="/admin/appearance/menu/edit/%2$s" class="btn btn-primary btn-xs">Edytuj</a>'.
                    ' <a href="/admin/appearance/menu/del/%2$s" class="btn btn-danger btn-xs">Edytuj</a>',

                    # %1$s tabulation
                    str_repeat("\t", (count($parent_stack) + 1) * 2 - 1 + $nesting),

                    $item['id'],

                    # %2$s a title=""
                    $this->isAttribute('title', $item['caption']),

                    # %3$s a href=""
                    $item['slug'],

                    # %4$s text inside item
                    $item['title'],

                    $item['position']
                );
            }
        }

        // HTML wrapper for the menu (close)
        $html[] = str_repeat("\t", $nesting).'</ul>';

        return implode("\n", array_filter($html))."\n";
    }
}