Conditions | 34 |
Paths | 22 |
Total Lines | 59 |
Code Lines | 48 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
56 | public function getBuildingInfo($buildingNumber, $info, $level = 0, $sup = 'default') { |
||
57 | if($this->isABuilding($buildingNumber)) { |
||
58 | if (in_array($info, ['name', 'column', 'frenchName', 'imageLink', 'description'])) { |
||
59 | return OrbitalBaseResource::$building[$buildingNumber][$info]; |
||
60 | } elseif ($info == 'techno') { |
||
61 | if (in_array($buildingNumber, array(3,4,6,8,9))) { |
||
62 | return OrbitalBaseResource::$building[$buildingNumber][$info]; |
||
63 | } else { |
||
64 | return -1; |
||
65 | } |
||
66 | } elseif ($info == 'maxLevel') { |
||
67 | # $level is the type of the base |
||
68 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level]; |
||
69 | |||
70 | } elseif ($info == 'level') { |
||
71 | if ($level <= 0 OR $level > count(OrbitalBaseResource::$building[$buildingNumber]['level'])) { |
||
72 | return FALSE; |
||
73 | } |
||
74 | if ($sup == 'time') { |
||
75 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][0]; |
||
76 | } elseif($sup == 'resourcePrice') { |
||
77 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][1]; |
||
78 | } elseif($sup == 'points') { |
||
79 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][2]; |
||
80 | } else { |
||
81 | if ($sup == 'nbQueues') { |
||
82 | if ($buildingNumber == 0 OR $buildingNumber == 2 OR $buildingNumber == 3 OR $buildingNumber == 5) { |
||
83 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][3]; |
||
84 | } |
||
85 | } elseif ($sup == 'storageSpace') { |
||
86 | if ($buildingNumber == 7) { |
||
87 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][3]; |
||
88 | } elseif ($buildingNumber == 2 OR $buildingNumber == 3) { |
||
89 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][4]; |
||
90 | } |
||
91 | } elseif ($sup == 'refiningCoefficient' AND $buildingNumber == 1) { |
||
92 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][3]; |
||
93 | } elseif ($sup == 'releasedShip' AND ($buildingNumber == 2 OR $buildingNumber == 3)) { |
||
94 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][5]; |
||
95 | } elseif ($sup == 'releasedShip' AND $buildingNumber == 4) { |
||
96 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][4]; |
||
97 | } elseif ($sup == 'nbCommercialShip' AND $buildingNumber == 6) { |
||
98 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][3]; |
||
99 | } elseif ($sup == 'nbRecyclers' AND $buildingNumber == 8) { |
||
100 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][3]; |
||
101 | } elseif ($sup == 'nbRoutesMax' AND $buildingNumber == 9) { |
||
102 | return OrbitalBaseResource::$building[$buildingNumber][$info][$level-1][3]; |
||
103 | } else { |
||
104 | throw new ErrorException('4e argument invalide dans getBuildingInfo de OrbitalBaseResource'); |
||
105 | } |
||
106 | } |
||
107 | } else { |
||
108 | throw new ErrorException('2e argument invalide dans getBuildingInfo de OrbitalBaseResource'); |
||
109 | } |
||
110 | } else { |
||
111 | throw new ErrorException('1er argument invalide (entre 0 et 7) dans getBuildingInfo de OrbitalBaseResource'); |
||
112 | } |
||
113 | return FALSE; |
||
114 | } |
||
115 | |||
205 | } |
The break statement is not necessary if it is preceded for example by a return statement:
If you would like to keep this construct to be consistent with other case statements, you can safely mark this issue as a false-positive.