Option::withDisabled() - Code Metrics - royallthefourth/html-document - Measure and Improve Code Quality continuously with Scrutinizer

Option::withDisabled() A
last analyzed 2017-04-08 20:23 UTC

↳ Parent: Option

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace RoyallTheFourth\HtmlDocument\Element;

use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
use RoyallTheFourth\HtmlDocument\Set\ElementSet;
use RoyallTheFourth\HtmlDocument\Tag\Standard;

/**
 * Class Option
 * @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option
 */
final class Option extends AbstractElement implements ParentElementInterface

{
    public function __construct(AttributeSet $attributes = null, ElementSet $children = null)
    {
        $this->attributes = $attributes ?? new AttributeSet();
        $this->children = $children ?? new ElementSet();
        $this->tag = new Standard('option', $attributes, $children);
    }

    public function withAttribute(string $name, string $value = null): Option
    {
        if ($value) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attribute = new StandardAttribute($name, $value);
        } else {
            $attribute = new BooleanAttribute($name);
        }

        return new Option($this->attributes->add($attribute), $this->children);
    }

    public function withChild(ElementInterface $element): Option
    {
        return new Option($this->attributes, $this->children->add($element));
    }

    public function withDisabled(): Option
    {
        return $this->withAttribute('disabled');
    }

    public function withLabel(string $label): Option
    {
        return $this->withAttribute('label', $label);
    }

    public function withSelected(): Option
    {
        return $this->withAttribute('selected');
    }

    public function withLValue(string $value): Option
    {
        return $this->withAttribute('value', $value);
    }
}


1		<?php
2
3		namespace RoyallTheFourth\HtmlDocument\Element;
4
5		use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
6		use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
7		use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
8		use RoyallTheFourth\HtmlDocument\Set\ElementSet;
9		use RoyallTheFourth\HtmlDocument\Tag\Standard;
10
11		/**
12		* Class Option
13		* @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option
14		*/
15	View Code Duplication	final class Option extends AbstractElement implements ParentElementInterface
		0 ignored issues – show Duplication introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		public function __construct(AttributeSet $attributes = null, ElementSet $children = null)
18		{
19		$this->attributes = $attributes ?? new AttributeSet();
20		$this->children = $children ?? new ElementSet();
21		$this->tag = new Standard('option', $attributes, $children);
22		}
23
24		public function withAttribute(string $name, string $value = null): Option
25		{
26		if ($value) {
		0 ignored issues – show Bug Best Practice introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report The expression `$value` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
27		$attribute = new StandardAttribute($name, $value);
28		} else {
29		$attribute = new BooleanAttribute($name);
30		}
31
32		return new Option($this->attributes->add($attribute), $this->children);
33		}
34
35		public function withChild(ElementInterface $element): Option
36		{
37		return new Option($this->attributes, $this->children->add($element));
38		}
39
40		public function withDisabled(): Option
41		{
42		return $this->withAttribute('disabled');
43		}
44
45		public function withLabel(string $label): Option
46		{
47		return $this->withAttribute('label', $label);
48		}
49
50		public function withSelected(): Option
51		{
52		return $this->withAttribute('selected');
53		}
54
55		public function withLValue(string $value): Option
56		{
57		return $this->withAttribute('value', $value);
58		}
59		}
60

royallthefourth / html-document

Option::withDisabled() A last analyzed 2017-04-08 20:23 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Option::withDisabled() A
last analyzed 2017-04-08 20:23 UTC