RoyallTheFourth\HtmlDocument\Element\Option

Complexity

Total Complexity

8

Size/Duplication

Total Lines	45
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1
A	withAttribute()	10	10	2
A	withChild()	4	4	1
A	withDisabled()	4	4	1
A	withLabel()	4	4	1
A	withSelected()	4	4	1
A	withLValue()	4	4	1

<?php

namespace RoyallTheFourth\HtmlDocument\Element;

use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
use RoyallTheFourth\HtmlDocument\Set\ElementSet;
use RoyallTheFourth\HtmlDocument\Tag\Standard;

/**
 * Class Option
 * @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option
 */
final class Option extends AbstractElement implements ParentElementInterface

This class seems to be duplicated in your project.

{
    public function __construct(AttributeSet $attributes = null, ElementSet $children = null)
    {
        $this->attributes = $attributes ?? new AttributeSet();
        $this->children = $children ?? new ElementSet();
        $this->tag = new Standard('option', $attributes, $children);
    }

    public function withAttribute(string $name, string $value = null): Option
    {
        if ($value) {

The expression $value of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $attribute = new StandardAttribute($name, $value);
        } else {
            $attribute = new BooleanAttribute($name);
        }

        return new Option($this->attributes->add($attribute), $this->children);
    }

    public function withChild(ElementInterface $element): Option
    {
        return new Option($this->attributes, $this->children->add($element));
    }

    public function withDisabled(): Option
    {
        return $this->withAttribute('disabled');
    }

    public function withLabel(string $label): Option
    {
        return $this->withAttribute('label', $label);
    }

    public function withSelected(): Option
    {
        return $this->withAttribute('selected');
    }

    public function withLValue(string $value): Option
    {
        return $this->withAttribute('value', $value);
    }
}