CustomerLoader::getCustomerData() - Code Metrics - Inspection of "Finally managed to get a test to run throug, had t..." - rossmitchell/module-twofactor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 21c1bf...8efbb2 )

by Ross

created 2017-04-22 19:12 UTC

CustomerLoader::getCustomerData() A

↳ Parent: CustomerLoader

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	9
loc	9
rs	9.6666
cc	2
eloc	5
nc	2
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: ross
 * Date: 22/04/17
 * Time: 14:03
 */

namespace Rossmitchell\Twofactor\Tests\Integration\FixtureLoader\Traits;


trait CustomerLoader

{
    public static function getCustomerData()
    {
        require __DIR__ . '/../_data/customer.php';

        if(!isset($customerData)) {

            throw new \Exception("No Customer Data has been set");

        }

        return $customerData;
    }

    static function loadCustomer()

    {
        $action = 'load';
        $customerData = self::getCustomerData();
        require __DIR__ . '/../_loaders/customer.php';

    }

    static function loadCustomerRollback()

    {
        $action = 'rollback';
        $customerData = self::getCustomerData();
        require __DIR__ . '/../_loaders/customer.php';

    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: ross
5		* Date: 22/04/17
6		* Time: 14:03
7		*/
8
9		namespace Rossmitchell\Twofactor\Tests\Integration\FixtureLoader\Traits;
10
11
12	View Code Duplication	trait CustomerLoader
		0 ignored issues – show Duplication introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		public static function getCustomerData()
15		{
16		require __DIR__ . '/../_data/customer.php';
		0 ignored issues – show introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report "require" statement detected. File manipulations are discouraged. Concatenating is forbidden. Loading history...
17		if(!isset($customerData)) {
		0 ignored issues – show Coding Style introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history... Coding Style introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report Expected "if (...) {\n"; found "if(...) {\n" Loading history... Bug introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report The variable `$customerData` seems to never exist, and therefore `isset` should always return `false`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
18		throw new \Exception("No Customer Data has been set");
		0 ignored issues – show introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report Direct throw of Exception is discouraged. Use \Magento\Framework\Exception\LocalizedException instead. Loading history...
19		}
20
21		return $customerData;
22		}
23
24		static function loadCustomer()
		0 ignored issues – show Best Practice introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
25		{
26		$action = 'load';
27		$customerData = self::getCustomerData();
28		require __DIR__ . '/../_loaders/customer.php';
		0 ignored issues – show introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report "require" statement detected. File manipulations are discouraged. Concatenating is forbidden. Loading history...
29		}
30
31		static function loadCustomerRollback()
		0 ignored issues – show Best Practice introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
32		{
33		$action = 'rollback';
34		$customerData = self::getCustomerData();
35		require __DIR__ . '/../_loaders/customer.php';
		0 ignored issues – show introduced 2017-04-22 19:19 UTC by Report Bug Copy Issue Report "require" statement detected. File manipulations are discouraged. Concatenating is forbidden. Loading history...
36		}
37		}
38

rossmitchell / module-twofactor

Push — master ( 21c1bf...8efbb2 )

CustomerLoader::getCustomerData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like