Rossmitchell\Twofactor\Tests\Integration\FixtureLoader\Traits\CustomerLoader

Complexity

Total Complexity

4

Size/Duplication

Total Lines	26
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getCustomerData()	9	9	2
A	loadCustomer()	6	6	1
A	loadCustomerRollback()	6	6	1

<?php
/**
 * Created by PhpStorm.
 * User: ross
 * Date: 22/04/17
 * Time: 14:03
 */

namespace Rossmitchell\Twofactor\Tests\Integration\FixtureLoader\Traits;


trait CustomerLoader

This class seems to be duplicated in your project.

{
    public static function getCustomerData()
    {
        require __DIR__ . '/../_data/customer.php';

"require" statement detected. File manipulations are discouraged. Concatenating is forbidden.

        if(!isset($customerData)) {

Expected 1 space after IF keyword; 0 found

Expected "if (...) {\n"; found "if(...) {\n"

The variable $customerData seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

            throw new \Exception("No Customer Data has been set");

Direct throw of Exception is discouraged. Use \Magento\Framework\Exception\LocalizedException instead.

        }

        return $customerData;
    }

    static function loadCustomer()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $action = 'load';
        $customerData = self::getCustomerData();
        require __DIR__ . '/../_loaders/customer.php';

"require" statement detected. File manipulations are discouraged. Concatenating is forbidden.

    }

    static function loadCustomerRollback()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $action = 'rollback';
        $customerData = self::getCustomerData();
        require __DIR__ . '/../_loaders/customer.php';

"require" statement detected. File manipulations are discouraged. Concatenating is forbidden.

    }
}