Code Quality Summary - rossmitchell/module-twofactor - Measure and Improve Code Quality continuously with Scrutinizer

2017-07-11 21:37 UTC

Inspected Actual going to send the right...

Test Coverage has increased to 98% (+41%).

2017-07-11 20:28 UTC

Inspected Adding a check and some docume...

2 issues (1 informational, 1 unknown) were introduced.
3 issues were fixed.

2017-05-22 00:43 UTC

Inspected Removing dead, debugging code

	Good job, 1 issue was fixed.
	Test Coverage has increased to 85% (+1%).
B	↗	A	GetQrCodeManagement::getQrCode() improved

2017-05-21 23:49 UTC

Inspected Added a basic, untested API en...

	6 issues (1 major, 3 informational, 2 unknown) were introduced.
	Test Coverage has decreased to 84% (-10%).
	17 added classes/operations
		B	GetQrCodeManagement::getQrCode() added
		A	GetQrCode::__construct() added
		A	GetQrCode::getQrCode() added
		A	GetQrCode::setQrCode() added
		A	GetQrCode::buildResponseForCustomer() added
		A	GetQrCode::getQrCode() added
		A	GetQrCode::__construct() added
		A	GetQrCode::isUsingTwoFactor() added
		A	GetQrCode::setIsUsingTwoFactor() added
		A	GetQrCode::getIsUsingTwoFactor() added
view all

2017-05-21 23:16 UTC

Inspected This looks to be down to the i...

Test Coverage has decreased to 94% (-2%).

2017-05-21 18:41 UTC

Inspected Added a UI component to the mo...

2 added classes/operations
	A	IsTwoFactorEnabled::toOptionArray() added
	A	IsTwoFactorEnabled added

2017-05-20 17:04 UTC

Inspected Cleaning up some coding issues

5 issues (2 minor, 3 informational) were introduced.
8 issues were fixed.

2017-05-15 21:31 UTC

Inspected starting to remove dead and du...

6 issues (2 minor, 4 informational) were introduced. 13 issues were fixed.
1 added class/operation
	A	QRCode::shouldQrCodeBeDisplayed() added

2017-05-15 00:27 UTC

Inspected Refactorer how the setter was...

2 issues (2 informational) were introduced.
Test Coverage has increased to 95% (+2%).
4 added classes/operations
	A	ShouldCreateSecretTest::setPostParams() added
	A	ShouldCreateSecretTest::testCustomerOptsInTwoFactorEnabled() added
	A	ShouldCreateSecretTest::getConfigurationDataPath() added
	A	ShouldCreateSecretTest added

2017-05-14 23:17 UTC

Inspected added some tests to handle the...

	3 issues (3 informational) were introduced. 5 issues were fixed.
	Test Coverage has increased to 93% (+7%).
	20 added classes/operations
		A	QRCodeShouldNotBeGeneratedWhenTwoFactorDisabledTest::testQrCodeOnSave(... added
		A	QRCodeShouldNotBeGeneratedWhenTwoFactorDisabledTest::getConfigurationD... added
		A	QRCodeShouldNotBeGeneratedWhenTwoFactorDisabledTest::getAdminUserDataP... added
		A	QRCodeShouldNotBeGeneratedWhenDisabledTest::setPostParams() added
		A	QRCodeShouldNotBeGeneratedWhenTwoFactorDisabledTest::setPostParams() added
		A	QRCodeShouldNotChangeIfAlreadyExistsTest::getAdminUserDataPath() added
		A	QRCodeShouldNotChangeIfAlreadyExistsTest::setPostParams() added
		A	QRCodeShouldNotChangeIfAlreadyExistsTest::testQrCodeOnSave() added
		A	QRCodeShouldNotChangeIfAlreadyExistsTest::getConfigurationDataPath() added
		A	QRCodeShouldNotBeGeneratedWhenDisabledTest::testQrCodeOnSave() added
view all

2017-05-14 22:03 UTC

Inspected Added tests for the customer a...

	2 issues (2 informational) were introduced.
	Test Coverage has increased to 74% (+9%).
	22 added classes/operations
		A	OptionShouldShowWhenEnabledTest::testUseTwoFactorIsDisplayed() added
		A	OptionShouldShowWhenEnabledTest::getConfigurationDataPath() added
		A	OptionShouldShowWhenEnabledTest::getCustomerDataPath() added
		A	NothingShouldBeDisplayedWhenDisabledTest::testUseTwoFactorIsDisplayed(... added
		A	QRCodeShouldBeDisplayedIfSecretExistsTest::getCustomerDataPath() added
		A	QRCodeShouldBeDisplayedIfSecretExistsTest::getConfigurationDataPath() added
		A	QRCodeShouldBeDisplayedTest::testUseTwoFactorIsDisplayed() added
		A	QRCodeShouldBeDisplayedTest::getConfigurationDataPath() added
		A	QRCodeShouldBeDisplayedTest::getCustomerDataPath() added
		A	QRCodeShouldBeDisplayedIfSecretExistsTest::testUseTwoFactorIsDisplayed... added
view all

2017-05-14 20:24 UTC

Inspected Added tests for the adnin acco...

	8 issues (3 minor, 3 informational, 2 unknown) were introduced. 2 issues were fixed.
	Test Coverage has increased to 66% (+8%).
	13 added classes/operations
		A	CheckQRCodeIsNotDisplayedTest::testQrCodeIsNotDisplayed() added
		A	CheckQRCodeIsNotDisplayedTest::getConfigurationDataPath() added
		A	CheckQRCodeIsNotDisplayedWhenDisabledTest::getAdminUserDataPath() added
		A	CheckQRCodeIsNotDisplayedWhenDisabledTest::getConfigurationDataPath() added
		A	CheckQRCodeIsNotDisplayedWhenDisabledTest::testQrCodeIsNotDisplayed() added
		A	CheckQRCodeIsNotDisplayedTest::getAdminUserDataPath() added
		A	CheckQRCodeIsDisplayedTest::testQrCodeIsVisible() added
		A	CheckQRCodeIsNotDisplayedWhenDisabledTest added
		A	CheckQRCodeIsNotDisplayedTest added
		A	AbstractTestClass::disableSecretKeys() added
view all

2017-05-14 17:32 UTC

Inspected Added some tests for the admin...

	39 issues (1 major, 3 minor, 24 informational, 11 unknown) were introduced. 9 issues were fixed.
	Test Coverage has increased to 57% (+22%).
	1 new patch (Unused Use Statements) is available.
	64 added classes/operations
		A	EnabledForSystemDisabledForUserTest::getConfigurationDataPath() added
		A	EnabledForSystemDisabledForUserTest::getAdminUserDataPath() added
		A	DisabledForSystemEnabledForUserTest::testNoRedirectionToVerification() added
		A	EnabledForSystemDisabledForUserTest::testNoRedirectionToVerification() added
		A	EnabledForSystemEnabledForUserTest::getAdminUserDataPath() added
		A	EnabledForSystemEnabledForUserTest::testRedirectionToVerification() added
		A	EnabledForSystemEnabledForUserTest::getConfigurationDataPath() added
		A	DisabledForSystemEnabledForUserTest::getConfigurationDataPath() added
		A	DisabledForSystemEnabledForUserTest::getAdminUserDataPath() added
		A	RedirectWhenNotLoggedInTest::getConfigurationDataPath() added
view all

2017-05-04 01:29 UTC

Inspected Fixed a misnamed call

Good job, 3 issues were fixed.

2017-05-04 00:05 UTC

Inspected Added a bit of documentation a...

	12 issues (1 major, 4 minor, 7 informational) were introduced. 6 issues were fixed.
	2 new patches (Unused Use Statements) are available.
	15 added classes/operations
		A	Fetcher::getVerificationUrl() added
		A	Fetcher::getAuthenticationUrl() added
		A	Fetcher::getCustomerAccountUrl() added
		A	Fetcher::getAdminDashboardUrl() added
		A	Fetcher::getUrl() added
		A	Fetcher::getCustomerLogInUrl() added
		A	Fetcher::__construct() added
		A	Checker::cleanUrl() added
		A	Checker::__construct() added
		A	Fetcher added
view all

Image URL
Markdown
Textile
RDOC
AsciiDoc

Badges

Latest Alerts

rossmitchell / module-twofactor

Badges

Latest Alerts