rosasurfer / bfx-core-volume

bin/cron/logwatch.php

Spacing +13 added lines, -13 removed lines

@@ -21,14 +21,14 @@ 
 use const rosasurfer\WINDOWS;
 
 require(dirname(realpath(__FILE__)).'/../../app/init.php');
-!CLI && exit(1|stderr('error: This script must be executed in CLI mode.'));
+!CLI && exit(1 | stderr('error: This script must be executed in CLI mode.'));
 
 
 // --- Configuration --------------------------------------------------------------------------------------------------------
 
 
-set_time_limit(0);                                          // no time limit for CLI
-$quiet = false;                                             // whether or not "quiet" mode is enabled (e.g. for CRON)
+set_time_limit(0); // no time limit for CLI
+$quiet = false; // whether or not "quiet" mode is enabled (e.g. for CRON)
 
 
 // --- Parse and validate command line arguments ----------------------------------------------------------------------------
@@ -37,7 +37,7 @@ 
 $args = array_slice($_SERVER['argv'], 1);
 
 foreach ($args as $i => $arg) {
-    if ($arg == '-h') { help(); exit(0);                           }    // help
+    if ($arg == '-h') { help(); exit(0); }    // help
     if ($arg == '-q') { $quiet = true; unset($args[$i]); continue; }    // quiet mode
 
     stderr('invalid argument: '.$arg);
@@ -51,22 +51,22 @@ 
 
 // (1) define the location of the error log
 $errorLog = ini_get('error_log');
-if (empty($errorLog) || $errorLog=='syslog') {              // errors are logged elsewhere
-    if (empty($errorLog)) $quiet || echoPre('errors are logged elsewhere ('.(CLI     ?    'stderr':'sapi'  ).')');
-    else                  $quiet || echoPre('errors are logged elsewhere ('.(WINDOWS ? 'event log':'syslog').')');
+if (empty($errorLog) || $errorLog == 'syslog') {              // errors are logged elsewhere
+    if (empty($errorLog)) $quiet || echoPre('errors are logged elsewhere ('.(CLI ? 'stderr' : 'sapi').')');
+    else                  $quiet || echoPre('errors are logged elsewhere ('.(WINDOWS ? 'event log' : 'syslog').')');
     exit(0);
 }
 
 
 // (2) check log file for existence and process it
-if (!is_file    ($errorLog)) { $quiet || echoPre('error log empty: '       .$errorLog); exit(0); }
+if (!is_file($errorLog)) { $quiet || echoPre('error log empty: '.$errorLog); exit(0); }
 if (!is_writable($errorLog)) {            stderr('cannot access log file: '.$errorLog); exit(1); }
 $errorLog = realpath($errorLog);
 
 // rename the file; we don't want to lock it as doing so could block the main app
 $tempName = tempnam(dirname($errorLog), basename($errorLog).'.');
 if (!rename($errorLog, $tempName)) {
-    stderr('cannot rename log file: '  .$errorLog);
+    stderr('cannot rename log file: '.$errorLog);
     exit(1);
 }
 
@@ -75,16 +75,16 @@ 
 $hFile = fopen($tempName, 'rb');
 $line  = $entry = '';
 $i = 0;
-while (($line=fgets($hFile)) !== false) {
+while (($line = fgets($hFile)) !== false) {
     $i++;
-    $line = trim($line, "\r\n");                // PHP doesn't correctly handle EOL_NETSCAPE which is error_log() standard on Windows
+    $line = trim($line, "\r\n"); // PHP doesn't correctly handle EOL_NETSCAPE which is error_log() standard on Windows
     if (strStartsWith($line, '[')) {            // lines starting with a bracket "[" are considered the start of an entry
         processEntry($entry);
         $entry = '';
     }
     $entry .= $line.NL;
 }
-processEntry($entry);                           // process the last entry (if any)
+processEntry($entry); // process the last entry (if any)
 
 // delete the processed file
 fclose($hFile);
@@ -121,7 +121,7 @@ 
     }                                                               // without receivers mail is sent to the system user
     !$receivers && $receivers[] = strtolower(get_current_user().'@localhost');
 
-    $subject = strtok($entry, "\r\n");                              // that's CR or LF, not CRLF
+    $subject = strtok($entry, "\r\n"); // that's CR or LF, not CRLF
     $message = $entry;
     $sender  = null;
     $headers = [];

Braces +14 added lines, -6 removed lines

@@ -52,8 +52,11 @@ 
 // (1) define the location of the error log
 $errorLog = ini_get('error_log');
 if (empty($errorLog) || $errorLog=='syslog') {              // errors are logged elsewhere
-    if (empty($errorLog)) $quiet || echoPre('errors are logged elsewhere ('.(CLI     ?    'stderr':'sapi'  ).')');
-    else                  $quiet || echoPre('errors are logged elsewhere ('.(WINDOWS ? 'event log':'syslog').')');
+    if (empty($errorLog)) {
+        $quiet || echoPre('errors are logged elsewhere ('.(CLI     ?    'stderr':'sapi'  ).')');
+    } else {
+        $quiet || echoPre('errors are logged elsewhere ('.(WINDOWS ? 'event log':'syslog').')');
+    }
     exit(0);
 }
 
@@ -105,9 +108,13 @@ 
  * @param  string $entry - a single log entry
  */
 function processEntry($entry) {
-    if (!is_string($entry)) throw new IllegalTypeException('Illegal type of parameter $entry: '.gettype($entry));
+    if (!is_string($entry)) {
+        throw new IllegalTypeException('Illegal type of parameter $entry: '.gettype($entry));
+    }
     $entry = trim($entry);
-    if (!strlen($entry)) return;
+    if (!strlen($entry)) {
+        return;
+    }
 
     $config = Application::getConfig();
 
@@ -151,8 +158,9 @@ 
  * @param  string $message [optional] - additional message to display (default: none)
  */
 function help($message = null) {
-    if (isset($message))
-        echo $message.NL;
+    if (isset($message)) {
+            echo $message.NL;
+    }
 
     $self = basename($_SERVER['PHP_SELF']);
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -164,5 +164,5 @@
            -h   This help screen.
 
 
-HELP;
+help;
 }

app/init.php

Spacing +6 added lines, -6 removed lines

@@ -3,16 +3,16 @@
 use rosasurfer\util\PHP;
 
 // class loader
-require(($appRoot=dirname(__DIR__)).'/vendor/autoload.php');
+require(($appRoot = dirname(__DIR__)).'/vendor/autoload.php');
 
 
 // php.ini settings
 error_reporting(E_ALL & ~E_DEPRECATED);
-PHP::ini_set('log_errors',        1                                );
-PHP::ini_set('error_log',         $appRoot.'/etc/log/php-error.log');
-PHP::ini_set('session.save_path', $appRoot.'/etc/tmp'              );
-PHP::ini_set('default_charset',  'UTF-8'                           );
-PHP::ini_set('memory_limit',     '128M'                            );
+PHP::ini_set('log_errors', 1);
+PHP::ini_set('error_log', $appRoot.'/etc/log/php-error.log');
+PHP::ini_set('session.save_path', $appRoot.'/etc/tmp');
+PHP::ini_set('default_charset', 'UTF-8');
+PHP::ini_set('memory_limit', '128M');
 
 
 // create a new application

app/controller/actions/DownloadAction.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
 
         $files = [
             0 => ['BankersFX Core Volume.ex4', $config['app.dir.root'].'/etc/mql/indicators/BankersFX CVI v1.20.0.ex4'],
-            1 => ['BankersFX Lib.ex4',         $config['app.dir.root'].'/etc/mql/libraries/BankersFX Lib.ex4'         ],
+            1 => ['BankersFX Lib.ex4', $config['app.dir.root'].'/etc/mql/libraries/BankersFX Lib.ex4'],
         ];
         if (!isset($files[$file])) {
             $request->setActionError('file', 'error: Unknown file identifier');
@@ -40,14 +40,14 @@ 
             // make the download non-cacheable
             header('Pragma: private');
             header('Cache-control: private');
-            header('Expires: '.gmdate(DATE_RFC2822, time() - 1*YEAR));
+            header('Expires: '.gmdate(DATE_RFC2822, time() - 1 * YEAR));
 
             // erase an existing output buffer and work around an IE bug (Content-Disposition is ignored)
             ob_get_level() && ob_end_clean();
             ini_get_bool('zlib.output_compression') && PHP::ini_set('zlib.output_compression', false);
 
             // close the session to not block following requests
-            (session_status()==PHP_SESSION_ACTIVE) && session_write_close();
+            (session_status() == PHP_SESSION_ACTIVE) && session_write_close();
 
             // serve the file
             $hFile = fopen($fullFilename, 'rb');

app/controller/actions/CheckLicenseAction.php

Spacing +3 added lines, -3 removed lines

@@ -22,7 +22,7 @@ 
         if (false && !$request->isSecure()) {
             $url = $request->getUrl();
             $url = 'https'.strRight($url, -4);
-            return new ActionForward('generic', $url, $redirect=true);
+            return new ActionForward('generic', $url, $redirect = true);
         }
         $config = $this->di()['config'];
 
@@ -37,13 +37,13 @@ 
             $knownAccount = (bool) ($license = $config->get('bfx.accounts.'.$account, null));
             !$license && $license = $config->get('bfx.accounts.default');
 
-            $expires = date('Ymd', time() + 1*MONTH);                       // extend license for 30 days
+            $expires = date('Ymd', time() + 1 * MONTH); // extend license for 30 days
             $reply = $account.'|'.$license.'|A|'.$expires.'|mt4tfv|ok';
         }
         else {
             $reply = 'ERROR: Unknown or missing account number.|no';
         }
-        $knownAccount || Logger::log('reply: '.$reply, L_INFO);             // log requests for unknown accounts
+        $knownAccount || Logger::log('reply: '.$reply, L_INFO); // log requests for unknown accounts
 
         echo $reply;
         return null;

Braces +1 added lines, -2 removed lines

@@ -39,8 +39,7 @@
 
             $expires = date('Ymd', time() + 1*MONTH);                       // extend license for 30 days
             $reply = $account.'|'.$license.'|A|'.$expires.'|mt4tfv|ok';
-        }
-        else {
+        } else {
             $reply = 'ERROR: Unknown or missing account number.|no';
         }
         $knownAccount || Logger::log('reply: '.$reply, L_INFO);             // log requests for unknown accounts