StateMiddlewareDependencyTrait::dispatchBeforeSignal() - Code Metrics - Inspection of "[CLEANUP] Cleanup" - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — middleware-wip ( 106169...2ebda9 )

by Romain

created 2017-03-13 13:04 UTC

dispatchBeforeSignal() A

↳ Parent: StateMiddlewareDependencyTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	3
nc	2
nop	0

<?php
/*
 * 2017 Romain CANON <[email protected]>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Middleware\State;

use Romm\Formz\Middleware\Signal\SendsMiddlewareSignal;

trait StateMiddlewareDependencyTrait
{
    /**
     * @var MiddlewareState
     */
    private $state;

    /**
     * @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::dispatchBeforeSignal()
     */
    final public function dispatchBeforeSignal()
    {
        if (false === $this instanceof SendsMiddlewareSignal) {
            // @todo exception
        }

        /** @var SendsMiddlewareSignal $this */
        $this->state->dispatchBeforeSignal($this);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::dispatchAfterSignal()
     */
    final public function dispatchAfterSignal()
    {
        if (false === $this instanceof SendsMiddlewareSignal) {
            // @todo exception
        }

        /** @var SendsMiddlewareSignal $this */
        $this->state->dispatchAfterSignal($this);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * @param MiddlewareState $middlewareState
     */
    final public function attachMiddlewareState(MiddlewareState $middlewareState)
    {
        $this->state = $middlewareState;
    }
}




1			<?php
2			/*
3			* 2017 Romain CANON <[email protected]>
4			*
5			* This file is part of the TYPO3 FormZ project.
6			* It is free software; you can redistribute it and/or modify it
7			* under the terms of the GNU General Public License, either
8			* version 3 of the License, or any later version.
9			*
10			* For the full copyright and license information, see:
11			* http://www.gnu.org/licenses/gpl-3.0.html
12			*/
13
14			namespace Romm\Formz\Middleware\State;
15
16			use Romm\Formz\Middleware\Signal\SendsMiddlewareSignal;
17
18			trait StateMiddlewareDependencyTrait
19			{
20			/**
21			* @var MiddlewareState
22			*/
23			private $state;
24
25			/**
26			* @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::dispatchBeforeSignal()
27			*/
28			final public function dispatchBeforeSignal()
29			{
30			if (false === $this instanceof SendsMiddlewareSignal) {
31			// @todo exception
32			}
33
34			/** @var SendsMiddlewareSignal $this */
35			$this->state->dispatchBeforeSignal($this);
			0 ignored issues – show Bug introduced 2017-03-09 17:30 UTC by Report Bug Copy Issue Report Accessing `state` on the interface `Romm\Formz\Middleware\Signal\SendsMiddlewareSignal` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
36			}
37
38			/**
39			* @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::dispatchAfterSignal()
40			*/
41			final public function dispatchAfterSignal()
42			{
43			if (false === $this instanceof SendsMiddlewareSignal) {
44			// @todo exception
45			}
46
47			/** @var SendsMiddlewareSignal $this */
48			$this->state->dispatchAfterSignal($this);
			0 ignored issues – show Bug introduced 2017-03-09 17:30 UTC by Report Bug Copy Issue Report Accessing `state` on the interface `Romm\Formz\Middleware\Signal\SendsMiddlewareSignal` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49			}
50
51			/**
52			* @param MiddlewareState $middlewareState
53			*/
54			final public function attachMiddlewareState(MiddlewareState $middlewareState)
55			{
56			$this->state = $middlewareState;
57			}
58			}
59
60
61

romm / formz

Push — middleware-wip ( 106169...2ebda9 )

dispatchBeforeSignal() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like