Romm\Formz\Middleware\State\StateMiddlewareDependencyTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	attachMiddlewareState()	0	4	1
A	dispatchBeforeSignal()	0	9	2
A	dispatchAfterSignal()	0	9	2

<?php
/*
 * 2017 Romain CANON <romain.hydrocanon@gmail.com>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Middleware\State;

use Romm\Formz\Middleware\Signal\SendsMiddlewareSignal;

trait StateMiddlewareDependencyTrait
{
    /**
     * @var MiddlewareState
     */
    private $state;

    /**
     * @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::dispatchBeforeSignal()
     */
    final public function dispatchBeforeSignal()
    {
        if (false === $this instanceof SendsMiddlewareSignal) {
            // @todo exception
        }

        /** @var SendsMiddlewareSignal $this */
        $this->state->dispatchBeforeSignal($this);

Accessing state on the interface Romm\Formz\Middleware\Signal\SendsMiddlewareSignal suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::dispatchAfterSignal()
     */
    final public function dispatchAfterSignal()
    {
        if (false === $this instanceof SendsMiddlewareSignal) {
            // @todo exception
        }

        /** @var SendsMiddlewareSignal $this */
        $this->state->dispatchAfterSignal($this);

Accessing state on the interface Romm\Formz\Middleware\Signal\SendsMiddlewareSignal suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * @param MiddlewareState $middlewareState
     */
    final public function attachMiddlewareState(MiddlewareState $middlewareState)
    {
        $this->state = $middlewareState;
    }
}