Example\Models\User::socials()

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function socials(bool $obj = false): User
    {
        $this->relational_fields[] = 'socials';
        $socials = (new Socials())->getUserSocials($this->id);

The property id does not exist on Example\Models\User. Since you implemented __get, consider adding a @property annotation.

$this->id of type null|string is incompatible with the type integer expected by parameter $user_id of Example\Models\Socials::getUserSocials().

        if ($obj) {
            $this->socials = $socials;

The property socials does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $this;
        }

        if (empty($socials)) {
            $this->socials = null;
            return $this;
        }

        foreach ($socials as $key => $value) {
            $user_socials[] = $value->data();
        }
        $this->socials = $user_socials;

The variable $user_socials seems to be defined by a foreach iteration on line 62. Are you sure the iterator is never empty, otherwise this variable is not defined?

        return $this;
    }
}