Example\Models\User

Complexity

Total Complexity

8

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	socials()	0	20	4
A	address()	0	16	3

<?php

namespace Example\Models;

use CoffeeCode\DataLayer\DataLayer;

/**
 * Class User
 * @package Example\Models
 */
class User extends DataLayer
{
    /**
     * User constructor.
     */
    public function __construct()
    {
        parent::__construct("users", ["first_name", "last_name"]);
    }

    /**
     * @param bool $obj
     * @return User
     */
    public function address(bool $obj = false): User
    {
        $this->relational_fields[] = 'address';

        if ($obj) {
            $this->address = (new Address())->findByUser($this->id);

$this->id of type null|string is incompatible with the type integer expected by parameter $user_id of Example\Models\Address::findByUser().

The property id does not exist on Example\Models\User. Since you implemented __get, consider adding a @property annotation.

The property address does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $this;
        }

        $address = (new Address())->findByUser($this->id);
        if (empty($address)) {
            $this->address = null;
        } else {
            $this->address = (new Address())->findByUser($this->id)->data();
        }
        return $this;
    }

    /**
     * @param bool $obj
     * @return User
     */
    public function socials(bool $obj = false): User
    {
        $this->relational_fields[] = 'socials';
        $socials = (new Socials())->getUserSocials($this->id);

The property id does not exist on Example\Models\User. Since you implemented __get, consider adding a @property annotation.

$this->id of type null|string is incompatible with the type integer expected by parameter $user_id of Example\Models\Socials::getUserSocials().

        if ($obj) {
            $this->socials = $socials;

The property socials does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $this;
        }

        if (empty($socials)) {
            $this->socials = null;
            return $this;
        }

        foreach ($socials as $key => $value) {
            $user_socials[] = $value->data();
        }
        $this->socials = $user_socials;

The variable $user_socials seems to be defined by a foreach iteration on line 62. Are you sure the iterator is never empty, otherwise this variable is not defined?

        return $this;
    }
}