Inspection of "Update FakePDOStatement.php" - rkrx/php-fakepdo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d9f92...387426 )

by Ron

created 2020-10-18 15:10 UTC

Status

Doc Comments -3 removed lines patch added patch discarded remove patch

@@ -112,9 +112,6 @@
 block discarded – undo
 	}
 
 	/**
-	 * @param mixed|null $how
-	 * @param mixed|null $class_name
-	 * @param array|null $ctor_args
 	 * @return array
 	 */
 	public function fetchAll(int $mode = PDO::FETCH_BOTH, mixed ...$args) {

Please login to merge, or discard this patch.

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
 	 */
 	public function execute($bound_input_params = NULL) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($bound_input_params), function () {
+		return $this->invokeEventHandler($methodName, array($bound_input_params), function() {
 			return true;
 		});
 	}
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
 	 */
 	public function fetch($fetch_style = null, $cursor_orientation = PDO::FETCH_ORI_NEXT, $cursor_offset = 0) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($fetch_style, $cursor_orientation, $cursor_offset), function () {
+		return $this->invokeEventHandler($methodName, array($fetch_style, $cursor_orientation, $cursor_offset), function() {
 			return [];
 		});
 	}
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
 	 */
 	public function bindParam($parameter, &$variable, $data_type = PDO::PARAM_STR, $length = null, $driver_options = null) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($parameter, $variable, $data_type, $driver_options), function () {
+		return $this->invokeEventHandler($methodName, array($parameter, $variable, $data_type, $driver_options), function() {
 			return true;
 		});
 	}
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 	 */
 	public function bindColumn($column, &$param, $type = null, $maxlen = null, $driverdata = null) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($column, $param, $type, $maxlen, $driverdata), function () {
+		return $this->invokeEventHandler($methodName, array($column, $param, $type, $maxlen, $driverdata), function() {
 			return true;
 		});
 	}
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
 	 */
 	public function bindValue($parameter, $value, $data_type = PDO::PARAM_STR) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($parameter, $value, $data_type), function () {
+		return $this->invokeEventHandler($methodName, array($parameter, $value, $data_type), function() {
 			return true;
 		});
 	}
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
 	 */
 	public function rowCount() {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return 0;
 		});
 	}
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
 	 */
 	public function fetchColumn($column_number = 0) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return '';
 		});
 	}
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
 	 */
 	public function fetchAll(int $mode = PDO::FETCH_BOTH, mixed ...$args) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return [];
 		});
 	}
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 	 */
 	public function fetchObject($class_name = NULL, $ctor_args = NULL) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return new \stdClass();
 		});
 	}
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
 	 */
 	public function errorCode() {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return '';
 		});
 	}
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
 	 */
 	public function errorInfo() {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return [0, 0, 0];
 		});
 	}
@@ -162,9 +162,9 @@  discard block
 block discarded – undo
 	 */
 	public function getAttribute($attribute) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($attribute), function ($attribute) {
+		return $this->invokeEventHandler($methodName, array($attribute), function($attribute) {
 			$attribute = json_encode($attribute);
-			if(array_key_exists($attribute, $this->attributes)) {
+			if (array_key_exists($attribute, $this->attributes)) {
 				return $this->attributes[$attribute];
 			}
 			return null;
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
 	 */
 	public function setAttribute($attribute, $value) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($attribute, $value), function ($attribute, $value) {
+		return $this->invokeEventHandler($methodName, array($attribute, $value), function($attribute, $value) {
 			$attribute = json_encode($attribute);
 			$this->attributes[$attribute] = $value;
 			return true;
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
 	 */
 	public function columnCount() {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return 0;
 		});
 	}
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
 	 */
 	public function getColumnMeta($column) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($column), function () {
+		return $this->invokeEventHandler($methodName, array($column), function() {
 			return [];
 		});
 	}
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
 	 */
 	public function setFetchMode($mode, $params = NULL) {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array($mode), function () {
+		return $this->invokeEventHandler($methodName, array($mode), function() {
 			return true;
 		});
 	}
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
 	 */
 	public function nextRowset() {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return true;
 		});
 	}
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
 	 */
 	public function closeCursor() {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return true;
 		});
 	}
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
 	 */
 	public function debugDumpParams() {
 		$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
-		return $this->invokeEventHandler($methodName, array(), function () {
+		return $this->invokeEventHandler($methodName, array(), function() {
 			return true;
 		});
 	}

Please login to merge, or discard this patch.

		@@ -112,9 +112,6 @@
		block discarded – undo
112	112	}
113	113
114	114	/**
115		- * @param mixed\|null $how
116		- * @param mixed\|null $class_name
117		- * @param array\|null $ctor_args
118	115	* @return array
119	116	*/
120	117	public function fetchAll(int $mode = PDO::FETCH_BOTH, mixed ...$args) {

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	*/
30	30	public function execute($bound_input_params = NULL) {
31	31	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
32		- return $this->invokeEventHandler($methodName, array($bound_input_params), function () {
	32	+ return $this->invokeEventHandler($methodName, array($bound_input_params), function() {
33	33	return true;
34	34	});
35	35	}
		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42	*/
43	43	public function fetch($fetch_style = null, $cursor_orientation = PDO::FETCH_ORI_NEXT, $cursor_offset = 0) {
44	44	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
45		- return $this->invokeEventHandler($methodName, array($fetch_style, $cursor_orientation, $cursor_offset), function () {
	45	+ return $this->invokeEventHandler($methodName, array($fetch_style, $cursor_orientation, $cursor_offset), function() {
46	46	return [];
47	47	});
48	48	}
		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	*/
58	58	public function bindParam($parameter, &$variable, $data_type = PDO::PARAM_STR, $length = null, $driver_options = null) {
59	59	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
60		- return $this->invokeEventHandler($methodName, array($parameter, $variable, $data_type, $driver_options), function () {
	60	+ return $this->invokeEventHandler($methodName, array($parameter, $variable, $data_type, $driver_options), function() {
61	61	return true;
62	62	});
63	63	}
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	*/
73	73	public function bindColumn($column, &$param, $type = null, $maxlen = null, $driverdata = null) {
74	74	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
75		- return $this->invokeEventHandler($methodName, array($column, $param, $type, $maxlen, $driverdata), function () {
	75	+ return $this->invokeEventHandler($methodName, array($column, $param, $type, $maxlen, $driverdata), function() {
76	76	return true;
77	77	});
78	78	}
		@@ -85,7 +85,7 @@ discard block
		block discarded – undo
85	85	*/
86	86	public function bindValue($parameter, $value, $data_type = PDO::PARAM_STR) {
87	87	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
88		- return $this->invokeEventHandler($methodName, array($parameter, $value, $data_type), function () {
	88	+ return $this->invokeEventHandler($methodName, array($parameter, $value, $data_type), function() {
89	89	return true;
90	90	});
91	91	}
		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	*/
96	96	public function rowCount() {
97	97	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
98		- return $this->invokeEventHandler($methodName, array(), function () {
	98	+ return $this->invokeEventHandler($methodName, array(), function() {
99	99	return 0;
100	100	});
101	101	}
		@@ -106,7 +106,7 @@ discard block
		block discarded – undo
106	106	*/
107	107	public function fetchColumn($column_number = 0) {
108	108	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
109		- return $this->invokeEventHandler($methodName, array(), function () {
	109	+ return $this->invokeEventHandler($methodName, array(), function() {
110	110	return '';
111	111	});
112	112	}
		@@ -119,7 +119,7 @@ discard block
		block discarded – undo
119	119	*/
120	120	public function fetchAll(int $mode = PDO::FETCH_BOTH, mixed ...$args) {
121	121	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
122		- return $this->invokeEventHandler($methodName, array(), function () {
	122	+ return $this->invokeEventHandler($methodName, array(), function() {
123	123	return [];
124	124	});
125	125	}
		@@ -131,7 +131,7 @@ discard block
		block discarded – undo
131	131	*/
132	132	public function fetchObject($class_name = NULL, $ctor_args = NULL) {
133	133	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
134		- return $this->invokeEventHandler($methodName, array(), function () {
	134	+ return $this->invokeEventHandler($methodName, array(), function() {
135	135	return new \stdClass();
136	136	});
137	137	}
		@@ -141,7 +141,7 @@ discard block
		block discarded – undo
141	141	*/
142	142	public function errorCode() {
143	143	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
144		- return $this->invokeEventHandler($methodName, array(), function () {
	144	+ return $this->invokeEventHandler($methodName, array(), function() {
145	145	return '';
146	146	});
147	147	}
		@@ -151,7 +151,7 @@ discard block
		block discarded – undo
151	151	*/
152	152	public function errorInfo() {
153	153	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
154		- return $this->invokeEventHandler($methodName, array(), function () {
	154	+ return $this->invokeEventHandler($methodName, array(), function() {
155	155	return [0, 0, 0];
156	156	});
157	157	}
		@@ -162,9 +162,9 @@ discard block
		block discarded – undo
162	162	*/
163	163	public function getAttribute($attribute) {
164	164	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
165		- return $this->invokeEventHandler($methodName, array($attribute), function ($attribute) {
	165	+ return $this->invokeEventHandler($methodName, array($attribute), function($attribute) {
166	166	$attribute = json_encode($attribute);
167		- if(array_key_exists($attribute, $this->attributes)) {
	167	+ if (array_key_exists($attribute, $this->attributes)) {
168	168	return $this->attributes[$attribute];
169	169	}
170	170	return null;
		@@ -178,7 +178,7 @@ discard block
		block discarded – undo
178	178	*/
179	179	public function setAttribute($attribute, $value) {
180	180	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
181		- return $this->invokeEventHandler($methodName, array($attribute, $value), function ($attribute, $value) {
	181	+ return $this->invokeEventHandler($methodName, array($attribute, $value), function($attribute, $value) {
182	182	$attribute = json_encode($attribute);
183	183	$this->attributes[$attribute] = $value;
184	184	return true;
		@@ -190,7 +190,7 @@ discard block
		block discarded – undo
190	190	*/
191	191	public function columnCount() {
192	192	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
193		- return $this->invokeEventHandler($methodName, array(), function () {
	193	+ return $this->invokeEventHandler($methodName, array(), function() {
194	194	return 0;
195	195	});
196	196	}
		@@ -201,7 +201,7 @@ discard block
		block discarded – undo
201	201	*/
202	202	public function getColumnMeta($column) {
203	203	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
204		- return $this->invokeEventHandler($methodName, array($column), function () {
	204	+ return $this->invokeEventHandler($methodName, array($column), function() {
205	205	return [];
206	206	});
207	207	}
		@@ -213,7 +213,7 @@ discard block
		block discarded – undo
213	213	*/
214	214	public function setFetchMode($mode, $params = NULL) {
215	215	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
216		- return $this->invokeEventHandler($methodName, array($mode), function () {
	216	+ return $this->invokeEventHandler($methodName, array($mode), function() {
217	217	return true;
218	218	});
219	219	}
		@@ -223,7 +223,7 @@ discard block
		block discarded – undo
223	223	*/
224	224	public function nextRowset() {
225	225	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
226		- return $this->invokeEventHandler($methodName, array(), function () {
	226	+ return $this->invokeEventHandler($methodName, array(), function() {
227	227	return true;
228	228	});
229	229	}
		@@ -233,7 +233,7 @@ discard block
		block discarded – undo
233	233	*/
234	234	public function closeCursor() {
235	235	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
236		- return $this->invokeEventHandler($methodName, array(), function () {
	236	+ return $this->invokeEventHandler($methodName, array(), function() {
237	237	return true;
238	238	});
239	239	}
		@@ -243,7 +243,7 @@ discard block
		block discarded – undo
243	243	*/
244	244	public function debugDumpParams() {
245	245	$methodName = $this->methodNameGenerator->getQualifiedMethodName(__FUNCTION__);
246		- return $this->invokeEventHandler($methodName, array(), function () {
	246	+ return $this->invokeEventHandler($methodName, array(), function() {
247	247	return true;
248	248	});
249	249	}

rkrx / php-fakepdo

Push — master ( 1d9f92...387426 )

Status

Category

Doc Comments -3 removed lines patch added patch discarded remove patch

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch