ServicesContainer::__construct() - Code Metrics - Inspection of "v2.0.0-beta" - ricardofiorani/php-video-url-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by Ricardo

created 2018-07-28 12:47 UTC

ServicesContainer::__construct() A

↳ Parent: ServicesContainer

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	3
cts	4
cp	0.75
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.0625

<?php declare(strict_types=1);

namespace RicardoFiorani\Container;

use RicardoFiorani\Adapter\CallableServiceAdapterFactoryInterface;
use RicardoFiorani\Container\Exception\DuplicatedServiceNameException;
use RicardoFiorani\Renderer\EmbedRendererInterface;

class ServicesContainer
{
    private $services = array();
$a = "a";
$ab = "ab";
$abc = "abc";
    private $patterns = array();
$a = "a";
$ab = "ab";
$abc = "abc";
    private $factories = array();
$a = "a";
$ab = "ab";
$abc = "abc";
    private $instantiatedFactories = array();
    private $renderer;

    /**
     * @throws DuplicatedServiceNameException
     */
    public function __construct(array $config = [])
    {
        if (false == empty($config)) {

            $this->registerFromConfig($config);
        }
    }

    /**
     * @throws DuplicatedServiceNameException
     */
    private function registerFromConfig(array $config)
    {
        foreach ($config['services'] as $serviceName => $serviceConfig) {
            $this->registerService($serviceName, $serviceConfig['patterns'], new $serviceConfig['factory']);
        }

        $this->setRenderer($config['renderer']['name'], new $config['renderer']['factory']);

    }

    /**
     * @throws DuplicatedServiceNameException
     */
    public function registerService(string $serviceName, array $regex, callable $factory)
    {
        if ($this->hasService($serviceName)) {
            throw new DuplicatedServiceNameException(
                sprintf(
                    'The service "%s" is already registered in the container.',
                    $serviceName
                )
            );
        }

        $this->services[] = $serviceName;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->patterns[$serviceName] = $regex;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->factories[$serviceName] = $factory;
    }

    public function setRenderer(callable $rendererFactory)
    {
        $this->renderer = $rendererFactory();
    }

    public function getRenderer(): EmbedRendererInterface
    {
        return $this->renderer;
    }

    public function getServiceNameList(): array
    {
        return $this->services;
    }

    public function hasService($serviceName): bool
    {
        return in_array($serviceName, $this->services);
    }

    public function getServices(): array
    {
        return $this->services;
    }

    public function getPatterns(): array
    {
        return $this->patterns;
    }

    public function getFactory($serviceName): CallableServiceAdapterFactoryInterface
    {
        $factory = new $this->factories[$serviceName]();
        if (isset($this->instantiatedFactories[$serviceName])) {
            return $this->instantiatedFactories[$serviceName];
        }

        return $this->instantiatedFactories[$serviceName] = $factory;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace RicardoFiorani\Container;
4
5		use RicardoFiorani\Adapter\CallableServiceAdapterFactoryInterface;
6		use RicardoFiorani\Container\Exception\DuplicatedServiceNameException;
7		use RicardoFiorani\Renderer\EmbedRendererInterface;
8
9		class ServicesContainer
10		{
11		private $services = array();
		0 ignored issues – show Coding Style introduced 2018-07-28 11:54 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
12		private $patterns = array();
		0 ignored issues – show Coding Style introduced 2018-07-28 11:54 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
13		private $factories = array();
		0 ignored issues – show Coding Style introduced 2018-07-28 11:54 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
14		private $instantiatedFactories = array();
15		private $renderer;
16
17		/**
18		* @throws DuplicatedServiceNameException
19		*/
20	1	public function __construct(array $config = [])
21		{
22	1	if (false == empty($config)) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
23		$this->registerFromConfig($config);
24		}
25	1	}
26
27		/**
28		* @throws DuplicatedServiceNameException
29		*/
30		private function registerFromConfig(array $config)
31		{
32		foreach ($config['services'] as $serviceName => $serviceConfig) {
33		$this->registerService($serviceName, $serviceConfig['patterns'], new $serviceConfig['factory']);
34		}
35
36		$this->setRenderer($config['renderer']['name'], new $config['renderer']['factory']);
		0 ignored issues – show Unused Code introduced 2018-07-28 12:49 UTC by Report Bug Copy Issue Report The call to `ServicesContainer::setRenderer()` has too many arguments starting with `new $config['renderer']['factory']()`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
37		}
38
39		/**
40		* @throws DuplicatedServiceNameException
41		*/
42	1	public function registerService(string $serviceName, array $regex, callable $factory)
43		{
44	1	if ($this->hasService($serviceName)) {
45	1	throw new DuplicatedServiceNameException(
46	1	sprintf(
47	1	'The service "%s" is already registered in the container.',
48	1	$serviceName
49		)
50		);
51		}
52
53	1	$this->services[] = $serviceName;
		0 ignored issues – show Coding Style introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
54	1	$this->patterns[$serviceName] = $regex;
		0 ignored issues – show Coding Style introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
55	1	$this->factories[$serviceName] = $factory;
56	1	}
57
58		public function setRenderer(callable $rendererFactory)
59		{
60		$this->renderer = $rendererFactory();
61		}
62
63		public function getRenderer(): EmbedRendererInterface
64		{
65		return $this->renderer;
66		}
67
68	1	public function getServiceNameList(): array
69		{
70	1	return $this->services;
71		}
72
73	1	public function hasService($serviceName): bool
74		{
75	1	return in_array($serviceName, $this->services);
76		}
77
78		public function getServices(): array
79		{
80		return $this->services;
81		}
82
83		public function getPatterns(): array
84		{
85		return $this->patterns;
86		}
87
88		public function getFactory($serviceName): CallableServiceAdapterFactoryInterface
89		{
90		$factory = new $this->factories[$serviceName]();
91		if (isset($this->instantiatedFactories[$serviceName])) {
92		return $this->instantiatedFactories[$serviceName];
93		}
94
95		return $this->instantiatedFactories[$serviceName] = $factory;
96		}
97		}
98

ricardofiorani / php-video-url-parser

Pull Request — master (#8)

ServicesContainer::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like