RicardoFiorani\Container\ServicesContainer

Complexity

Total Complexity

14

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

45.95%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	registerFromConfig()	0	8	2
A	registerService()	0	15	2
A	setRenderer()	0	4	1
A	getRenderer()	0	4	1
A	getServiceNameList()	0	4	1
A	hasService()	0	4	1
A	getServices()	0	4	1
A	getPatterns()	0	4	1
A	getFactory()	0	9	2

<?php declare(strict_types=1);

namespace RicardoFiorani\Container;

use RicardoFiorani\Adapter\CallableServiceAdapterFactoryInterface;
use RicardoFiorani\Container\Exception\DuplicatedServiceNameException;
use RicardoFiorani\Renderer\EmbedRendererInterface;

class ServicesContainer
{
    private $services = array();

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

    private $patterns = array();

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

    private $factories = array();

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

    private $instantiatedFactories = array();
    private $renderer;

    /**
     * @throws DuplicatedServiceNameException
     */
    public function __construct(array $config = [])
    {
        if (false == empty($config)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $this->registerFromConfig($config);
        }
    }

    /**
     * @throws DuplicatedServiceNameException
     */
    private function registerFromConfig(array $config)
    {
        foreach ($config['services'] as $serviceName => $serviceConfig) {
            $this->registerService($serviceName, $serviceConfig['patterns'], new $serviceConfig['factory']);
        }

        $this->setRenderer($config['renderer']['name'], new $config['renderer']['factory']);

The call to ServicesContainer::setRenderer() has too many arguments starting with new $config['renderer']['factory']().

    }

    /**
     * @throws DuplicatedServiceNameException
     */
    public function registerService(string $serviceName, array $regex, callable $factory)
    {
        if ($this->hasService($serviceName)) {
            throw new DuplicatedServiceNameException(
                sprintf(
                    'The service "%s" is already registered in the container.',
                    $serviceName
                )
            );
        }

        $this->services[] = $serviceName;

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

        $this->patterns[$serviceName] = $regex;

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

        $this->factories[$serviceName] = $factory;
    }

    public function setRenderer(callable $rendererFactory)
    {
        $this->renderer = $rendererFactory();
    }

    public function getRenderer(): EmbedRendererInterface
    {
        return $this->renderer;
    }

    public function getServiceNameList(): array
    {
        return $this->services;
    }

    public function hasService($serviceName): bool
    {
        return in_array($serviceName, $this->services);
    }

    public function getServices(): array
    {
        return $this->services;
    }

    public function getPatterns(): array
    {
        return $this->patterns;
    }

    public function getFactory($serviceName): CallableServiceAdapterFactoryInterface
    {
        $factory = new $this->factories[$serviceName]();
        if (isset($this->instantiatedFactories[$serviceName])) {
            return $this->instantiatedFactories[$serviceName];
        }

        return $this->instantiatedFactories[$serviceName] = $factory;
    }
}