rhertogh\Yii2Oauth2Server\controllers\console\client\Oauth2UpdateClientAction

Complexity

Total Complexity

4

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	run()	0	16	4

<?php

namespace rhertogh\Yii2Oauth2Server\controllers\console\client;

use League\OAuth2\Server\Grant\GrantTypeInterface;
use rhertogh\Yii2Oauth2Server\controllers\console\client\base\Oauth2BaseEditClientAction;
use rhertogh\Yii2Oauth2Server\controllers\console\Oauth2ClientController;
use rhertogh\Yii2Oauth2Server\helpers\DiHelper;
use rhertogh\Yii2Oauth2Server\interfaces\components\openidconnect\scope\Oauth2OidcScopeCollectionInterface;
use rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientInterface;
use rhertogh\Yii2Oauth2Server\Oauth2Module;
use Yii;
use yii\base\Action;
use yii\base\InvalidArgumentException;
use yii\console\ExitCode;
use yii\helpers\ArrayHelper;
use yii\helpers\Console;

/**
 * @property Oauth2ClientController $controller
 */
class Oauth2UpdateClientAction extends Oauth2BaseEditClientAction
{
    public function run($id)
    {
        $controller = $this->controller;
        $client = $this->findByIdOrIdentifier($id);

        $this->editClient($client);
        $clientScopes = $client->getClientScopes()->with('scope')->all();

The method getClientScopes() does not exist on rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2ActiveRecordInterface. It seems like you code against a sub-type of said class. However, the method does not exist in rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2RefreshTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2TokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2EnabledInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2RefreshTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface. Are you sure you never get one of those?

The call to yii\db\ActiveQueryInterface::with() has too many arguments starting with 'scope'.

        $scopes = implode(' ', ArrayHelper::getColumn($clientScopes, 'scope.identifier'));

        if ($controller->interactive || $controller->verbose) {
            $controller->stdout('Successfully updated client with id "' . $client->getPrimaryKey()

Are you sure $client->getPrimaryKey() of type array|mixed|null can be used in concatenation?

                . '", identifier "' . $client->getIdentifier()

The method getIdentifier() does not exist on rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2ActiveRecordInterface. It seems like you code against a sub-type of said class. However, the method does not exist in rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2TokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2EnabledInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface. Are you sure you never get one of those?

                . '"' . ($scopes ? (' and scopes "' . $scopes . '"') : '') . '.' . PHP_EOL, Console::FG_GREEN);
        }

        return ExitCode::OK;
    }
}