rhertogh\Yii2Oauth2Server\controllers\console\client\Oauth2UpdateClientAction::run()

Complexity

Conditions	4
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function run($id)
    {
        $controller = $this->controller;
        $client = $this->findByIdOrIdentifier($id);

        $this->editClient($client);
        $clientScopes = $client->getClientScopes()->with('scope')->all();

The method getClientScopes() does not exist on rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2ActiveRecordInterface. It seems like you code against a sub-type of said class. However, the method does not exist in rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2RefreshTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2TokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2EnabledInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2RefreshTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface. Are you sure you never get one of those?

The call to yii\db\ActiveQueryInterface::with() has too many arguments starting with 'scope'.

        $scopes = implode(' ', ArrayHelper::getColumn($clientScopes, 'scope.identifier'));

        if ($controller->interactive || $controller->verbose) {
            $controller->stdout('Successfully updated client with id "' . $client->getPrimaryKey()

Are you sure $client->getPrimaryKey() of type array|mixed|null can be used in concatenation?

                . '", identifier "' . $client->getIdentifier()

The method getIdentifier() does not exist on rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2ActiveRecordInterface. It seems like you code against a sub-type of said class. However, the method does not exist in rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AuthCodeScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2TokenInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2AccessTokenScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\base\Oauth2EnabledInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientScopeInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientInterface or rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserClientScopeInterface. Are you sure you never get one of those?

                . '"' . ($scopes ? (' and scopes "' . $scopes . '"') : '') . '.' . PHP_EOL, Console::FG_GREEN);
        }

        return ExitCode::OK;
    }