Oauth2UserRepository::getUserEntityByUserCredentials()

Complexity

Conditions	6
Paths	6

Size

Total Lines	36
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getUserEntityByUserCredentials(
        $username,
        $password,
        $grantType,
        ClientEntityInterface $clientEntity
    ) {
        $userClass = $this->getModelClass();
        if (!is_a($userClass, Oauth2PasswordGrantUserInterface::class, true)) {
            throw new \TypeError(
                'In order to support the `password` grant type, ' . $userClass

Are you sure $userClass of type rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface can be used in concatenation? Consider adding a __toString()-method.

                    . ' must implement ' . Oauth2PasswordGrantUserInterface::class
            );
        }

        /** @var Oauth2UserInterface|null $user */
        $user = $userClass::findByUsername($username);

The method findByUsername() does not exist on rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface. It seems like you code against a sub-type of said class. However, the method does not exist in rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2OidcUserInterface. Are you sure you never get one of those?

        if (empty($user)) {
            return null;
        }
        if (!($user instanceof Oauth2UserInterface)) {

$user is always a sub-type of rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface.

            throw new \TypeError(
                $userClass . '::findByUsername() must return an instance of ' . Oauth2UserInterface::class
            );
        }
        if (!($user instanceof Oauth2PasswordGrantUserInterface)) {
            throw new \TypeError(
                'In order to support the `password` grant type, ' . $userClass
                    . '::findByUsername() must return an instance of ' . Oauth2PasswordGrantUserInterface::class
            );
        }

        if ($user->validatePassword($password)) {
            return $user;
        }

        return null;
    }